943227 - [DSDS] When device is out of coverage, only SIM 2 icon on status bar is correct.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Enpei]

Attachment: Time stamp: 14:32, 11/26. Dialing MO call failed to make sure SIM 1 didn't camp on network.

When device is out of coverage, only SIM 2 icon on status bar is correct while SIM 1 icon is only grey bars without red "x" on it. Please refer to UX spec in bug 917705.

* Build Number                
Gaia:     671a7c1fae1c32a77b2675636c7efdf089fd6443
Gecko:    b79ea773754854e17566f302e80e2654d9c155c9
BuildID   20131126092608
Version   28.0a1

* Reproduce Steps
Let device enter no network coverage area. Check RSSI icon on status bar.

* Expected Result
Both SIM should have correct icon.

* Actual Result
SIM 2 icon is correct, but SIM 1 icon is only grey bars without red "x" on it.

* Occurrence rate
100%

Comment 1

[Kai-Chih Hu [:khu]]

Arthur, can you help this one?

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

I found that the `voice.emergencyCallsOnly` property of the first sim slot is true, so that we won't display a red `x` on it. The red `x` means we don't have any signal and unavailable for emergency calls. The same behavior can be observed on single sim devices.

Comment 3

[Enpei]

Hi Carrie,

Do you agree with comment 2? If so, could you help to update RSSI part of DSDS 1.3 spec?

Thanks.

Comment 4

[Carrie Wang [New account: [e-mail]]]

I'd like to know the single SIM situation. If it's out of coverage on single SIM, do we show the icon with the x? If so, then dual SIM should definitely follow the same rule. Thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

We don't show the icon if it is still able to make emergency calls.

Comment 6

[Enpei]

(In reply to cawang from comment #4)
> I'd like to know the single SIM situation. If it's out of coverage on single
> SIM, do we show the icon with the x? If so, then dual SIM should definitely
> follow the same rule. Thanks!

Hi Carrie,

For single SIM, there is no "x" icon as well. Sorry that I have to ni? you again to confirm if this is acceptable, could you help to update RSSI spec for DSDS?

Comment 7

[Carrie Wang [New account: [e-mail]]]

Hi Enpei,

yes, we think it shall be consistent that both single SIM and DSDS shall show "x" when it's out of coverage.
Thanks!

Comment 8

[Enpei]

Based on UX comment 7, reopen the bug.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

After confirmed with Edgar and Hsin-yi, the behavior of the properties are as the following:

- When voice.connected is true, emergencyCallsOnly is always false, and voice.state is always "registered".
- When voice.connected is false, emergencyCallsOnly is always true, and voice.state must not equal to "registered".

Per an offline discussion with Carrie, we agree with the following behavior:

- If the device is connected to a network (voice.connected is true), show the normal signal bars based on the signal strength (even if it is zero).
- If the device is not connected to a network (voice.connected is false), show the signal bars with a red "x".

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/15760

Per comment 9, we don't need to check emergencyCallsOnly when voice.connected is false. In this patch I remove the emergencyCallsOnly attribute and related logic and styles.

Alive, could you help review the patch? Thanks!

Comment 11

[Sandip Kamat]

release triage assessment: fix for 1.3

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 04c6d23125dd52b1ca4b9c33be1344ffe33e8c5d

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 04c6d23125dd52b1ca4b9c33be1344ffe33e8c5d to:
v1.3: ab86d5a6920e278bdc106751a2dcdeb1f93b9cf8

Comment 14

[Enpei]

Verified. 

Fugu
Gaia      bb36b4164d3e51ca04b612e507e1178f80bf240d
Gecko     4227240a4d3e1e418ced160c2a48cb454d7b5645
BuildID   20140204104742
Version   28.0