943335 - [TB] Update icons used in searchplugins (Yahoo, eBay, Wikipedia, Amazon, Bing, Twitter)

Status: RESOLVED WORKSFORME

(Thunderbird :: Search, defect)

Description

[Ian Neal]

Things to be done:
* Update searchplugin icons
* Update searchplugin urls

Comment 1

[Ian Neal]

Attachment: Update icons and urls

I'm not sure that all the URLs / Params within the URLs are correct.
Specifically:
a) The tag param for Amazon
b) The form param values for Bing
c) The json template for Google
d) Additional params for Twitter
e) Whether a MozParam is needed for Yahoo

Comment 2

[Axel Hecht [:Pike]]

(In reply to Ian Neal from comment #1)
> Created attachment 8338455 [details] [diff] [review]
> Update icons and urls
> 
> I'm not sure that all the URLs / Params within the URLs are correct.
> Specifically:
> a) The tag param for Amazon
> b) The form param values for Bing
> c) The json template for Google
> d) Additional params for Twitter
> e) Whether a MozParam is needed for Yahoo

Joanne, would you know if any of these are OK for Thunderbird?

Comment 3

[Joanne Nagel]

The Amazon, Bing and eBay ones are fine.  I do not have information for the rest.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 8338455 [details] [diff] [review]
Update icons and urls

Review of attachment 8338455 [details] [diff] [review]:
-----------------------------------------------------------------

Then I'll give this an r- for the flag changes to wikipedia and yahoo. If we don't know what's right, let's not change it.

Comment 5

[Ian Neal]

Attachment: Revised update of search icons/providers

The following icons are now updated to the same as in Firefox:
Amazon
Bing
eBay
Google
Twitter
Wikipedia
Yahoo

The following search providers have had parameters updated to match Firefox:
Amazon
Bing
eBay

Comment 6

[Nomis101]

Will this also fix Bug 795617?

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8356525 [details] [diff] [review]
Revised update of search icons/providers

Review of attachment 8356525 [details] [diff] [review]:
-----------------------------------------------------------------

There's been a couple of icon updates for bing and yahoo in December, so I think we should pick those up. Additionally, there's bug 950204 which I think would be very useful for us to get.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Nomis101 from comment #6)
> Will this also fix Bug 795617?

Comment 9

[Wayne Mery (:wsmwk)]

I think it's fair to say that iann isn't going to finish this

Comment 10

[Ian Neal]

Sorry, lost track of this

Comment 11

[Ian Neal]

I would say, looking at the repo, this has been superseded by the landing of Bug 1544013. Either WFM or INVALID