Closed Bug 943335 Opened 7 years ago Closed 5 months ago

[TB] Update icons used in searchplugins (Yahoo, eBay, Wikipedia, Amazon, Bing, Twitter)

Categories

(Thunderbird :: Search, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: iann_bugzilla, Unassigned)

References

Details

(Keywords: productization)

Attachments

(2 files)

Things to be done:
* Update searchplugin icons
* Update searchplugin urls
I'm not sure that all the URLs / Params within the URLs are correct.
Specifically:
a) The tag param for Amazon
b) The form param values for Bing
c) The json template for Google
d) Additional params for Twitter
e) Whether a MozParam is needed for Yahoo
Attachment #8338455 - Flags: feedback?(l10n)
Keywords: productization
Summary: Update icons used in searchplugins (Yahoo, eBay, Wikipedia, Amazon, Bing, Twitter) → [TB] Update icons used in searchplugins (Yahoo, eBay, Wikipedia, Amazon, Bing, Twitter)
(In reply to Ian Neal from comment #1)
> Created attachment 8338455 [details] [diff] [review]
> Update icons and urls
> 
> I'm not sure that all the URLs / Params within the URLs are correct.
> Specifically:
> a) The tag param for Amazon
> b) The form param values for Bing
> c) The json template for Google
> d) Additional params for Twitter
> e) Whether a MozParam is needed for Yahoo

Joanne, would you know if any of these are OK for Thunderbird?
Flags: needinfo?(jnagel)
The Amazon, Bing and eBay ones are fine.  I do not have information for the rest.
Flags: needinfo?(jnagel)
Comment on attachment 8338455 [details] [diff] [review]
Update icons and urls

Review of attachment 8338455 [details] [diff] [review]:
-----------------------------------------------------------------

Then I'll give this an r- for the flag changes to wikipedia and yahoo. If we don't know what's right, let's not change it.
Attachment #8338455 - Flags: feedback?(l10n) → feedback-
The following icons are now updated to the same as in Firefox:
Amazon
Bing
eBay
Google
Twitter
Wikipedia
Yahoo

The following search providers have had parameters updated to match Firefox:
Amazon
Bing
eBay
Attachment #8356525 - Flags: feedback?(l10n)
Will this also fix Bug 795617?
Attachment #8356525 - Flags: feedback?(l10n) → feedback+
Attachment #8356525 - Flags: review?(mbanner)
Comment on attachment 8356525 [details] [diff] [review]
Revised update of search icons/providers

Review of attachment 8356525 [details] [diff] [review]:
-----------------------------------------------------------------

There's been a couple of icon updates for bing and yahoo in December, so I think we should pick those up. Additionally, there's bug 950204 which I think would be very useful for us to get.
Attachment #8356525 - Flags: review?(mbanner) → review-
(In reply to Nomis101 from comment #6)
> Will this also fix Bug 795617?
Severity: normal → minor
Flags: needinfo?(iann_bugzilla)
See Also: → 1427133

I think it's fair to say that iann isn't going to finish this

Status: ASSIGNED → NEW
Flags: needinfo?(iann_bugzilla)

Sorry, lost track of this

Status: NEW → ASSIGNED

I would say, looking at the repo, this has been superseded by the landing of Bug 1544013. Either WFM or INVALID

Assignee: iann_bugzilla → nobody
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Component: Mail Window Front End → Search
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.