943712 - Build parts of dom/mobilemessage in unified mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[(no longer active)]

Attachment: Build parts of dom/mobilemessage in unified mode; r=gene

Comment 2

[(no longer active)]

Comment on attachment 8338995 [details] [diff] [review]
Build parts of dom/mobilemessage in unified mode; r=gene

https://tbpl.mozilla.org/?tree=Try&rev=ecae84623acb

Comment 3

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8338995 [details] [diff] [review]
Build parts of dom/mobilemessage in unified mode; r=gene

Review of attachment 8338995 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Ehsan for cleaning this up! I've been thinking of doing this at some time points.

Btw, we're planning to get rid of |convertTimeToInt| at bug 939302, comment #15, but I think we can go ahead to land this first.

::: dom/mobilemessage/src/ipc/SmsIPCService.cpp
@@ +281,5 @@
>      return false;
>    }
>  
>    for (uint32_t i = 0; i < params.mAttachments.Value().Length(); i++) {
> +    dom::MmsAttachment& attachment = params.mAttachments.Value()[i];

Why did the original codes work? Just curious about it.

Comment 4

[(no longer active)]

(In reply to Gene Lian [:gene] (needinfo? encouraged) from comment #3)
> Comment on attachment 8338995 [details] [diff] [review]
> Build parts of dom/mobilemessage in unified mode; r=gene
> 
> Review of attachment 8338995 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks Ehsan for cleaning this up! I've been thinking of doing this at some
> time points.
> 
> Btw, we're planning to get rid of |convertTimeToInt| at bug 939302, comment
> #15, but I think we can go ahead to land this first.

Sounds good.

> ::: dom/mobilemessage/src/ipc/SmsIPCService.cpp
> @@ +281,5 @@
> >      return false;
> >    }
> >  
> >    for (uint32_t i = 0; i < params.mAttachments.Value().Length(); i++) {
> > +    dom::MmsAttachment& attachment = params.mAttachments.Value()[i];
> 
> Why did the original codes work? Just curious about it.

When building in unified mode, a previous .cpp file pull this in <http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/ipc/SmsTypes.ipdlh#43> and that name clashes with this name (they are two classes in two different namespaces), so I had to explicitly denote the namespace of the class that this code was using.

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e6abaea8f58

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e6abaea8f58

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Fixed the --disable-unified-compilation build:
http://hg.mozilla.org/integration/mozilla-inbound/rev/897485d481de

Comment 8

[Mike Hommey [:glandium]]

(In reply to Benoit Jacob [:bjacob] from comment #7)
> Fixed the --disable-unified-compilation build:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/897485d481de

That was bug 944834

Comment 10

[Gene Lian (I already quit Mozilla)]

Thank you guys!

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/897485d481de