944077 - [Flatfish] Remove portrait lock

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Jason Smith [:jsmith]]

Meta bug.

This bug tracks the necessary work required to implement landscape-based UI designs for marketplace consumer pages for Flatfish.

Comment 1

[Caspy7]

We have 500 tablets going out to testers (in many countries) over the next several days.  This issue makes the experience rather unpleasant as all other apps are landscape and suddenly everything goes sideways.
Notably, the marketplace will be one of the first and most frequent apps used on a brand new tablet (as it has virtually no apps).

Also, I noticed this is a Meta bug, but there don't seem to be any dependencies.  Perhaps there is work that's been done elsewhere?

Comment 2

[Wil Clouser [:clouserw]]

I agree it's a jarring experience.  There isn't work elsewhere.  This is simply a victim of other projects with higher priority.

Comment 4

[Andy McKay]

FYI the lock was added here: bug 844186

Comment 5

[Andy McKay]

Let's remove the portait lock that was added in bug 844186.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Is UX aware of the design implications here? I'm not sure we've updated our designs to work with these different orientations in mind?

Comment 7

[Tony Santos [:tsmuse]]

Things should work, but the UX team doesn't have any of these tablets to test with, so I can't make any guarantees. What is the reasoning behind removing the orientation lock? It's not really clear to me in this bug thread. Have we actually tested the assumption that "the experience rather unpleasant as all other apps are landscape and suddenly everything goes sideways?" That isn't the case on other mobile platforms, in my experience.

Comment 8

[Wil Clouser [:clouserw]]

It's really awkward.  If you can, grab a tablet in the office and try it.

We talked about this at the uiwanted triage meeting I think and all felt this restriction was unnecessary.

Comment 9

[Caspy7]

Currently this only affects Flatfish devices. Updating things so it shows properly in our bug lists.

UX has no flatfish device? :( That's not optimal.

Comment 10

[Wil Clouser [:clouserw]]

This affects any device that can rotate - way more than flatfish.  I don't mind it being in the title though as it's most jarring on a tablet.

Comment 11

[Dethe Elza [:dethe]]

Fixed in two repos:

* Zamboni: https://github.com/mozilla/zamboni/pull/2336
* Fireplace: https://github.com/mozilla/fireplace/pull/524

Comment 12

[Madalin Cotetiu]

We tested on different devices, Android tablet , Flame and everything works as expected, but we will leave this opened for a final testing with a Flatfish device.