948001 - [Settings] With APZ turned on the wifi panel is sometimes shown instead of the main panel at startup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Seems like there is a race here. The app starts with a viewport of 968px and then is resize to device-width. But this is too late since the rotate callback has already fired and start to load the wifi panel.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Delay a bit the rotation listener

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8344757 [details] [diff] [review]
Delay a bit the rotation listener

Review of attachment 8344757 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/settings/js/settings.js
@@ +800,4 @@
>        console.log('go to default Panel ' + Settings.defaultPanelForTablet);
>        Settings.currentPanel = Settings.defaultPanelForTablet;
>      }
> +

We need to set ScreenLayout (calling to watch) before calling to Settings.isTabletAndLandscape() in which we get layout information from ScreenLayout.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug909877.patch

Is it better ?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8345235 [details] [diff] [review]
bug909877.patch

r=me. Thanks!

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/d1f2320d77bca838ecf560e7ce5bca43c28e887e

This patch needs to land on 1.3.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/46b682ae19fb8679542ea1714ccb5384f5bdaa84

Pushed in 1.3.