Closed
Bug 94831
Opened 23 years ago
Closed 23 years ago
convert mozilla/intl/locale/src/nsLocalModule to generic module
Categories
(Core :: Internationalization, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: waterson, Assigned: waterson)
References
Details
(Keywords: topembed, Whiteboard: fixed-on-trunk)
Attachments
(7 files)
16.85 KB,
patch
|
Details | Diff | Splinter Review | |
12.59 KB,
patch
|
Details | Diff | Splinter Review | |
115.79 KB,
patch
|
Details | Diff | Splinter Review | |
138.35 KB,
patch
|
Details | Diff | Splinter Review | |
142.98 KB,
patch
|
Details | Diff | Splinter Review | |
5.19 KB,
patch
|
Details | Diff | Splinter Review | |
145.64 KB,
patch
|
Details | Diff | Splinter Review |
Need to convert this to a generic module to get static build to work right.
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
I removed nsLocaleFactoryUnix.[h|cpp], and replaced the ad hoc module implementation in nsLocaleModule.cpp with generic module stuff. ftang, please review, or find somebody to review -- thanks!
Assignee | ||
Comment 3•23 years ago
|
||
I should note that the above patch was made against MOZILLA_0_9_2_BRANCH. I'll attach a patch for the trunk shortly.
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Comment 6•23 years ago
|
||
For this to work, we need to apply attachment 45489 [details] [diff] [review] (for Unix), attachment 45746 [details] [diff] [review] (for Windows), and attachment 45703 [details] [diff] [review] from bug 93556 (for Mac).
Comment 8•23 years ago
|
||
I feel so embarssed that we stil have this code here. Thanks waterson, I should buy you a lunch for doing this for us.... r=ftang
Assignee | ||
Comment 9•23 years ago
|
||
Okay, so the above patch is not sufficient. Whoever wrote the COM glue for the locale module was very...creative. I'm going to need to rewrite most of it. *sob*
Assignee | ||
Comment 10•23 years ago
|
||
*** Bug 93566 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 11•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
Okay, here's what I did. - The old locale that tague (?) wrote had hand-coded factories for every class. I replaced those with generic factories as best I could. - Along those lines, got rid of ns[IWin32|Mac|OS2|Posix]LocaleFactory.[h|cpp], which are not needed. (Actually, still need to do OS2, ...) - I removed the nsI[IWin32|Mac|OS2|Posix]Locale.h interfaces (which were all identical), and replaced them with nsIPlatformLocale. - Got rid of ns[I]LocalFactory.[h|cpp], as it was obsolete (assertions in the ctor). - Normalized nsLocale[DLL|Module|SHLIB].cpp to use generic factory stuff - Got rid of hard-coded CIDs and IIDs where reasonable. Still need to test on Mac and Win32. Could use some help on OS/2 also.
Comment 13•23 years ago
|
||
I'm having trouble applying the diff. I'll look at it though.
Assignee | ||
Comment 14•23 years ago
|
||
Comment 15•23 years ago
|
||
What user actions excercise this code?
Assignee | ||
Comment 16•23 years ago
|
||
Well, I get some assertions at startup if it's wrong, but I have _no_ idea what it does or where it is being used.
Assignee | ||
Comment 17•23 years ago
|
||
Assignee | ||
Comment 18•23 years ago
|
||
Okay, so it turns out that nsI[Mac|OS2|Posix|Win32]Locale are all subtly different in mysterious ways. So, I've put those interfaces back the way they were. The above patch compiles and runs on Unix and Windows, makes it at least through the intl folder on Mac, and has an honest attempt at getting this right on OS/2. If there are any other nits that I got wrong on the Mac side, I'll attach them anon as my build progresses.
Assignee | ||
Comment 19•23 years ago
|
||
I crash-landed this onto the trunk tonight.
assignee_accessible: 1 → 0
CC list accessible: false
qacontact_accessible: 1 → 0
Not accessible to reporter
Whiteboard: fixed-on-trunk
Assignee | ||
Comment 20•23 years ago
|
||
Updated•23 years ago
|
assignee_accessible: 0 → 1
CC list accessible: true
qacontact_accessible: 0 → 1
Accessible to reporter
Comment 21•23 years ago
|
||
Fixing database corruption caused by bug 95743. Pay no attention to the man behind the curtain.
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Assignee | ||
Comment 22•23 years ago
|
||
Comment 23•23 years ago
|
||
Chris, Does you branch patch have the os/2 bustage fixes you did in it? http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&su bdir=mozilla/intl/locale/src/os2&command=DIFF_FRAMESET&file=nsLocaleModule.cpp&r ev1=1.8&rev2=1.9&root=/cvsroot
Assignee | ||
Comment 24•23 years ago
|
||
mkaply: yes, it should. I hand-merged files from the trunk, and hopefully caught everything. When (if?) I land these, would you mind if I ping'd you to do a build?
Comment 25•23 years ago
|
||
Switching qa contact to teruko for now since it is a topembed bug. Please re-assign further as you see is appropriate.
QA Contact: andreasb → teruko
Comment 26•23 years ago
|
||
let's get it on 0.9.2 branch. thanks
Comment 27•23 years ago
|
||
changing qa contact to yokoyama since it is a coding modification.
QA Contact: teruko → yokoyama
Assignee | ||
Comment 28•23 years ago
|
||
Checked in on the branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•