Closed Bug 950136 Opened 11 years ago Closed 11 years ago

[B2G][Lockscreen] Unable to access the camera app through the lockscreen while passcode is enabled

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C2/1.4 S2(17jan)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: dwatson, Assigned: alive)

References

Details

(Keywords: regression, smoketest, Whiteboard: [xfail][systemsfe])

Attachments

(2 files)

Camera through lockscreen.jpg
4.30 KB, image/jpeg
Details
logcat.txt
113.13 KB, text/plain
Details
Repro Steps: 1. Load Buri to Build ID: 20131213004002 2. Open Settings app 3. Turn on Passcode for lockscreen 4. Lock the open and tap the power button to wake up the device 5. Tap on the camera icon Actual Results: The camera app does not completely load. Expected Results: The user will be able to access the camera app through the lockscreen. Environmental Variables Device: Buri v1.3.0 MOZ RIL Build ID: 20131213004002 Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/dfae9c83bfbc Gaia: 888f9df5515a47d2f5806efee77485e05e1e5416 Platform Version: 28.0a2 Base Build: 20131115 NOTES: When the passcode is not enabled the user is able to access the camera app.
blocking-b2g: --- → 1.3?
Keywords: regression, regressionwindow-wanted, smoketest
The regression window for this bug is 12-12 to 12-13. The camera loaded through the lockscreen on the 12-12 build and was unable to load on the 12-13 build. Last Working Build: Device: Buri 1.3 MOZ BuildID: 20131212004003 Gaia: 588a3e02c4ace3b3341ba1f6bb7274120b53b2b3 Gecko: 031270be3702 Version: 28.0a2 Firmware Version: V1.2_20131115 First Broken Build: Device: Buri 1.3 MOZ BuildID: 20131213004002 Gaia: 888f9df5515a47d2f5806efee77485e05e1e5416 Gecko: dfae9c83bfbc Version: 28.0a2 Firmware Version: V1.2_20131115
Keywords: regressionwindow-wanted
QA Contact: nkhristoforov
Attached file logcat.txt —
logcat from engineering build; we can't get logcat off of a production build.
It looks like the releng is pulling off of master instead of v1.3 branch. From source.xml : <project name="gaia.git" path="gaia" remote="mozillaorg" revision="888f9df5515a47d2f5806efee77485e05e1e5416"/> From github.com: https://github.com/mozilla-b2g/gaia/commit/888f9df5515a47d2f5806efee77485e05e1e5416 Filing a releng bug.
bug 950166 is created to fix the releng builds.
Weird - I don't see anything in the Gaia commit range that could have caused this in the system app & camera app. Could this be a gecko bug?
(In reply to Jason Smith [:jsmith] from comment #5) > Weird - I don't see anything in the Gaia commit range that could have caused > this in the system app & camera app. Could this be a gecko bug? Oh wait, Naoki mentions this using Gaia code from master. Let me look around more.
From the commit link from Naoki, it looks like a change on 12/12 on full screen state. Doubt it is camera related: https://bugzilla.mozilla.org/show_bug.cgi?id=948596 (master and not 1.3 branch though). adding djf to confirm
Flags: needinfo?(dflanagan)
(In reply to Hema Koka [:hema] from comment #7) > From the commit link from Naoki, it looks like a change on 12/12 on full > screen state. Doubt it is camera related: > https://bugzilla.mozilla.org/show_bug.cgi?id=948596 (master and not 1.3 > branch though). > > adding djf to confirm Ah, makes sense. I just dove into the regression range & saw those changes as well. Alive - What do you think?
Flags: needinfo?(alive)
(In reply to Jason Smith [:jsmith] from comment #8) > (In reply to Hema Koka [:hema] from comment #7) > > From the commit link from Naoki, it looks like a change on 12/12 on full > > screen state. Doubt it is camera related: > > https://bugzilla.mozilla.org/show_bug.cgi?id=948596 (master and not 1.3 > > branch though). > > > > adding djf to confirm > > Ah, makes sense. I just dove into the regression range & saw those changes > as well. > > Alive - What do you think? Ack. Alive is out of office. Tim - Can you answer this question?
Flags: needinfo?(alive) → needinfo?(timdream)
I've just confirmed that a backout of bug 948596 fixes this bug.
Flags: needinfo?(timdream)
Flags: needinfo?(dflanagan)
John - Can you backout bug 948596?
Flags: needinfo?(jhford)
Blocks: 948596
backed it out: [master 30a2d7f] Revert "Merge pull request #14632 from alivedise/bugzilla/948596_v2/activity-window-size-copy"
Flags: needinfo?(jhford)
Fixed via backout.
Status: NEW → RESOLVED
blocking-b2g: 1.3? → 1.3+
Closed: 11 years ago
Resolution: --- → FIXED
Uh, I don't see this bug. The secure camera works for me and it's not an activity. I don't know why backout works...
Apparently the backout didn't work - our automation just hit this bug on a 12/15 build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [xfail]
Alive - Can you dig into this bug? If you confirm this isn't caused by bug 948596, then feel free to reland that patch. I thought I tested the backout here correctly, but apparently not. Don't know why either.
Flags: needinfo?(alive)
Weird. I'm not seeing this issue on my own engineering build for 1.3; could it be a permissions issue?
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #19) > Weird. I'm not seeing this issue on my own engineering build for 1.3; could > it be a permissions issue? Might be a 1.4 only bug - when this was originally filed, it was filed off Gaia master + 1.3 gecko. Can someone check if this reproduces on the latest 1.3 build?
Keywords: qawanted
I could as long as it still happens. qawanted.
Flags: needinfo?(alive)
Assignee: nobody → alive
(In reply to Alive Kuo [:alive][NEEDINFO][OOO:12/24-1/4] from comment #21) > I could as long as it still happens. qawanted. I believe it is reproducing on the 1.4 build. Need to double check 1.3 per Naoki's comments.
(In reply to Jason Smith [:jsmith] from comment #22) > (In reply to Alive Kuo [:alive][NEEDINFO][OOO:12/24-1/4] from comment #21) > > I could as long as it still happens. qawanted. > > I believe it is reproducing on the 1.4 build. Need to double check 1.3 per > Naoki's comments. I cannot repro with master + unagi.... Anyway I am going to reland bug 948596.
QA Wanted - Can someone check if this reproduces on 1.3 eng, 1.3 prod, 1.4 eng, and 1.4 prod?
Interestingly enough, this works fine in our UI automation ran by Taipei on Tuesday morning. Weird.
The bug does not reproduce on 1.3 prod or 1.3 eng. It still reproduces on 1.4 prod and 1.4 eng. Device: Buri 1.3 MOZ BuildID: 20131217004001 Gaia: dca0a3dcf062ce3e422a9c56d141c14543c816fb Gecko: 1f7db4cc788e Version: 28.0a2 Device: Buri 1.4 MOZ BuildID: 20131217040201 Gaia: 545aacf3feff6430140cc9ade757002df4895b77 Gecko: b1e5ade62913 Version: 29.0a1
Keywords: qawanted
blocking-b2g: 1.3+ → 1.4?
Alive - Can you try testing this on a 1.4 Buri? Seems like we can still see this reproducing in our testing.
Flags: needinfo?(alive)
(In reply to Jason Smith [:jsmith] from comment #25) > Interestingly enough, this works fine in our UI automation ran by Taipei on > Tuesday morning. Weird. Change this - this reproduced in the UI automation on Wed morning in Taipei.
Still can reproduce it on Buri and Unagi pvt m-c build. Buri Gaia e6276c96fcf087a12800419be8a9e25fcbbc924d Gecko http://hg.mozilla.org/mozilla-central/rev/5c7fa2bfea8b BuildID 20131219040202 Version 29.0a1 Unagi Gaia e2f0e09e980b1cb3275a0bb033931cb48f9d521c Gecko http://hg.mozilla.org/mozilla-central/rev/862cb6a1cc88 BuildID 20131218040201 Version 29.0a1
E/GeckoConsole( 136): [JavaScript Error: "ReferenceError: CONFIG_MAX_IMAGE_PIXEL_SIZE is not defined" {file: "app://system.gaiamobile.org/camera/js/camera.js" line: 1524}] I believe this is the problem. Finding out how to fix it...
Flags: needinfo?(alive)
Hi all, I found the patch producing this regression: bug 929602, commit: https://github.com/mozilla-b2g/gaia/commit/f2c50479f40ef8bf67b46ef72298926f73adc331 There is a file named config.js in Camera app. That is created with build/application-data.js which is a build-time script. And System app copies Camera app into its camera folder in System app's Makefile. If we run application-data task before app-makefiles task, we will have this issue, config.js is missed in secured camera. In this patch, it changes the sequence of them: -$(PROFILE_FOLDER): multilocale applications-data preferences local-apps app-makefiles test-agent-config offline contacts extensions install-xulrunner-sdk .git/hooks/pre-commit $(PROFILE_FOLDER)/settings.json create-default-data $(PROFILE_FOLDER)/installed-extensions.json +$(PROFILE_FOLDER): multilocale preferences local-apps app-makefiles test-agent-config offline contacts extensions install-xulrunner-sdk .git/hooks/pre-commit $(PROFILE_FOLDER)/settings.json create-default-data $(PROFILE_FOLDER)/installed-extensions.json -applications-data: profile-dir install-xulrunner-sdk +applications-data: profile-dir app-makefiles install-xulrunner-sdk If someone want to test it, please make sure the config.js file does not exist in {GAIA}/apps/camera/js/config.js and run make install-gaia to have the whole gaia build. Because that file will not be deleted when we run any kind of make but it does not exist in the original gaia tree.
Blocks: 929602
No longer blocks: 948596
Component: Gaia::System::Lockscreen → Gaia
Whiteboard: [xfail] → [xfail][systemsfe]
This bug looks like a 1.4+ bug to me.
Buri Gaia 5de94a2be6ab8d33434294d70c1de330f55d8f2d Gecko http://hg.mozilla.org/mozilla-central/rev/c8d5a871ae32 BuildID 20140101040201 Version 29.0a1 Works fine. The Bug 952922 fixed this issue.
Fixed by bug 952922 then.
Status: REOPENED → RESOLVED
blocking-b2g: 1.4? → 1.4+
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
status-b2g-v1.4: --- → fixed
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: