Closed Bug 951635 Opened 6 years ago Closed 6 years ago

Removing animations from tile swipes in snapped view

Categories

(Firefox for Metro Graveyard :: Shell, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(firefox28 verified, firefox29 verified)

VERIFIED FIXED
Firefox 29
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: kjozwiak, Assigned: sfoster)

References

Details

(Whiteboard: [beta28] [defect] p=1 )

Attachments

(1 file)

We should remove the animation from tile swipes while in snapped view as you cannot select tiles while Firefox Metro is in snapped view. Right now the tile will have the animation when a user swipes, but nothing will be selected.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Slide in the Desktop from the left hand side (making the views 50/50)
3) Move Firefox Metro into snapped view
4) Once in snapped view, select "Bookmarks"
5) Swipe any of the bookmarks left or right and you'll notice that they have animations but nothing will be selected

Current Behavior:

- When a user swipes any tile while in snapped view, there will be an animation associated with the swipe but nothing will end up being selected

Expected Behavior:

- As a user, when I see an animation I expect something to happen. We should probably remove the animations.

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-17-08-47-57-mozilla-central/
Summary: Defect - Removing animations from tile swipes in snapped view → Removing animations from tile swipes in snapped view
Whiteboard: feature=defect c=Awesome_screen u=metro_firefox_user p=0 → [triage] [defect] p=0
Whiteboard: [triage] [defect] p=0 → [beta28] [defect] p=0
Point value = 1
Assignee: nobody → sfoster
Blocks: metrov1it22
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [beta28] [defect] p=0 → [beta28] [defect] p=1
Depends on: 957009
No longer depends on: 957009
Previously the richgrid binding would setup cross-slide gesture handling and the associated animations by default. This patch moves that setup to a enableCrossSlide method (and matching disableCrossSlide) which gets called as appropriate by the View's adjustDOMforViewState method.
Attachment #8357883 - Flags: review?(mbrubeck)
Comment on attachment 8357883 [details] [diff] [review]
Move CrossSlide.Handler instantiation to be driven by the View via _adjustDOMforViewState method

Review of attachment 8357883 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/bindings/grid.xml
@@ +653,5 @@
>        </destructor>
> +      <method name="enableCrossSlide">
> +        <body>
> +          <![CDATA[
> +            dump("richgrid#"+this.getAttribute("id") + " enableCrossSlide\n");

Please remove the dump calls before landing.
Attachment #8357883 - Flags: review?(mbrubeck) → review+
Cleaned out dump() calls and landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/c9cdd1b9d1e5
Whiteboard: [beta28] [defect] p=1 → [beta28] [defect] p=1 [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c9cdd1b9d1e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [beta28] [defect] p=1 [fixed-in-fx-team] → [beta28] [defect] p=1
Target Milestone: --- → Firefox 29
Kamil, please verify this is fixed in Nightly and Aurora.
Flags: needinfo?(kamiljoz)
Keywords: verifyme
Depends on: 964149
Went through verification for the following issue during iteration #22 testing. Used the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-27-00-40-03-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-27-03-02-01-mozilla-central/

- Ensured that you couldn't select any tiles while in the smaller snapped views
- Ensured that the tiles can still be taped on while in snapped view (Top Sites, Bookmarks, Recent History)
- Ensured that you can still select tiles while you're in larger "snapped views"
- Ensured that you can clear selected tiles using the "Tile Selection App Bar"
- Ensured that while in snapped view, the Top Sites, Bookmarks and Recent History tiles are inside their own containers
- Ensured that all the tiles still take you to the correct website when taping/clicking on them
- Ensured that all of the above test cases worked on both sides of the screen (snapped view via left/right sides)

The animation has been moved but you can still swipe and slowly select the tile. While this happens, the "tile" appears "frozen/suspended", created Bug #964149

Other issues found during verification:
- Bug #964285
Status: RESOLVED → VERIFIED
Flags: needinfo?(kamiljoz)
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.