Closed Bug 964149 Opened 6 years ago Closed 6 years ago
tile animation "frozen" in snapped view when swiping
227.43 KB, image/jpeg
254.74 KB, image/jpeg
1.89 KB, patch
|Details | Diff | Splinter Review|
When you attempt to select a tile under snapped view by swiping them either up or down, the animation will appear "frozen" and stay in that state until the screen is refreshed. I've reproduced this consistently using the builds listed below. - Attached two screenshots to illustrate the issue Steps to reproduce the issue: 1) Open Firefox Metro 2) Slide in the Desktop from the left side and snap it onto the screen (should be 50/50 at this point) 3) Decrease the size of Firefox Metro so it starts listing "Top Sites", "Bookmarks" and "Recent History" in separate expandable containers 4) Start swiping some of the tiles up/down slowly and you'll notice that they'll become "stuck" in their animation routine and won't return to the default state Current Behaviour: - When swiping tiles while in snapped view, the tiles become "frozen" during their animation routine and stay that way until the screen is refreshed Expected Behaviour: - We should probably disable the animations completely as tiles under snapped view cannot be selected (this was currently worked on in Bug 951635) Issue found using the following builds: - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-26-00-40-02-mozilla-aurora/ - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-26-03-02-03-mozilla-central/
huh, you can do it in non-snapped state too, STR: 1. Open start screen 2. Try to "pinch zoom" the start screen with one finger starting at the corner of a tile. You can't pinch zoom start screen, but you'll end up with a dented tile frozen mid-animation.
Nice find! I reproduced it on both Nightly and Aurora following the STR from comment #2. I also reproduced it using several variations of snapped view configurations(1/3, 1/2, 1/4 etc..)
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
Whiteboard: [release28] [defect] p=0 → [release28] [defect] p=3
Spotted a couple of problems that might cause this. We weren't handling touchcancel events, and you could theoretically get into a state where it was trying to measure and apply the transform twice. This patch addresses both. I was only able to reproduce originally with Rodrigo's STR and the pinch gesture - and have not been able to reproduce with the patch applied.
Assignee: nobody → sfoster
Attachment #8368812 - Flags: review?(rsilveira)
Comment on attachment 8368812 [details] [diff] [review] Tighten up bend/unbend event handling in richgrid Review of attachment 8368812 [details] [diff] [review]: ----------------------------------------------------------------- Works great! ::: browser/metro/base/content/bindings/grid.xml @@ +807,5 @@ > <parameter name="aEvent"/> > <body><![CDATA[ > // apply the transform to the contentBox element of the item > let bendNode = this.isItem(aItem) ? aItem._contentBox : null; > + if (!bendNode || aItem.hasAttribute("beinding")) Misspelled "bending".
Attachment #8368812 - Flags: review?(rsilveira) → review+
Fixed spelling, landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/b670b20cfcc7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
I see the uplift fairy visited :) thanks mbrubeck
Went through the following verification process without any issues. Used the following builds: - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-03-00-40-03-mozilla-aurora/ - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-03-03-02-03-mozilla-central/ Before going through the test cases listed below, I reproduced the issue using an older build on both Nightly/Aurora. - Went through the original test case under comment #0 without any issues - Went through the test case mentioned in comment #2 without any issues - Attempted all the different variations of the animation and ensured none of them ended up "frozen/stuck" (left, right, up and down animations) - Ensured that while in snapped view, tiles under "Top Sites", "Bookmarks" and "Recent History" don't end up "frozen/stuck" - Ensured that both the mouse and touch triggered the correct animations without them looking "frozen/stuck" - Went through several different variations of snapped view and ensured that the tile animations don't becoming "frozen/stuck" (1/2, 1/3, 2/3 etc..) - Ensured that the tiles can still be selected using the swipe gestures - Ensured that taping/clicking on the tiles opens the correct website without any issues
You need to log in before you can comment on or make changes to this bug.