952429 - Port holiday calendar index page to bedrock

Status: VERIFIED FIXED

(Calendar :: Website, defect, P1)

Description

[Andrei Hajdukewycz [:sancus]]

+++ This bug was initially created as a clone of Bug #723267 +++

Porting the holiday calendar index page to bedrock.

Comment 1

[Andrei Hajdukewycz [:sancus]]

Attachment: Holiday Calendar Index

I've put a PR up for this page here: https://github.com/mozilla/bedrock/pull/1547

The way it functions is that metadata(country, authors, filename) is stored in the JSON file: https://github.com/Sancus/bedrock/blob/1727bb227fda8146295d7dca8fd3e8672da97264/media/caldata/calendars.json

and the page dynamically generates the table and shortcuts accordingly.

I've also attached a screenshot, and comments on the layout or functionality are more than welcome. I've done my best to make this page as translatable as possible, as well.

Comment 2

[Magnus Melin [:mkmelin]]

So, can this land? Apparently we can't update holiday files before that? xref bug 948052

Comment 3

[Andrei Hajdukewycz [:sancus]]

This will land early next week.

Comment 4

[Magnus Melin [:mkmelin]]

(In reply to Andrei Hajdukewycz [:sancus] from comment #3)
> This will land early next week.

Ping again. All the holiday calendars for 2014 are still not available due to this (i see around 30 waiting).

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

I've heard from sancus and this is mostly waiting on the PR being processed. He will look into it tomorrow at work.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/4c9227e077fbdf55b55ec97945afc631f6a9db55
[Bug 952429] Add holiday calendar .ics files and json metadata

https://github.com/mozilla/bedrock/commit/cb933e003920c32acdf5be7c0b0fd3f07d420b8c
[Fix Bug 952429] Add Lightning holiday calendar index page

https://github.com/mozilla/bedrock/commit/7bb66f1bdc99f2499467324bf56ec0832cba6f5f
Merge pull request #1547 from Sancus/holidaycalendars

 [Fix Bug 952429] Add Lightning holiday calendar index page

Comment 7

[Andrei Hajdukewycz [:sancus]]

This mainly took so long because I was almost entirely on time off for the last week, so back and forth of changes was very slow. It is now merged, though, and will be live whenever the next bedrock push is. Normally they're very frequent(like every day) so it'll be very soon.

This should unblock calendar submissions though... you can PR them now.

Since there are a bunch, maybe it would make sense to batch them all into one PR, :Fallen?

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/086302275b9dd0e58612447e1aa83ae2a5973d9c
Bug 952429: Fix some urls for the new calendar holidays page.

Also change the redirects for bug 971244 to 301s.

https://github.com/mozilla/bedrock/commit/30ec18e07be02b2bc949661c75f2897f1a8451f7
Merge pull request #1756 from pmclanahan/add-apache-rule-holidays-952429

Bug 952429: Fix some urls for the new calendar holidays page.

Comment 9

[raymond [:retornam] (inactive)]

verified fixed https://www.mozilla.org/en-US/projects/calendar/holidays/