Closed Bug 953439 Opened 10 years ago Closed 10 years ago

[B2G][Tarako]The default NetworkType should be able to config.

Categories

(Firefox OS Graveyard :: Vendcom, defect)

ARM
Other
defect
Not set
major

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: ming.li, Assigned: sam.hua)

References

Details

(Whiteboard: [POVB])

Attachments

(1 file)

For Tarako ,the default networktype is wrong .

The default type is define in ril_constants.js

this.GECKO_PREFERRED_NETWORK_TYPE_DEFAULT = GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM;
But on Tarako ,it should be the follow:
this.GECKO_PREFERRED_NETWORK_TYPE_DEFAULT = GECKO_PREFERRED_NETWORK_TYPE_GSM_ONLY;


So, It's best to make the feature can be configed.
(In reply to Ming from comment #0)
> For Tarako ,the default networktype is wrong .
> 
> The default type is define in ril_constants.js
> 
> this.GECKO_PREFERRED_NETWORK_TYPE_DEFAULT =
> GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM;
> But on Tarako ,it should be the follow:
> this.GECKO_PREFERRED_NETWORK_TYPE_DEFAULT =
> GECKO_PREFERRED_NETWORK_TYPE_GSM_ONLY;
> 
> 
> So, It's best to make the feature can be configed.

Bug 952043 is to provide the network types supported by platform for Gaia. Once that bug fixed, gaia could be more intelligent to set the workable default type.
Component: RIL → Gaia::Settings
Depends on: 952043
Hsinyi, could you give an update on this?
Flags: needinfo?(htsai)
Depends on: 980831
(In reply to James Ho from comment #2)
> Hsinyi, could you give an update on this?

Sure!

Gecko API (bug 952043) is ready for gaia retrieving supportedNetworkTypes. But we still need vendor's help to add a corresponding configuration. I filed bug 980831 for this and provided my suggestion as well. Once bug 980831 is done, then gaia is able to acquire correct configuration and it could be more intelligent to set the workable default type. This is the scope I imagine this bug covers.
Flags: needinfo?(htsai)
hi Hsinyi, does this bug impact any of the v1.4 DSDS features? Thanks
Flags: needinfo?(htsai)
talked with Hsinyi, this is needed for DSDS to work on Tarako
Arthur, if bug 980831 is fixed, do we need patches to fix this bug? Thanks
blocking-b2g: --- → 1.3T+
Flags: needinfo?(htsai) → needinfo?(arthur.chen)
Currently we don't separate the setting of preferred network type for each sim. Will handle it in bug 974253. Set the dependency.
Depends on: 974253
Flags: needinfo?(arthur.chen)
Arthur, it looks like you are working on this, assign to you for now, please reassign as needed or set this bug as dup. thanks
Assignee: nobody → arthur.chen
we should config it in device/sprd, like dev-pref.js.
Arthur, are you aware of this one? Is this a dup?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(arthur.chen)
I will handle the gaia part of the issue in the patch of 974253. I did not duplicate this bug to 974253 as this will become a POVB bug after 974253 lands.
Flags: needinfo?(arthur.chen)
(In reply to Arthur Chen [:arthurcc] from comment #10)
> I will handle the gaia part of the issue in the patch of 974253. I did not
> duplicate this bug to 974253 as this will become a POVB bug after 974253
> lands.

We should make this bug [POVB] now then.

Joe, Steven, does Vendor know what to do with this bug? Who should be the assignee here?
Assignee: arthur.chen → nobody
Component: Gaia::Settings → Vendcom
Flags: needinfo?(styang)
Flags: needinfo?(jcheng)
Whiteboard: [POVB]
James/Sam, please double check whether ro.moz.ril.0.network_types ro.moz.ril.1.network_types have been set correctly or not. See in Bug 980831
Flags: needinfo?(styang)
Flags: needinfo?(sam.hua)
Flags: needinfo?(jcheng)
Flags: needinfo?(james.zhang)
Hi, i just checked the lastest build of hudson.

apusr@SamHuaubt:/home/sam/sam_work/sp6821/B2G$ adb shell getprop | grep network
[ro.moz.ril.0.network_types]: [gsm]
[ro.moz.ril.1.network_types]: [gsm]
Flags: needinfo?(sam.hua)
vi device/sprd/sp6821a_gonk/base.mk

    ro.moz.ril.0.network_types = gsm \
    ro.moz.ril.1.network_types = gsm
Flags: needinfo?(james.zhang)
James, it looks like you are working on this so assign to you for now. please close the bug as resolved fixed when its done. thanks
Assignee: nobody → james.zhang
(In reply to Joe Cheng [:jcheng] from comment #15)
> James, it looks like you are working on this so assign to you for now.
> please close the bug as resolved fixed when its done. thanks

This patch has been landed on my side.


commit a6afdd600681a7b2df5807cce08433954c26d2ad
Author: sam hua <sam.hua@spreadtrum.com>
Date:   Wed Mar 12 18:35:02 2014 +0800

    Bug #287779 add new quick for default network type
    
    [bug number  ] 287779
    [root cause  ] add new quick for default network type of 6821, gsm/gsm
    [changes     ]
    [side effects]
    [reviewers   ]
    
    Change-Id: If0a2d4774ea0463e5bd5f43686a441f4ef9e2966
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
sorry, need merge mozilla WIP patch.
0000-Bug-xxxxxx-set-default-network-type.patch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(ttsai)
Hi James, do you mean we need to land something on 1.3T branch? Thanks
Flags: needinfo?(james.zhang)
(In reply to Joe Cheng [:jcheng] from comment #19)
> Hi James, do you mean we need to land something on 1.3T branch? Thanks

0000-Bug-xxxxxx-set-default-network-type.patch
This patch is in https://github.com/Seinlin/tarako-patches.
It's just patch, I think we should land it.
Flags: needinfo?(james.zhang)
Do we need land this patch on v1.3t?
Flags: needinfo?(sku)
Assignee: james.zhang → sam.hua
No, James, 0000-Bug-xxxxxx-set-default-network-type.patch should be removed within few days.
I will monitor this issue, and update accordingly.
Thanks!!
Shawn
Flags: needinfo?(sku)
It is fixed now.
Flags: needinfo?(james.zhang)
Sam, please set the flags once a bug is fixed. Thanks!
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Hi James/Thomas:
 0000-Bug-xxxxxx-set-default-network-type.patch could be removed from WIP already.
Due to mechanism changed, there is no more default-network-type from gecko.

Thanks!!
Shawn Ku
(In reply to shawn ku [:sku] from comment #25)
> Hi James/Thomas:
>  0000-Bug-xxxxxx-set-default-network-type.patch could be removed from WIP
> already.
> Due to mechanism changed, there is no more default-network-type from gecko.
> 
> Thanks!!
> Shawn Ku

I have removed it on my side.
Flags: needinfo?(james.zhang)
Flags: needinfo?(ttsai)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: