95730 - White block displays/artifacts in the highlight area after Move/Drag mail to folder.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[wkfx2003-bugzilla]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.3+)
Gecko/20010815
BuildID:    2001081504

See the attachment. The folder name is covered up by white area

Reproducible: Always
Steps to Reproduce:
Drag email to another folder

Comment 1

[wkfx2003-bugzilla]

Attachment: Note the area circled.

Comment 2

[Karen Huang]

The folder name did display completely, but just a little white block displays 
in the highlight area after Move/Drag mail to folder.
Updating the summary & confirming the bug to NEW.

Comment 3

[Jan Varga [:janv]]

There are some painting bugs in outliner dnd. Pinkerton knows more about it.

Comment 4

[sairuh (rarely reading bugmail)]

not sure if this is the same bug [i suspect it is], but after completing the
d'n'd [ie, after releasing the mouse button], the white block reverses into a
black block.

i think this is a regression --don't recall seeing this before the folder
outliner landed. unless it's been there all along and the folder pane is just a
good place to see it now. pink/blake, any ideas?

Comment 5

[Henry Throop]

Attachment: Anohter screenshot

Comment 6

[Henry Throop]

Attachment: Another screenshot, slightly different

Comment 7

[Henry Throop]

This screenshot displays what looks to be the same problem, although it's more
than just the 'white block' displaying after a drag & drop.  Dragging a mail
message consistently leaves behind 'artifacts' on the mail folders passed over.

Comment 8

[sairuh (rarely reading bugmail)]

yeah, still seeing this. it's an eyesore, and makes drag'n'drop in mail rather
difficult to use (for me at least :-/).

tentatively nominating for moz0.9.5. who'd be the proper owner for this?

Comment 9

[Jan Varga [:janv]]

see my 2001-08-19 07:12 comment above

Comment 10

[Sheela Ravindran]

reassign->navin

Comment 11

[Pádraig Brady]

Just a me too. Happens all the time on 0.9.{4,5,6} on linux also.
Please fix it as it's horrible. It looks like the mouse pointer icon
as it moves over the the area for the block highlight, corrupts it.

Comment 12

[Jan Varga [:janv]]

taking

Comment 13

[Jan Varga [:janv]]

Attachment: proposed fix

This patch cleans outliner drag and drop a little bit.
Drop feedback is now skinable also.

Comment 14

[Jan Varga [:janv]]

note, mailnews change is not intended to go in, it's just for testing
pink,hyatt can you r/sr ?

Comment 15

[Jan Varga [:janv]]

Attachment: better patch

Comment 16

[Jan Varga [:janv]]

Attachment: real patch

Comment 17

[Mike Pinkerton (not reading bugmail)]

recall that all drawing during a drag on mac must be synchronous. with your
change to use InvalidateRow for drawing, you just made it ansynchronous and thus
will break mac.

a quick fix might be to draw syncronously in InvalidateRow if a drag session is
present (you'll have to ask the drag service) on mac only.

this patch needs work.

Comment 18

[Jan Varga [:janv]]

ah, I was not aware of mac issues. I can try to fix that but I can't test it
I don't have mac :(

Comment 19

[Jan Varga [:janv]]

Attachment: revised patch

I tested synchronous drawing/painting on Linux, it just worked.
And yes it was slower, but this should be less slower because
widget->Update() should update only dirty rect.

Comment 20

[Sheela Ravindran]

reporter,
Do you still see this problem on recent builds? Can you comment in the bug.

Comment 21

[Henry Throop]

Bug looks to still be there in Linux build 2001121408.  I get the same behavior
as in the screenshots posted for this bug.

Comment 22

[Sheela Ravindran]

*** Bug 102507 has been marked as a duplicate of this bug. ***

Comment 23

[Vadim Berezniker]

Still visible on Windows build 2001121303

Comment 24

[Pádraig Brady]

Still visible on Linux build 2001121906

Comment 25

[August Mayer]

Actually, this looks like the inversion is interfering with the mouse pointer:
save background -> draw mouse drag pointer -> invert selection rectangle ->
undraw mouse pointer -> reinvert selection rectangle, but as the mouse pointer
background was restored, a part of the area is really inverted.

So either (1) hide the mouse pointer before drawing, or (2) draw to the mouse
pointer background buffer too.

just my 2 cents

Comment 26

[R.K.Aa.]

*** Bug 117838 has been marked as a duplicate of this bug. ***

Comment 27

[Jan Varga [:janv]]

There are some other painting issues while dragging item apart the mouse pointer
problem.
Try to drag a message header from thread pane and wait for a sec above some
container in folder pane and you'll see.
Drop feedback is now painted offline not in painting methods and I think this is
a main cause of problems.
I just need to test this patch on a Mac.
Any valunteers ?

Comment 28

[Zach Lipton [:zach]]

I would be happy to test the patch on mac (CFM). I heard that the patch 
was out of date, can you update it?

Thanks,

Zach

Comment 29

[Jan Varga [:janv]]

Up to date patch is included in attachment
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=64742
of bug 95730

You can try it until I extract it.

Comment 30

[Jan Varga [:janv]]

fixed along with bug 116855 

Comment 31

[Sheela Ravindran]

Verified using builds: 2002-02-04-06 win98
2002-02-04-06 mac os x, linux.
I did not see any white block displays while moving messages or dragging folders 
in the folder pane.

Comment 32

[R.K.Aa.]

*** Bug 100431 has been marked as a duplicate of this bug. ***

Comment 33

[Henry Throop]

This bug (or a very similar one) has returned in 2002031008.  It's slightly
different, in that now the message count gets the artifact, where it used to be
the folder name.  I notice that the message count is now right-justified (rather
than left), if this has anything to do with it.  See attachment.

This was definitely fixed in 2002020415.

Comment 34

[Henry Throop]

Attachment: See artifacts in message count column

Comment 35

[Jan Varga [:janv]]

Henry, if you provide steps to reproduce it then someone might take a look.

Comment 36

[Henry Throop]

The steps to reproduce are exactly the same as they were before:

1. Drag an e-mail message into a folder
2. Artifacts will be left behind when mouse is dragged over text in 'Folders'
window pane.

This bug occurs on my RH7.1 system, but not RH7.2.

Comment 37

[Jan Varga [:janv]]

Ah, I see, I'll fix it.

Comment 38

[Jan Varga [:janv]]

reopening

Comment 39

[Jan Varga [:janv]]

argh

Comment 40

[Jan Varga [:janv]]

Attachment: polish fix

Comment 41

[Joe Hewitt (gone)]

Comment on attachment 76213 [details] [diff] [review]
polish fix

sr=moi

Comment 42

[Brian Ryner (not reading)]

Comment on attachment 76213 [details] [diff] [review]
polish fix

r=bryner

Comment 43

[Asa Dotzler [:asa]]

Comment on attachment 76213 [details] [diff] [review]
polish fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 44

[Jan Varga [:janv]]

Joe landed for me.
Fixed.

Comment 45

[Sheela Ravindran]

Fixed before branch
Hence verified 05-20-08 branch build on win98, linux RH 6.2, Mac os x.
No more artifacts in message count column when drag n drop single or multiple 
messages.