957790 - B2G: Settings app can be zoomed-in during startup

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Gregor Wagner [:gwagner]]

STR:
Launch settings app
During startup, zoom-in with 2 fingers
Once the UI shows up, it will be zoomed in.
Maybe 30% reproducible.

Seen on gecko and gaia trunk with a debug gecko build on nexus 4.

Comment 1

[Jason Smith [:jsmith]]

My guess is this was reproduced with APZC turned on.

Comment 2

[Gregor Wagner [:gwagner]]

(In reply to Jason Smith [:jsmith] from comment #1)
> My guess is this was reproduced with APZC turned on.

Hm I thought it's enabled by default? I didn't do anything special.

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: 2014-01-08-16-41-54.png

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> Hm I thought it's enabled by default? I didn't do anything special.

It's enabled by default on developer builds. As of earlier tonight (bug 909877) it's also enabled by default on all builds.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Remove pref added for metrofx but no longer needed

This was added in bug 915385, and was only ever enabled in bug 915771 for Firefox 26. We should be able to take it out now.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Initialize the zoom constraints to disable zooming

The problem here is that we allow zooming before we get the first UpdateZoomConstraints call which disables it. It's better to initialize the zooming state to disabled, and then enable it once we get the UpdateZoomConstraints call. We should always get an UpdateZoomConstraints call either on creation or once we set the viewport in TabChild.

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8357795 [details] [diff] [review]
Part 2 - Initialize the zoom constraints to disable zooming

Review of attachment 8357795 [details] [diff] [review]:
-----------------------------------------------------------------

Has this been tested on Metro? As far as I can tell, the only place Metro calls UpdateZoomConstraints is here [1], and it passes false there.

[1] https://mxr.mozilla.org/mozilla-central/source/widget/windows/winrt/MetroWidget.cpp#1618

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8357795 [details] [diff] [review]
Part 2 - Initialize the zoom constraints to disable zooming

Oh, that's a good point. I didn't test on Metro but it would probably break that.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Initialize the zoom constraints to disable zooming (v2)

Updated to ensure zooming is enabled by Metro.

Comment 10

[Jim Mathies [:jimm]]

Comment on attachment 8357910 [details] [diff] [review]
Part 2 - Initialize the zoom constraints to disable zooming (v2)

zoom is working as expected, the start page is non-zoomable, while content is.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a67882c52c98
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f0811650f2f7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out for gtest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/92d1972990e4

https://tbpl.mozilla.org/php/getParsedLog.php?id=32923281&tree=Mozilla-Inbound

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Relanded with a fixes for the gtest failures:

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8cb07bfc1390
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f7aeb3d7992b

Just a couple of lines in TestAsyncPanZoomController that enable zooming in the Pinch and Overzoom tests.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8cb07bfc1390
https://hg.mozilla.org/mozilla-central/rev/f7aeb3d7992b

Comment 15

[Milan Sreckovic [:milan] (needinfo for best results)]

Needs to be uplifted.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

This depends on bug 915985. Please post a branch-specific patch for uplift or get approval for that to land as well.

Comment 18

[Kartikaya Gupta (email:[e-mail])]

I've requested 1.3 approval for bug 915985 as well.

Comment 19

[Kartikaya Gupta (email:[e-mail])]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/7223b5a7a171
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/b70ae46026f3