957818 - B2G UA override list doesn't seem to be updating

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

The UA override list was set up in bug 912215 at https://dynamicua.cdn.mozilla.net/0/%7B3c2e2abc-06d4-11e1-ac3b-374f68613e61%7D and tracks the file at https://hg.mozilla.org/mozilla-central/raw-file/tip/b2g/app/ua-update.json.in

But I see it's out-of-date and doesn't seem to be updating.

Comment 1

[Chris Turra [:cturra]]

i just checked and the update script found below is running on a cron once a day. 

  https://github.com/mozilla/dynamicua_update_script/blob/master/update


i just manually executed this update script and everything *appears* be up to date. here is the debug output from that run:

[[e-mail]1 ~]# bash -x /data/genericrhel6/src/dynamicua.cdn.mozilla.net/update
+ CODE_DIR=/data/genericrhel6/src/dynamicua.cdn.mozilla.net/dynamicua
+ FILE_URL=https://hg.mozilla.org/mozilla-central/raw-file/tip/b2g/app/ua-update.json.in
+ FILE_REVISION_NAME=file_revision.txt
++ curl -s https://hg.mozilla.org/mozilla-central/file/febfe3c7732b/b2g/app/ua-update.json.in
++ awk -F '[">]' '{print $9}'
++ awk -F '[</a]' '{print $1}'
++ grep -A1 '<td>changeset'
++ grep -v '^$'
+ FILE_LATEST_REVISION=febfe3c7732b
+ B2G_APP_ID='{3c2e2abc-06d4-11e1-ac3b-374f68613e61}'
+ FILENAME='{3c2e2abc-06d4-11e1-ac3b-374f68613e61}'
++ cat /data/genericrhel6/src/dynamicua.cdn.mozilla.net/version.txt
+ VERSION=0
+ VERSION_DIR=/data/genericrhel6/src/dynamicua.cdn.mozilla.net/dynamicua/0
+ '[' '!' -d /data/genericrhel6/src/dynamicua.cdn.mozilla.net/dynamicua/0 ']'
+ '[' '!' -d /data/genericrhel6/src/dynamicua.cdn.mozilla.net/dynamicua/file_revision.txt ']'
+ curl -s https://hg.mozilla.org/mozilla-central/file/febfe3c7732b/b2g/app/ua-update.json.in
+ awk -F '[">]' '{print $9}'
+ awk -F '[</a]' '{print $1}'
+ grep -A1 '<td>changeset'
+ grep -v '^$'
++ cat /data/genericrhel6/src/dynamicua.cdn.mozilla.net/dynamicua/file_revision.txt
+ FILE_DEPLOYED_REVISION=febfe3c7732b
+ '[' febfe3c7732b == febfe3c7732b ']'
+ exit 0



... from the most recent cron logs:

[[e-mail]1 quality]# grep "dynamicua" /var/log/cron
Jan  6 00:00:01 genericadm CROND[27461]: (root) CMD (/usr/bin/flock -w 10 /var/lock/dynamicua /data/genericrhel6/src/dynamicua.cdn.mozilla.net/update)
Jan  7 00:00:01 genericadm CROND[18602]: (root) CMD (/usr/bin/flock -w 10 /var/lock/dynamicua /data/genericrhel6/src/dynamicua.cdn.mozilla.net/update)
Jan  8 00:00:01 genericadm CROND[8616]: (root) CMD (/usr/bin/flock -w 10 /var/lock/dynamicua /data/genericrhel6/src/dynamicua.cdn.mozilla.net/update)

Comment 2

[Brandon Burton [:solarce]]

Turned out to be a bug in the script that I missed, the Hg revision was hardcoded in the URLs that the script uses to check if there is a new revision in Hg and it should have been set to tip

This commit fixes that, https://github.com/mozilla/dynamicua_update_script/commit/98338ea648bd6752e5fade287c9ef7af64ec9e67

I've pushed the updated script and ran it. 

The new file has been deployed and is being served through Akamai.

Sorry for not noticing that sooner, please let us know if you see anything else amiss

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

No problem. Thanks for the quick response! :)