958423 - B2G NFC: ndef in 'nfc-manager-tech-discovered' is two levels of array.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In the system message, nfc-manager-tech-discovered, it contains a ndef property,however it's in two levels of array:

[[{...}, {...}]

The outter one is the array of NdefMessages, the inner one is the array of NdefRecords.
Given that only one NdefMessage is needed, for simplicity we could use only 1 level of array here.

Also Gaia won't have to always pick the first NdefMessage in https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/nfc_manager.js#L375

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Also the NdefMessage in nfc-manager-tech-discovered system message is called 'ndef', however in the ReadNdefResponse it's caleld 'records'.

The naming should be consistent here.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug958423.patch

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Gaia PullRequest

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2.

rebase for Bug 950269 is landed.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9a7f73b33c73

add checkin-needed for the Gaia Pull Request.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Looks like the Pull Request has conflicts. Please rebase and re-request checkin :)

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9a7f73b33c73

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Thanks, I have re-pushed again to fix the conflict.
Adding checkin-needed back to the Gaia patch.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/1472c1bfa410cc757d5c29757f267dfcc1af7c8e

Comment 10

[Garner Lee]

Patch 2 seems to P2P break presence detect, which has no ndefMessage to unmarshall:

I/Gecko   (  179): Nfc Worker: Handling parcel as NFC_NOTIFICATION_TECH_DISCOVERED
I/Gecko   (  179): Nfc Worker: NFC_NOTIFICATION_TECH_DISCOVERED
I/Gecko   (  179): Nfc Worker: Parcel handling threw Error: Trying to read data beyond the parcel end!

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Garner filed Bug 960790 for this.