960790 - [B2G][NFC] Fix P2P presence discovery handling.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Garner Lee]

Attachment: tempFix.patch

The change to single level records broke P2P message parsing:
https://bugzilla.mozilla.org/show_bug.cgi?id=958423#c10

Specifically, P2P discovery does not have an NDEF Message to parse.

Attached is a small temporary patch to get things going, since I believe there was some discusson weeks ago about whether to send all NDEF messages, or just the first one, where available.

Comment 1

[Garner Lee]

Arno, Yoshi, comments? Otherwise, it's a small change (P2P ShrinkUI works again with the temporary fix.).

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8361359 [details] [diff] [review]
tempFix.patch

Review of attachment 8361359 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/nfc_worker.js
@@ +368,4 @@
>  NfcWorker[NFC_NOTIFICATION_TECH_DISCOVERED] = function NFC_NOTIFICATION_TECH_DISCOVERED() {
>    debug("NFC_NOTIFICATION_TECH_DISCOVERED");
>    let techList  = [];
> +  let records   = [];

I think we could just leave it undefined here so we don't have to create an extra array where there's NdefRecords in the parcel.
(unMarshallNdefMessage will also return a [], which make the [] here not neccesary)
Also if the records is an array by default, the check in 
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/nfc_manager.js#L378

if (records != null) is not neccesary.




But in that case we also need to update nfc_manager, since if it's undefined, records.length will throw TypeError.

Comment 3

[Garner Lee]

Attachment: Bug 960790: Fix P2P presence discovery handling (gecko) r=allstars.chh

Modify patch to use review comment for tempFix.patch.

Comment 4

[Garner Lee]

Attachment: Bug 960790: Fix P2P presence discovery handling (gaia)

Comment 5

[Garner Lee]

Code dependency: The gaia side should land before the gecko part.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 960790: Fix P2P presence discovery handling (gecko).

Help Garner to add r=me.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/gaia/commit/1bf0beb7b3761c7fae89e92dd45a8cbd88c5f249

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/gaia/commit/1bf0beb7b3761c7fae89e92dd45a8cbd88c5f249

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5a73fc7cf9e