95857 - process_bug.cgi sees blank address in cc: list (__UNKNOWN__)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

process_bug.cgi appears to be parsing the cc: list such that it thinks the user
submitting changes has entered a user with a blank email address into cc: field.
 Apparently this is triggered if the user enters two commas in a row into the
cc: list field, although some users claim that it happened when they didn't do that.

Bug 95798 exacerbates this problem, as does the presence of a user on b.m.o.
with a blank login name (email address).

The following bugs are currently affected:

bug 87976
bug 82305
bug 21344
bug 92839
bug 95457
bug 95822
bug 72781
bug 95849

Comment 1

[Myk Melez [:myk] [@mykmelez]]

I don't want to disable the user's account (#12852) and give them a fake email
address or integrate a fix for bug 95798 until we figure out what is causing this.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

simplifying summary and adding __UNKNOWN__ to it so people find it more easily

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The problem is in code that was fixed by Jake's patch to bug 95747.

This is the old code:

            my @new = split(/[ ,]/, $cc_add);
            foreach my $person (@new) {

This is the new code:

        foreach my $person (split(/[ ,]/, $cc_remove)) {
            # Ignore blanks
            next unless $person;

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: makes the code more compact and robust

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Although the bug has been fixed by a previous patch, the patch I just attached
is a more compact and robust solution to the problem.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: handles leading delimiters

Comment 7

[Dave Miller [:justdave]]

r= justdave
committed

Comment 8

[Jacob Steenhagen]

After talking in irc, we came up with a slightly better solution.
REOPENing

Comment 9

[Jacob Steenhagen]

Attachment: patch v3: convert all delimeters to a single space before splitting.

Comment 10

[Jacob Steenhagen]

Attachment: patch v4: use the syntax that allows perl to do proper trimming

Comment 11

[Jacob Steenhagen]

Attachment: patch v5: The Bugs Strike Back

Comment 12

[Myk Melez [:myk] [@mykmelez]]

works. r=myk

Comment 13

[Jacob Steenhagen]

It's in.
(I'm just glad we didn't need a Return of the Bugfixer :)

Comment 14

[Dave Miller [:justdave]]

Moving to Bugzilla product