961479 - Cached thumbnails of pending tabs are discarded when opening Panorama

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Alice0775 White]

Regression window(fx)
Good:
http://hg.mozilla.org/integration/fx-team/rev/db5091d58b58
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140116095802
Bad:
http://hg.mozilla.org/integration/fx-team/rev/5d45e6b035a3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140116114608
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=db5091d58b58&tochange=5d45e6b035a3


Bug 961016 does not fix this problem.

Comment 1

[Alice0775 White]

Attachment: screenshot

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-961479-Mark-pending-tabs-as-incomplete-to-not-ov.patch

Due to the slight delay in blocking about:blank's load since we use messages we need to check whether tabs are pending before discarding cached thumbnails.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8362623 [details] [diff] [review]
0001-Bug-961479-Mark-pending-tabs-as-incomplete-to-not-ov.patch

Review of attachment 8362623 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/tabview/tabitems.js
@@ +847,5 @@
>      Utils.assertThrow(tab, "tab");
>  
> +    // A pending tab can't be complete, yet.
> +    if (tab.hasAttribute("pending")) {
> +      setTimeout(callback);

This will call the callback with an `undefined` value for whether the tab is loaded or not. Can you set the argument to `false` so it is more explicit?

How hard would it be to add a test for this?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-961479-Mark-pending-tabs-as-incomplete-to-not-ov.patch, v2

Added a test and addressed your comment.

https://tbpl.mozilla.org/?tree=Try&rev=547c89d8603d

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/54c2f1da0771

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54c2f1da0771

Comment 8

[Benjamin Kerensa [:bkerensa]]

Since this is a regression and in order to keep an eye on this going to track.