961980 - [Sora][Clock][Setting] Have no sound when set volume in the setting.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

FireFox OS 1.3
 Mozilla build ID: 20140105004001
 
 DEFECT DESCRIPTION:
  Have no sound when adjust volume in the setting.
 
  REPRODUCING PROCEDURES:
  1. Enter "setting"->"sound";
  2. Set "Alarm" volume.
 
  EXPECTED BEHAVIOUR:
  Have sound when adjust volume.
 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Not sure this one belongs to Setting or Alarm...or maybe it is per design? Dear Alive, mind kindly taking a look at this and helps me out?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

This sounds a feature request: 'Sound when setting volume with volume slider in settings' so this falls under settings app.

Comment 3

[Preeti Raghunath(:Preeti)]

Moving to backlog as it is pretty late for 1.3.

Comment 4

[Peter Dolanjski [:pdol]]

Bruce, can you take a look at adding this to the backlog?  It makes sense to preview the sound volume for the user so they know which setting they should stop at.

Comment 5

[Ray REN]

Hi Vance,

When did you add this feature?

Comment 6

[Bruce Huang [:bhuang] (inactive)]

Backlogging.  Same request as bug 899487.

Comment 7

[Omega Feng [:Omega] [:馮於懋]]

See Bug 991026 for the Sound UX spec update.

Comment 9

[Stephany Wilkes]

Assigning this to Ying Li, who is going to implement this as a contributor as part of the Open Academy project.

Comment 10

[Dominic Kuo [:dkuo]]

Stephany and Ying,

System platform team is going to implement all the bugs in bug 991026 in 2.0, and this bug is one of them, do you want me to mentor this bug or you can take the other bugs instead? please let me know, thanks.

Comment 11

[Dominic Kuo [:dkuo]]

Stephany and Ying,

Since 2.0 sprint 2 is started, I am going to implement this first so taking this, please let me know if you are still interested in this bug, thanks.

Comment 12

[Dominic Kuo [:dkuo]]

Attachment: patch - preview the tones in the sound region when adjusting the sliders

Comment 13

[Omega Feng [:Omega] [:馮於懋]]

Please see Bug 991026 for the latest UX spec.

Comment 14

[Dominic Kuo [:dkuo]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Arthur,

This patch has enabled the previews for the volume sliders in the sound region, I planned to add some integration tests but found currently we don't support "sound" tests in marionette js, and the existing integration tests should be able to cover this(also my patch didn't break it). And for unit tests, since the sound panel will be testable after bug 973445 landed, at that time it will be easier and make more sense to add the unit tests, I will file one bug to trace the it after we landed this. would you please review the patch? thanks.

Yuren,

This patch also modified the build script so will need some review on it, do yo mind to take a look on the build script part? thanks.

Omega,

I have followed the spec in bug 991026 to implement the preview feature, would you please also do the ui-review? thanks.(I will probably show this to you offline or record a video since it's about the sound behaviours)

Comment 15

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

looks fine for build script part.

Comment 16

[Dominic Kuo [:dkuo]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

After I discussed with Omega offline, we decided to tweak a little more about the slider's behaviour, so cancelling the review request first and will request again after I finished the tweak. It won't change the build script part.

Comment 17

[Dominic Kuo [:dkuo]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Okay, I think I have finished the tweak and addressed all the requirements that ux want, Arthur, would you please review this? thanks.

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Thanks for the patch. Per our discussion, please refine the value setting logic to see if we can avoid the queueing problem.

Comment 19

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

ni? new UX owner Jenny.

Comment 20

[Dominic Kuo [:dkuo]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Arthur,

I have addressed the queueing problem and also tweaked more on the slider's ux with Omega, would you please review it again? thanks.

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

There are two minor points to be addressed before merging. Please check my comments in github, thanks!

Comment 22

[Dominic Kuo [:dkuo]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Hi Arthur,

I have addressed the minor issue(the other one is not as we discussed offline), would you mind to take the last look? thanks.

Comment 23

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Good work! r=me, thanks!

Comment 24

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Good job!

Comment 25

[Jenny Lee]

Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

I think it's great ;)

Comment 26

[Dominic Kuo [:dkuo]]

Thanks everyone!

Landed on master: ec0e8bf4acd7aa18923811691ae01b4828da66d7