[Sora][Clock][Setting] Have no sound when set volume in the setting.

RESOLVED FIXED in 2.0 S3 (6june)

Status

defect
P1
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sync-1, Assigned: dkuo)

Tracking

({feature})

unspecified
2.0 S3 (6june)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 fixed)

Details

(Whiteboard: [p=5])

Attachments

(1 attachment)

FireFox OS 1.3
 Mozilla build ID: 20140105004001
 
 DEFECT DESCRIPTION:
  Have no sound when adjust volume in the setting.
 
  REPRODUCING PROCEDURES:
  1. Enter "setting"->"sound";
  2. Set "Alarm" volume.
 
  EXPECTED BEHAVIOUR:
  Have sound when adjust volume.
 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:
Not sure this one belongs to Setting or Alarm...or maybe it is per design? Dear Alive, mind kindly taking a look at this and helps me out?
Flags: needinfo?(alive)
This sounds a feature request: 'Sound when setting volume with volume slider in settings' so this falls under settings app.
Flags: needinfo?(alive)
Keywords: feature
blocking-b2g: --- → 1.3?
Moving to backlog as it is pretty late for 1.3.
blocking-b2g: 1.3? → backlog
Flags: needinfo?(ffos-product)
Bruce, can you take a look at adding this to the backlog?  It makes sense to preview the sound volume for the user so they know which setting they should stop at.
Flags: needinfo?(ffos-product) → needinfo?(bhuang)
Hi Vance,

When did you add this feature?
Flags: needinfo?(vchen)
Backlogging.  Same request as bug 899487.
Blocks: 908549
Flags: needinfo?(bhuang)
Flags: needinfo?(ofeng)
See Bug 991026 for the Sound UX spec update.
Flags: needinfo?(ofeng)
Duplicate of this bug: 808237
Assigning this to Ying Li, who is going to implement this as a contributor as part of the Open Academy project.
Assignee: nobody → liying2905
Stephany and Ying,

System platform team is going to implement all the bugs in bug 991026 in 2.0, and this bug is one of them, do you want me to mentor this bug or you can take the other bugs instead? please let me know, thanks.
Flags: needinfo?(swilkes)
Flags: needinfo?(liying2905)
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
Whiteboard: [p=5]
Target Milestone: --- → 2.0 S2 (23may)
Stephany and Ying,

Since 2.0 sprint 2 is started, I am going to implement this first so taking this, please let me know if you are still interested in this bug, thanks.
Assignee: liying2905 → dkuo
Flags: needinfo?(swilkes)
Flags: needinfo?(liying2905)
Depends on: 1007058
Please see Bug 991026 for the latest UX spec.
feature-b2g: --- → 2.0
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Arthur,

This patch has enabled the previews for the volume sliders in the sound region, I planned to add some integration tests but found currently we don't support "sound" tests in marionette js, and the existing integration tests should be able to cover this(also my patch didn't break it). And for unit tests, since the sound panel will be testable after bug 973445 landed, at that time it will be easier and make more sense to add the unit tests, I will file one bug to trace the it after we landed this. would you please review the patch? thanks.

Yuren,

This patch also modified the build script so will need some review on it, do yo mind to take a look on the build script part? thanks.

Omega,

I have followed the spec in bug 991026 to implement the preview feature, would you please also do the ui-review? thanks.(I will probably show this to you offline or record a video since it's about the sound behaviours)
Attachment #8420005 - Attachment description: wip → patch - preview the tones in the sound region when adjusting the sliders
Attachment #8420005 - Flags: ui-review?(ofeng)
Attachment #8420005 - Flags: review?(yurenju.mozilla)
Attachment #8420005 - Flags: review?(arthur.chen)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

looks fine for build script part.
Attachment #8420005 - Flags: review?(yurenju.mozilla) → review+
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

After I discussed with Omega offline, we decided to tweak a little more about the slider's behaviour, so cancelling the review request first and will request again after I finished the tweak. It won't change the build script part.
Attachment #8420005 - Flags: review?(arthur.chen)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Okay, I think I have finished the tweak and addressed all the requirements that ux want, Arthur, would you please review this? thanks.
Attachment #8420005 - Flags: review?(arthur.chen)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Thanks for the patch. Per our discussion, please refine the value setting logic to see if we can avoid the queueing problem.
Attachment #8420005 - Flags: review?(arthur.chen)
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

ni? new UX owner Jenny.
Attachment #8420005 - Flags: ui-review?(jelee)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Arthur,

I have addressed the queueing problem and also tweaked more on the slider's ux with Omega, would you please review it again? thanks.
Attachment #8420005 - Flags: review?(arthur.chen)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

There are two minor points to be addressed before merging. Please check my comments in github, thanks!
Attachment #8420005 - Flags: review?(arthur.chen)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Hi Arthur,

I have addressed the minor issue(the other one is not as we discussed offline), would you mind to take the last look? thanks.
Attachment #8420005 - Flags: review?(arthur.chen)
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Good work! r=me, thanks!
Attachment #8420005 - Flags: review?(arthur.chen) → review+
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

Good job!
Attachment #8420005 - Flags: ui-review?(ofeng) → ui-review+
Comment on attachment 8420005 [details] [review]
patch - preview the tones in the sound region when adjusting the sliders

I think it's great ;)
Attachment #8420005 - Flags: ui-review?(jelee) → ui-review+
Thanks everyone!

Landed on master: ec0e8bf4acd7aa18923811691ae01b4828da66d7
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(vchen)
Resolution: --- → FIXED
Duplicate of this bug: 899487
Duplicate of this bug: 1016155
Duplicate of this bug: 937516
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.