Closed Bug 967342 Opened 7 years ago Closed 7 years ago
Server not found pages have '&f=regular' appended to url
eg: Server not found Firefox can't find the server at asfdasfasdfdsafdasf.dasf.aesraewrfdsz.com.&f=regular Broken in Nightly 20140203030203/m-c 44ba69cacd7e, probabaly fair recently.
Must have been caused by bug 959800.
Component: General → Document Navigation
Product: Firefox → Core
Er, yes. I guess we should put this new thing before the other ones...
The code responsible for putting that text in the error page is getDescription: http://hg.mozilla.org/mozilla-central/annotate/c150845d077d/docshell/resources/content/netError.xhtml#l63 It seems to assume that the "d=" parameter is last?
Seems like the "manifestURL" stuff just before this newly added code would also mess that up, though presumably that doesn't impact desktop Firefox.
Yep that's our fault. We could either make the change in bug 959800 B2G only, move f= before d= or maybe teach getDescription to only take the d= part. Seems like moving f= before d= is sufficient based on the comments. Does the error page for android go through the same code or do we have to check more error pages?
Putting needinfo on myself to check to see if this reproduces on FxOS. I've confirmed this on FxDesktop as well.
Assignee: nobody → anygregor
Don't think we need a gaia change here. Mike?
Comment on attachment 8369878 [details] [diff] [review] patch The comment in the patch is somewhat misleading. I'd be more explicit: // netError.xhtml's getDescription only handles the "d" parameter at the end of the URL, so append it last
Attachment #8369878 - Flags: feedback+
(In reply to Jason Smith [:jsmith] from comment #7) > Putting needinfo on myself to check to see if this reproduces on FxOS. I've > confirmed this on FxDesktop as well. Confirmed this doesn't reproduce on the latest 1.4 build on FxOS.
Attachment #8369878 - Attachment is obsolete: true
Attachment #8369895 - Flags: review?(bzbarsky)
Gaia doesn't rely on the order of parameters to get the description. We should be good. Thanks for fixing this!
Comment on attachment 8369895 [details] [diff] [review] patch r=me
Attachment #8369895 - Flags: review?(bzbarsky) → review+
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
Target Milestone: 1.3 C3/1.4 S3(31jan) → 1.4 S1 (14feb)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
can this be uplifted to aurora & beta?
Needs approvals (and presumably approval requests), no?
Comment on attachment 8369895 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 959800 User impact if declined: Showing "&f=regular" at the end of the hostname on the "host not found" error page. Testing completed (on m-c, etc.): Fine on m-c. Risk to taking this patch (and alternatives if risky): Low risk. String or IDL/UUID changes made by this patch: None.
You need to log in before you can comment on or make changes to this bug.