967342 - Server not found pages have '&f=regular' appended to url

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg: Server not found

Firefox can't find the server at asfdasfasdfdsafdasf.dasf.aesraewrfdsz.com.&f=regular

Broken in Nightly 20140203030203/m-c 44ba69cacd7e, probabaly fair recently.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Must have been caused by bug 959800.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er, yes.  I guess we should put this new thing before the other ones...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The code responsible for putting that text in the error page is getDescription:

http://hg.mozilla.org/mozilla-central/annotate/c150845d077d/docshell/resources/content/netError.xhtml#l63

It seems to assume that the "d=" parameter is last?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Seems like the "manifestURL" stuff just before this newly added code would also mess that up, though presumably that doesn't impact desktop Firefox.

Comment 5

[Gregor Wagner [:gwagner]]

Yep that's our fault.
We could either make the change in bug 959800 B2G only, move f= before d= or maybe teach getDescription to only take the d= part.
Seems like moving f= before d= is sufficient based on the comments. Does the error page for android go through the same code or do we have to check more error pages?

Comment 6

[Jason Smith [:jsmith]]

Attachment: testcase.html

Comment 7

[Jason Smith [:jsmith]]

Putting needinfo on myself to check to see if this reproduces on FxOS. I've confirmed this on FxDesktop as well.

Comment 8

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 9

[Gregor Wagner [:gwagner]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=b4655f7e508c

Comment 10

[Gregor Wagner [:gwagner]]

Don't think we need a gaia change here. Mike?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8369878 [details] [diff] [review]
patch

The comment in the patch is somewhat misleading. I'd be more explicit:

// netError.xhtml's getDescription only handles the "d" parameter at the end of the URL, so append it last

Comment 12

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #7)
> Putting needinfo on myself to check to see if this reproduces on FxOS. I've
> confirmed this on FxDesktop as well.

Confirmed this doesn't reproduce on the latest 1.4 build on FxOS.

Comment 13

[Gregor Wagner [:gwagner]]

Attachment: patch

Thanks Gavin

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Gaia doesn't rely on the order of parameters to get the description. We should be good. Thanks for fixing this!

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8369895 [details] [diff] [review]
patch

r=me

Comment 16

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7f5b2aab179b

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f5b2aab179b

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/1e5bdced99c2

Comment 25

[[:philipp]]

can this be uplifted to aurora & beta?

Comment 26

[Boris Zbarsky [:bzbarsky]]

Needs approvals (and presumably approval requests), no?

Comment 28

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8369895 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 959800
User impact if declined: Showing "&f=regular" at the end of the hostname on the "host not found" error page.
Testing completed (on m-c, etc.): Fine on m-c.
Risk to taking this patch (and alternatives if risky): Low risk.
String or IDL/UUID changes made by this patch: None.

Comment 29

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55e2d0038af7
https://hg.mozilla.org/releases/mozilla-beta/rev/c61c6b9d0cb9

Comment 30

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/c61c6b9d0cb9