968427 - Updating Firefox will change the icons for homescreen bookmarks and webapps

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P5)

Description

[[e-mail]]

Attachment: galaxyS3_screenshot.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140127194636

Steps to reproduce:

On my Galaxy S3, I've installed firefox. I've see that within Firefox you can acces the marketplace. So I decided to give a try to some applications.

Firefox update from 26 to 27  …


Actual results:

After the udpate of firefox on my mobile device, all the applications lost their icon (W for wikipedia, blue bird for twitter…) and get replaced by the firefox icon.


Expected results:

Expect that the icon did not change.

I've also try to launch the application, to see if they still works ? They do.

I was hoping that the icon will be refreshed after the launch of the application. But I had no luke.

Comment 1

[Ioana Chiorean]

I am able to reproduce this with latest Aurora build and Nightly too. 

Build. 30.0a1 and 29.0a2 (02/06)
Device: HTC Sensation 4G and Galaxy Tab 2 (Android 4.0.4 and 4.1 )

Steps to reproduce:
1. Have yesterdays build (02/05) on the device
2. Add some bookmarks to the homescreen (for these versions t5hw webapps are synthetic APKs so add to homescreen won't work from fennec)
3. Download today's build (02/06) and install it (an update install will take place)
4. Take a look at the screen shortcuts for the bookmarks . 

Nite:
This is not reproducible on gingerbread devices so I would say it is for Android 4+ only

Comment 2

[:Margaret Leibovic]

wesj, do you know what's up with this?

Comment 3

[Wesley Johnston (:wesj)]

No idea why this would happen.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

If this is a dupe of the one you suggested WON'T FIXing, please won't fix this.

Comment 5

[Richard Newman [:rnewman]]

Please reopen if this occurs when upgrading from 27 to 28.

Comment 8

[Richard Newman [:rnewman]]

http://stackoverflow.com/questions/24519299/android-app-development-user-created-shortcuts-with-user-defined-names-and-ico

http://stackoverflow.com/questions/22008484/install-shortcut-then-enablecomponent-makes-shortcut-change-on-android-4-2-2

Might be worth reading some Android source, see if we can figure out why this happens.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 11

[Aaron Train [:aaronmt]]

Seems to happen on an S3 and an S5 according to the above dupe.

Comment 12

[dror3go]

I understand this is not a crucial bug, but I personally moved from installing applications to make homepage shortcuts of websites. I prefer this for various reasons (battery consumption, privacy, wanting to use a browser, etc.), and this bug is really annoying for my usage: each time I get an update to the browser, I need to re-create all of my websites shortcuts.

Comment 14

[Dave Miller [:justdave]]

Per the most-recent dupe, this affects Galaxy S4 as well.  General Samsung issue?

FWIW, I have a similar problem with the OpenVPN client... my home screen shortcuts for my two VPNs that I use lose their *name* in OpenVPN's case, every time it updates, going back to the default "Connect to VPN" instead of the name of the VPN, which means I can't tell them apart.  The Firefox shortcuts icons do *not* lose their name, only the icon.  So Maybe compare with OpenVPN for Android to see what Firefox is doing differently that the name sticks, and see if something Firefox is doing to the name isn't being done to the icon?

Comment 15

[Dave Miller [:justdave]]

https://github.com/schwabe/ics-openvpn/issues/269 for the OpenVPN for Android issue, though he closed it out because he couldn't reproduce (probably because he didn't have a Samsung device).

Comment 16

[:Margaret Leibovic]

Given the number of dupes, we should probably fix this if we want to start promoting our "Add to home screen" feature.

Comment 18

[:Margaret Leibovic]

This is an old issue, but might have a similar solution to whatever we figure out for bug 1268455.

Comment 19

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Margaret Leibovic from comment #18)
> This is an old issue, but might have a similar solution to whatever we
> figure out for bug 1268455.

Bug 1268455 occurred because we manually modified the launcher entry in the manifest. This resulted in Android removing the old home screen shortcuts because the referenced manifest entry does not exist anymore (and there's no migration strategy).

This one here is different, especially if this is happening for almost every update; and if it's only the icon that is going to be replaced with the app icon. When creating a home screen shortcut we pass a label and a bitmap to the system. From thereon the system is responsible for storing those values. So if they partially disappear then this sounds like a launcher bug for now. It's also suspicious that all reports here mention only Samsung devices.

Comment 20

[Nevin Chen(Not active on Bugzilla)]

We can follow up this bug if we want to add custom support to Samsung device / launcher app in the future.

Comment 21

[Nevin Chen(Not active on Bugzilla)]

Hi Sebastian
Do you think we should add a tag like "manufacturer-specific" to curate this kind of bug?
Please give me some advice. Thanks!

Comment 22

[timveer]

FWIW, I don't think this should be tagged "manufacturer-specific". This happens on my Asus tablet, Motorola (Moto G & Moto X Style) and white-labelled (MyPhone - Philippines) phones as well. I saw this on KitKat and Marshmallow using both the stock Android launcher and NovaLauncher.

Comment 23

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to timveer from comment #22)
> FWIW, I don't think this should be tagged "manufacturer-specific". This
> happens on my Asus tablet, Motorola (Moto G & Moto X Style) and
> white-labelled (MyPhone - Philippines) phones as well. I saw this on KitKat
> and Marshmallow using both the stock Android launcher and NovaLauncher.

You see this happen on multiple devices? What triggers this? Is this after every update?

Comment 24

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Kaspari (:sebastian) from comment #23)
> (In reply to timveer from comment #22)
> > FWIW, I don't think this should be tagged "manufacturer-specific". This
> > happens on my Asus tablet, Motorola (Moto G & Moto X Style) and
> > white-labelled (MyPhone - Philippines) phones as well. I saw this on KitKat
> > and Marshmallow using both the stock Android launcher and NovaLauncher.
> 
> You see this happen on multiple devices? What triggers this? Is this after
> every update?

FWIW, I saw this consistently on an old Samsung Galaxy S2, and it was "clearly" a Samsung Launcher bug.  I could provoke it with packages that weren't Firefox.  I doubt I have the device to reproduce, unfortunately.

Comment 25

[Nevin Chen(Not active on Bugzilla)]

Hi Max
I think you have dealt with this issue. Could you help give me some idea?

Comment 26

[Max Liu [:maliu]]

I think this symptom is highly "Launcher" app dependent.
In my previous job/project experience, Launcher app have to store the icon of shortcut into db itself and listen to system broadcast of package add/remove intent. If Launcher didn't handle intent with extra "EXTRA_REPLACING", it will assume the app is uninstalled, not remove temporary for upgrade. So the shortcut will be removed from workspace, or re-bind the icon from app with default icon, or any other weird symptom, that's all by Launcher app implementation.

Can any one reproduce the symptom on HTC devices? ;)

Comment 27

[timveer]

(In reply to Sebastian Kaspari (:sebastian) from comment #23)
> (In reply to timveer from comment #22)
> > FWIW, I don't think this should be tagged "manufacturer-specific". This
> > happens on my Asus tablet, Motorola (Moto G & Moto X Style) and
> > white-labelled (MyPhone - Philippines) phones as well. I saw this on KitKat
> > and Marshmallow using both the stock Android launcher and NovaLauncher.
> 
> You see this happen on multiple devices? What triggers this? Is this after
> every update?

Sorry for the delay Sebastian, I was away.
Yes, I have tried on multiple phones (Kitkat & Marshmallow; samsung, motorola and LG) The end result is the same. The homepage icons for web shortcuts are reset to the Firefox icon on every update.

Comment 28

[timveer]

(In reply to timveer from comment #27)
> (In reply to Sebastian Kaspari (:sebastian) from comment #23)
> > (In reply to timveer from comment #22)
> > > FWIW, I don't think this should be tagged "manufacturer-specific". This
> > > happens on my Asus tablet, Motorola (Moto G & Moto X Style) and
> > > white-labelled (MyPhone - Philippines) phones as well. I saw this on KitKat
> > > and Marshmallow using both the stock Android launcher and NovaLauncher.
> > 
> > You see this happen on multiple devices? What triggers this? Is this after
> > every update?
> 
> Sorry for the delay Sebastian, I was away.
> Yes, I have tried on multiple phones (Kitkat & Marshmallow; samsung,
> motorola and LG) The end result is the same. The homepage icons for web
> shortcuts are reset to the Firefox icon on every update.

**UPDATE**
Today I just tried the update to FF v50.10 on Android and the icons retained their custom appearance. They did not reset as previously. I don't know when this fix took effect, but on my devices it now appears to work correctly. Dean

Comment 29

[Sebastian Kaspari (:sebastian; :pocmo)]

I'm going to close this now: As described previously we hand an intent and an icon (the actual bitmap, not a path or anything) to the launcher and from there on it's the launcher's responsibility to display and maintain this. If at some point the launcher does something else then we don't know about it and we can't do anything about it either.

Please reopen/comment if you disagree.

Comment 30

[Nevin Chen(Not active on Bugzilla)]

I've tested :
fennec-51.0a2.multi.android-arm.apk
fennec-52.0a2.multi.android-arm.apk
fennec-53.0a1.ca.android-arm.apk
Updating Firefox won't change the icons for homescreen bookmarks nor webapps.