968998 - [B2G][l10n][All Locales]E.Me Smart Collection list is displayed in english.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: SuggestedSearchList_English.png

The user can create apps that automatically perform an E.Me search when tapped. When the user is creating one of these apps, they are presented with a list of suggested phrases to search for. These phrases all display in english when the device language is set to Bengali.

Repro Steps:
1) Updated Buri to BuildID: 20140203004001
2) Long press on the homepage.
3) Select 'Add Smart Collections'(স্মার্ট সংগ্রহ হিসেবে যোগ করুন).
4) Observe list of suggestions.

Actual:
All suggestions are displayed in english except for 'Custom...'(স্বনির্ধারিত...).

Expected:
All suggestions on list are displayed in Bengali.

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140203004001
Gaia: f9a37c77efb4621a1f57e4695b497d18601fe134
Gecko: 3d9d920ca43b
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: screenshot

Comment 1

[Cristian Rodriguez (:crdlc)]

This part is provided by ev.me

Comment 2

[Preeti Raghunath(:Preeti)]

Cristian

Please review

Comment 3

[Cristian Rodriguez (:crdlc)]

The issue:

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/Brain.js#L1244

Evme.CollectionsSuggest.load({
          'shortcuts': suggestedShortcuts,
          'icons': icons,
          'locale': locale
        });

locale === data.response.locale === "en_WW"

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/CollectionsSuggest/CollectionsSuggest.js#L85

var doTranslate = data.locale !== WORLDWIDE_LOCALE;

It is false because the response says that the locale is "en_WW"

I changed the previous variable

doTranslate = true

and the suggestions were translated.

I don't know why this condition but if evme guys did that, I am pretty sure that there is a good reason. Please Amir, could you take a look?

Comment 4

[Amir Nissim (:amirn)]

By design, the Collection suggestions list is displayed in English for languages not supported by E.me. 
See bugs 946724 and 938067 for more details.

Thanks.

Comment 5

[Cristian Rodriguez (:crdlc)]

Amir,

   French is not supported?

Comment 6

[Amir Nissim (:amirn)]

French is supported.
Note that changing the device language is not enough. You will only get French suggestions if your location implies you are in France or if you add locale=fr to the querystring.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #4)
> By design, the Collection suggestions list is displayed in English for
> languages not supported by E.me. 
> See bugs 946724 and 938067 for more details.
> 
> Thanks.
> 
> *** This bug has been marked as a duplicate of bug 938067 ***

That's not going to work & isn't acceptable to be "by design." We have operators that require translations to ship products for any required locale. This is going to be blatantly embarrassing if we ship a full UI without a translation. So this needs to be fixed.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #6)
> French is supported.
> Note that changing the device language is not enough. You will only get
> French suggestions if your location implies you are in France or if you add
> locale=fr to the querystring.

That's wrong behavior. The device language on the device is the primary driver to determine what locale text is displayed on the device. With additional cases, you put the phone in the awkward state of having mixed translations, which is poor UX. Also - It's not unreasonable for someone to decide to have their phone in a language that doesn't match the primary locale of the country, so forcing a particular language is fundamentally breaking that use case.

This needs to be fixed & will block certification.

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

1. About the Bangali language and the hardcoded translations not kicking in. 
E.me supports territories that FxOS has been officially launched in. The list of shortcuts/Collections is returned from E.me servers already translated and hardcoded translations take precedence. If the territory isn't supported, the list is returned in English and hardcoded translations are ignored in order to display a list uniform in it's language.
Bengal is not a supported territory, therefore the list is presented in English. This is by design and was concluded in Bug 938067.

2. Non matching location and locale result in English list. I'm looking into this.

Comment 11

[Jason Smith [:jsmith]]

(In reply to Ran Ben Aharon (Everything.me) from comment #10)
> 1. About the Bangali language and the hardcoded translations not kicking in. 
> E.me supports territories that FxOS has been officially launched in. The
> list of shortcuts/Collections is returned from E.me servers already
> translated and hardcoded translations take precedence. If the territory
> isn't supported, the list is returned in English and hardcoded translations
> are ignored in order to display a list uniform in it's language.
> Bengal is not a supported territory, therefore the list is presented in
> English. This is by design and was concluded in Bug 938067.

That doesn't make sense. Whether or not the territory is supported doesn't matter here - users shouldn't be forced into using English if the country doesn't have English as a primary language. That's going to appear broken to a user.

This use case will become especially problematic as we move to a community-driven strategy in the near future, as we'll have community testers who might test Firefox OS in a country that we have not launched in. As such, forcing English here is going to make community adaption in those countries much more of a pain.

However - given that target markets aren't affected here, I'll remove the blocking flag. I'm putting needinfo on product here, as I'd like product to weigh here on what they think the right behavior is.

Comment 14

[Delphine Lebédel [:delphine - Use needinfo]]

Pitching in a bit late here but I totally agree with Jason's comment.
Also, Bengali (bn-BD) is one of our oncoming target locales and I believe we should have this translated in that language as well

Comment 16

[Peter Dolanjski [:pdol]]

Ran, Jason makes solid points about the overall language needing to apply to all aspects of the device, the collections list included.  Do we have a good sense of how to fix this?

Comment 17

[Ran Ben Aharon [:ranbena] EverythingMe]

I'm debating this with Peter Dolanjsky.

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

This still hasn't been corrected in 1.4?
Seems like we really need to be more consistent here. Any updates about this please?

Comment 19

[Ran Ben Aharon [:ranbena] EverythingMe]

This issue is server side and thus unreliant on FxOS versions.

I don't have a concrete update on this but a solution is in the works.

Comment 20

[Ran Ben Aharon [:ranbena] EverythingMe]

We are targeting start of next week (May 19th). Will keep you up to date.

Comment 21

[Ran Ben Aharon [:ranbena] EverythingMe]

Now, the Smart Collection list will always match the OS locale (this obviously is relevant for territories agreed upon with Mozilla)

Comment 22

[Pi Wei Cheng [:piwei] (inactive)]

What would you like QA Wanted to do in here?

Comment 23

[mhall]

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140521000202
Gaia: 93623f6435849cc9f54d9996e8e64828ac9091d1
Gecko: 12fe2b67a099
Version: 30.0
Firmware Version: v1.2-device.cfg

This issue has been fixed on the Buri 1.4 MOZ RIL

Comment 24

[Jason Smith [:jsmith]]

I think Ran was asking for verification, which is something that was done above.

Comment 25

[Ran Ben Aharon [:ranbena] EverythingMe]

Basically, observe the language of the list items when the location doesn't "match" the OS language.

The original bug was opened for the following: Location:US, OS language:Bengali, in which the Smart Collection list was displayed in English. Now it's displayed in Bengali.