Closed Bug 969354 Opened 11 years ago Closed 11 years ago

Black rect to left of the about:start watermark displays when scrolling

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Version:
26 Branch
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla30
Tracking Flags:
Tracking Status
firefox27 --- unaffected
firefox28 --- unaffected
firefox29 --- affected
firefox30 + verified

People

(Reporter: jimm, Assigned: roc)

References

Details

(Whiteboard: [metro] [qa+])

Attachments

(1 file)

proper fix
13.58 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
STR:

1) Load about:start in metrofx 
2) touch scroll to the right

result: a black rect is displayed briefly to the left of the watermark image block.
tracking-firefox30: --- → ?
Note, it helps if you clear history to remove all top site tiles. The rect shows up in the watermark layer, so top site tiles can obscure it.
Also, it only happens on the first about:start pan from the left bounds. Interim scrolls don't reproduce.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #58)
> (In reply to Jim Mathies [:jimm] from comment #57)
> > This is a regression from bug 967587, filed bug 969354.
> 
> That makes sense. You can probably work around it in about:start by making
> the image slightly transparent or something like that.
Whiteboard: [metro] → [metro][release28]
Depends on: 970990
Nothing obvious springs to mind as to what's causing the problem here.

If you delete the descendants of <body> before scrolling, does the bug still occur? If not, then which element triggers it? If so, at least we have a reduced testcase.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5)
> Nothing obvious springs to mind as to what's causing the problem here.
> 
> If you delete the descendants of <body> before scrolling, does the bug still
> occur? If not, then which element triggers it? If so, at least we have a
> reduced testcase.

If you remove everything, leaving only the body with the watermark with a long width set on it, the problem goes away. Add back the first hbox -

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/startui/Start.xul#44

with nothing in it, the problem comes back.

Note, rsilveira may have found a work around for this in bug 971124.
No longer blocks: metrov1backlog
Whiteboard: [metro][release28] → [metro]
Attached patch proper fix — — Splinter Review 
Needs manual testing. Jim, can you test if this fixes Metro properly? I'll test it on Android/B2G.
Assignee: nobody → roc
Attachment #8377355 - Flags: review?(matt.woodrow)
Flags: needinfo?(jmathies)
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #7)
> Created attachment 8377355 [details] [diff] [review]
> proper fix
> 
> Needs manual testing. Jim, can you test if this fixes Metro properly? I'll
> test it on Android/B2G.

Reapplied our old watermark css and I can confirm this fixes the black rect problem.
Flags: needinfo?(jmathies)
Attachment #8377355 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/68b905ed5fc4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Is this safe to uplift to branches?
Flags: needinfo?(roc)
Sorry, this should be unaffected on 28 if it's a blocker for 967587 which is also marked as such.
status-firefox28: affected → unaffected
For testing and verification.  Reopen if defects are found.
Flags: needinfo?(kamiljoz)
I discussed this with :rsilveira via IRC and we're not using the same watermark anymore. Based on Jims comment #8, I'm marking this as verified.
Status: RESOLVED → VERIFIED
status-firefox30: fixed → verified
Flags: needinfo?(kamiljoz)
Whiteboard: [metro] → [metro] [qa+]
Depends on: 978490
Flags: needinfo?(roc)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: