984573 - Add colors to mentees section of Dashboard

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[William Reynolds [:williamr]]

In order for mentors to easily visualize which mentees are documenting activities and which are not, let's add some simple colors to the mentees section of the Dashboard. This will help mentors know when to contact the mentees who have not done activities recently.

User stories:
- As a mentor, if my mentee has not reported any activities in X weeks, highlight that mentee's row in a color in the Reports section of the Dashboard.
- As a mentor, if my mentee has not reported any activities in Y weeks, highlight that mentee's row in a color in the Reports section of the Dashboard.

Suggested colors and time periods:
- Yellow for mentees who have not reported activities in 4 weeks or more
- Red for mentees who have not reported activities in 8 weeks or more

Comment 1

[William Reynolds [:williamr]]

Brian, can you chime in on the colors and time periods in comment 0?

The dashboard currently shows number of activities in 'Last 2 weeks' and 'Last 10 weeks'. To be consistent and prevent confusion, I suggest we update these two time periods to match the time periods that we choose for the colors in this bug. Changing the 'Last X weeks' time periods should be trivial, and I will file a separate bug once we decide on the time periods.

Comment 2

[Brian King [:kinger]]

Yellow and Red are fine. Red is very overpowering, but seems the best colour to get across the message we want.

+1 for syncing up on time periods.

Comment 3

[William Reynolds [:williamr]]

(In reply to Brian King [:kinger] from comment #2)
> Yellow and Red are fine. Red is very overpowering, but seems the best colour
> to get across the message we want.

I suggest using a lighter shade of red that is not too overpowering.

I filed bug 986073 to change the time periods on the dashboard to match the specs for the colors in comment 0 of this bug.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

I suggest the initial implementation of this use the timespans we earlier specified for this flag, since they are already implemented. They're covered in https://bugzilla.mozilla.org/show_bug.cgi?id=970395:

"As a mentor I get an email when a mentee of mine doesn't have reports with report_date between 3 weeks in the past and 3 weeks in the future from now."

Comment 5

[John Giannelos [:nemo-yiannis]]

I have attached some screenshots with different ways to add colors in the mentees dashboard. I lean towards the different font colors instead of changing the background. I used the colors we already have in the notification messages (red for errors, orange for warnings). Another approach could be to append a label next to the name. 


Any suggestions regarding the UI will be appreciated.

Comment 6

[John Giannelos [:nemo-yiannis]]

Attachment: inactivity-colors-font-color-row.png

Comment 7

[John Giannelos [:nemo-yiannis]]

Attachment: inactivity-colors-background-overpowering.png

Comment 8

[John Giannelos [:nemo-yiannis]]

Attachment: inactivity-colors-background.png

Comment 9

[John Giannelos [:nemo-yiannis]]

Attachment: inactivity-colors-font-color-names-only.png

Comment 10

[Alex Gibson [:agibson]]

I vote for font-colour, as the contrast is a bit less jarring :)

If we did go for styling background colour, we could probably use some softer variations on these colours.

Comment 11

[Alex Gibson [:agibson]]

Also, I think colouring the names only might be adequate enough, rather than the content in each column on a given row.

Comment 12

[Alex Gibson [:agibson]]

Maybe adding a legend for the different colour labels might also be useful.

Comment 13

[John Giannelos [:nemo-yiannis]]

:agibson brings up some valid points regarding UX and accessibility in that comment:

https://github.com/mozilla/remo/pull/685#issuecomment-39181154

:williamr Any thoughts? Maybe we could do an initial implementation of that feature by adding colored labels next to each inactive mentee also mentioning the last report date or if its more than 4 or 8 weeks since.

Comment 14

[William Reynolds [:williamr]]

(In reply to John Giannelos [:nemo] from comment #13)
> :williamr Any thoughts? Maybe we could do an initial implementation of that
> feature by adding colored labels next to each inactive mentee also
> mentioning the last report date or if its more than 4 or 8 weeks since.

Great suggestion to mention the last report date. I suggest we add a 'Last activity' column after the Total column.

Adding a legend for the different color labels might also be useful. The labels would be "Last activity 4-8 weeks ago" and "Last activity 8+ weeks ago". That can be added in this bug or as an enhancement in a future bug.

Comment 15

[Justin Crawford [:hoosteeno] [:jcrawford]]

I have created an etherpad to track the evolving specs for activity tracking:

https://remo.etherpad.mozilla.org/inactive-rep-specs-v2-2014-04-03

Please review and update it by 2014-04-09. If you have questions, please ask them in channel or in email, but don't wait for a meeting to ask them.

Comment 16

[Justin Crawford [:hoosteeno] [:jcrawford]]

The specs in the etherpad linked from comment 15 are sound. The mockup for this feature is here:

http://cl.ly/image/0Z1Z112O3E1z

Please note that in the mockup is a circle around "Last 2 weeks", "Last 10 weeks". These should be changed to "Last 4 weeks", "Last 8 weeks" and the data should be changed to match.

Furthermore, the word "Reports" in the mockup should be "Activity".

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/4f6951210e33621cf1c6ad52579c967a6d1c3424
[Fix bug 984573] Add colors to mentees section.

* [Fix bug 951503] Add methods to get inactivity level and last report
* [Fix bug 986073] Change activity periods in dashboard.
* Add reference for inactivity levels. Change page header.

Comment 18

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/b5f3194eabe4528d77d3753b1d0dd97823401d6b
[bug 984573] Update inactivity label.

https://github.com/mozilla/remo/commit/e8de7224808a43e3e4b46071e869f25420c1ff9d
Merge pull request #715 from glogiotatidis/984573

[bug 984573] Update inactivity label.

Comment 19

[Giorgos Logiotatidis [:giorgos]]

Verified on stage:
 - When at least one activity within the last 4 weeks: link color blue (default)
 - When at least one activity within the last 8 weeks, but not within the last 4 weeks: link color orange
 - When no activity within the last 8 weeks: link color red

Thanks :nemo!