985400 - Unable to interact with sub menus on LG Optimus 4X HD (4.1.2)/LG G2

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Build:Nightly 31.0a1 (2014-03-18),
Aurora 30.0a2 (2014-03-18)
Device: LG Optimus 4X HD (4.1.2)

Steps to reproduce:
1. Press menu button
2. Go to Page or Tools sub-menu
3. Try to select any option available

Expected Results: 

You are able to select the wanted option.

Actual Results:

The options available can't be selected.

Note: I think this is only a device specific bug since I've only been able to reproduce this issue on my LG Optimus 4X HD (4.1.2) device which possess a hardware menu button. Also it might be related with Bug 983649.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I think this is related to bug 961954. Sriram moved that code to startup originally for phones with hardware menu buttons.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

We have one of these phones in MV.

Comment 3

[Wesley Johnston (:wesj)]

Kevin, Can you send it to me? Or I may be in mtv Friday...

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Commented on IRC. I am not in MV til next week. Best to poke tchung or jsmith before early on Wednesday so it can be sent up by the SF <-> MV courier.

Comment 6

[Aaron Train [:aaronmt]]

LG G2 affected as per bug 989076.

Comment 7

[Wesley Johnston (:wesj)]

Backing out bug 968182 does fix this.

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Patch

Maybe you know a bit about this Lucas. I'm still trying to figure out what's going wrong tbh.

I noticed that, even though we call close() first this menu smoothly animates between the two lists. i.e. It wasn't actually closing. Posting the show code back to the UI thread fixes the bug. Again, I'm not 100% sure why. Its a sad hack, that may not work on all devices.

Alternatively, we could take the measure code from bug 968182. Or we can keep digging down the hole here.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking - looks like we can consider a backout when 30 heads to beta if there's no fix yet.

Comment 10

[Lucas Rocha (:lucasr)]

Comment on attachment 8399704 [details] [diff] [review]
Patch

Review of attachment 8399704 [details] [diff] [review]:
-----------------------------------------------------------------

Not keen on this hack but I don't have any useful suggestion to make right now (I'd have to dig deeper into our and Android's menu system).

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/309c62fdf8ac

Comment 12

[Wesley Johnston (:wesj)]

Comment on attachment 8399704 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):  bug 968182 
User impact if declined: Menu items can't be tapped
Testing completed (on m-c, etc.): Landed on mc now. Needs a little bake time...
Risk to taking this patch (and alternatives if risky): This is pretty low risk. Same code running, just running at a different time. We could backout, but that tickles a different bug (although we have other options there...)
String or IDL/UUID changes made by this patch: None.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/309c62fdf8ac

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8399704 [details] [diff] [review]
Patch

might as well bake on both nightly and aurora to get a bit more feedback - tracking in case we need to backout.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/011dca98f06a

Comment 16

[u421692]

Verified as fixed on latest Aurora and Nightly on LG Optimus 4x HD(Android 4.1.2).
I am providing the requested information for Paul, since 11.04.2014 was the last day working for Mozilla.