986347 - Re-regression, menupopup is transparent, menuitem are invisible in certain case.

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Attachment: screenshot

When I test Bug 844255, the menupopup transparent problem re-appears.

I am not sure this is related or not, but I saw following post.
http://forums.mozillazine.org/posting.php?mode=quote&f=38&p=13358897

Steps To Reproduce:
1. Start Firefox witnout HWA on Windows7 Aero
2. Open  attachment 717269 [details] (remote XUL should be enabled)

3. Hover toolbar
4. Click Menu1

5. Move mouse pointer to content area and wait to auto close menu
6. Click content area to dismiss gurbage

7. Hover toolbar
8. Cick Menu1

Actual Results:
 menupopup is transparent

Expected results:
 menupopup should be visible

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/dbf94e314cde
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131121191711
Bad:
http://hg.mozilla.org/mozilla-central/rev/9a179f9b33ca
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131122054606
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dbf94e314cde&tochange=9a179f9b33ca


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/5f093277a586
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131121192109
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/01e15a1abbb1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131121193706
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f093277a586&tochange=01e15a1abbb1

Triggered by: Bug 925599

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Restore accidentaly removed HasBogusPopupsDropShadowOnMultiMonitor() call

Ouch.

Comment 2

[Alice0775 White]

More report,
http://forums.mozillazine.org/viewtopic.php?f=38&t=2811677

Comment 3

[Alice0775 White]

Sorry spam.
I just wanted to make sure this is on your radar before your long holiday

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8394650 [details] [diff] [review]
Restore accidentaly removed HasBogusPopupsDropShadowOnMultiMonitor() call

thanks for the reminder! This looks ok to me.

Comment 5

[Jim Mathies [:jimm]]

Isn't this going to regress bug 844255?

Comment 6

[Masatoshi Kimura [:emk]]

This bug IS the regression. Bug 925599 regressed bug 844255 by removing the fix accidentally. This patch will just reintroduce the fix.

Comment 7

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa36e3723fde

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aa36e3723fde

Comment 9

[Alice0775 White]

Confirmed, the problem was fixed on Nightly31.0a1(2014-03-26)
https://hg.mozilla.org/mozilla-central/rev/140ac04d7454
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140326030203


Could you please lift up the patch to Aurora30.0a2 and Firefox29beta?

Comment 10

[Masatoshi Kimura [:emk]]

Comment on attachment 8394650 [details] [diff] [review]
Restore accidentaly removed HasBogusPopupsDropShadowOnMultiMonitor() call

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 925599
User impact if declined: Some popup windows will be transparent.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): very low.
String or IDL/UUID changes made by this patch: none.

Comment 11

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b6d8117067d1
https://hg.mozilla.org/releases/mozilla-beta/rev/3d9e7c86149a

Comment 14

[Manuela Muntean [Away]]

Attachment: error.png

I get the error shown in the attached screenshot, when I try to reproduce this issue, with the Nightly from 2013-11-22, but also with Firefox 29 beta 3, on Win 7 x64.

Any thoughts/suggestions?

Comment 15

[Alice0775 White]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #14)
> Created attachment 8398457 [details]
> error.png
> 
> I get the error shown in the attached screenshot, when I try to reproduce
> this issue, with the Nightly from 2013-11-22, but also with Firefox 29 beta
> 3, on Win 7 x64.
> 
> Any thoughts/suggestions?

Enable Remote XUL.
(for instance, install https://addons.mozilla.org/en-US/firefox/addon/remote-xul-manager/
and add bugzilla.mozilla.org)

Comment 16

[Manuela Muntean [Away]]

> Enable Remote XUL.
> (for instance, install
> https://addons.mozilla.org/en-US/firefox/addon/remote-xul-manager/
> and add bugzilla.mozilla.org)

Thanks, Alice!

Verified as fixed with Firefox 29 beta 3 on win 7 x64.

Comment 17

[Manuela Muntean [Away]]

Also verified as fixed with latest Nightly & Aurora on Win 7 x64.