99415 - [FIX]Need better configurability of headers/footers

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[rods (gone)]

We need to to be able to be able to more easily tailor where the title, doc URL, 
date-time and page numbers are placed.

We can do this by enabling the print options to have 6 six strings
Left, Center, Right for the header
Left, Center, Right for the footer

Then we can indicate what goes where by using the following varibales that will 
be substituted:

&T - title
&U - Document URL
&D - Date/Time
&p - Page Number
&P - total Number of pages

(The patch will soon follow, I have it in my tree)

Comment 1

[Boris Zbarsky [:bzbarsky]]

This seems to be filed under a bunch of different guises.  Making this block the
various bugs on the topic (some of them resolved REMIND for a while now) so that
once this is checked in the dependencies can all be evaluated as to which of
them have been fixed.

bug 66713 -- Add UI to turn on/off print headers/footers
bug 5332 -- [enhancement] printing headers and footers on Unix
bug 69459 -- "Printing should allow control over the header and footer,
              orientation, printer selection, which pages to print [print]
              [embed]"
bug 17741 -- RFE: Allow better customization of headers/footers

Two comments:

1)  Are not %-escapes more common for this sort of thing?  What does 4.x on
    Windows do (on Unix it does not allow header/footer customization).

2)  Rod, is your patch for Windows only?  Or is it XP?

Comment 2

[rods (gone)]

Attachment: patch file

Comment 3

[dcone (gone)]

r=dcone.  The nsSimplePageSequenceFrame::Paint() is a debug only piece of code.

Comment 4

[elaineking]

moved to milestone 0.9.5, 0.9.4 is over.  per pdt mtg.

Comment 5

[Marek Z. Jeziorek]

putting nsbranch on this one. Who could sr= this one (once this is done please
update the status attachment)

Comment 6

[Marc Attinasi]

Comment on attachment 49350 [details] [diff] [review]
patch file

sr=attinasi

Comment 7

[Cindy Roberts]

Since this has a fix, and has reviews finished, please mark as nsbranch+ so we
can get on the radar for PDT approval for check into the Netscape branch.

Comment 8

[rods (gone)]

Attachment: proposed patch (includes fix for Bug 100797)

Comment 9

[Marc Attinasi]

Comment on attachment 50572 [details] [diff] [review]
proposed patch (includes fix for Bug 100797)

sr=attinasi, but please check for nulls (nomemory) as we discussed on the phone.

Comment 10

[Kevin McCluskey (gone)]

Comment on attachment 50572 [details] [diff] [review]
proposed patch (includes fix for Bug 100797)

r=[e-mail]

Comment 11

[Kevin McCluskey (gone)]

Marking nsbranch+

Comment 12

[selmer (gone)]

PDT+, please check in.

Comment 13

[rods (gone)]

The final list of codes are:

&T - Title
&U - Document URL
&D - Date/Time
&P - Page Number
&PT - Page Number "of" Page total

Plus, you can configure where these go with these prefs:

user_pref("print.print_footerleft", <put the code here>);
user_pref("print.print_footercenter", <put the code here>);
user_pref("print.print_footerright", <put the code here>);
user_pref("print.print_headerleft", <put the code here>);
user_pref("print.print_headercenter", <put the code here>);
user_pref("print.print_headerright", <put the code here>);

For example:
user_pref("print.print_footerleft", "&PT");


This is now fixedin the tip and branch

Comment 14

[rods (gone)]

On tip and branch

Comment 15

[sujay]

Boris, if you can help verify this one that would be great...thanks.

Comment 16

[t.schnier]

I have just tried this with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4+)
Gecko/20010927:

When I set the preferences like this:

user_pref("print.print_footerleft", " ");
user_pref("print.print_footercenter", " ");
user_pref("print.print_footerright", " ");
user_pref("print.print_headerleft", " ");
user_pref("print.print_headercenter", " ");
user_pref("print.print_headerright", " ");

it works, but when I set them to empty strings "", I get a floating point
exception after the page has been produced

/home/thorsten/tmp/mozilla/run-mozilla.sh: line 72:  7503 Floating point
exception$prog ${1+"$@"}

Also: presumably there will be a UI to configure this, preferably with
togglesheader:blank - user defined
footer blank - user defined ?

Comment 17

[sujay]

I think its okay to mark this one verified-fixed and open a new
bug based on the floating point error.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Sujay: verified on linux trunk.  Would you still like me to get a branch build
and test?  I could, but it might take a day or so...

Bug 102257 filed for the crash (patch attached there).

Comment 19

[sujay]

yes Boris if you do get a chance please verify on branch...
let me know if it works....

Comment 20

[sujay]

reopen, awaiting branch verification.

Comment 21

[sujay]

marking fixed. 

Boris is going to verify on branch...

Comment 22

[Boris Zbarsky [:bzbarsky]]

verified on linux branch 
(Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4) Gecko/20010928)

yay thunderstorm ending.  :)