998100 - [Tarako][Sound] Keypad sound and sound for keyboard UX and disabled settings confusing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[guigs [:guigs] PST (please needinfo me!)]

STR UX Reproduce 
This builed 1.3 nightly has the click sound option in the built in keyboard (Tarako does not)


1. Settings > sound > "Keypad" turns off the keypad number tone off

expected:
turn off sound for all keyboard tapping

Result: 
only turns off tone for number pad

2 In Tarako build 20140417004002: Keyboard > Keyboard settings> options are not showing up in interface: "click sound" "Auto correction" "word suggestion"
In Nightly build: all of these are turned on

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

back logging, as I would not hold release, but a number of people have expressed that having this would be good.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to rmcguigan from comment #0)
> STR UX Reproduce 
> This builed 1.3 nightly has the click sound option in the built in keyboard
> (Tarako does not)
> 
> 
> 1. Settings > sound > "Keypad" turns off the keypad number tone off
> 
> expected:
> turn off sound for all keyboard tapping
> 
> Result: 
> only turns off tone for number pad

The virtual keyboard in Gaia would not look at this setting, which is "phone.ring.keypad", instead it would check "keyboard.clicksound" setting. 

> 
> 2 In Tarako build 20140417004002: Keyboard > Keyboard settings> options are
> not showing up in interface: "click sound" "Auto correction" "word
> suggestion"
> In Nightly build: all of these are turned on

This change happened only on Tarako with this bug, bug 991627.

Comment 4

[Jason Smith [:jsmith]]

I'm sending this over to UX because this has come up in multiple bug bashes as an annoying papercut. People always seem to get confused what the keypad sound intending to modify...

Comment 5

[Stephany Wilkes]

Flagging Carrie in case this is more of a keyboard issue, and Omega in case it's more specifically Settings. Not blocking.

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

My suggestion is:
Change "Settings > Sound > Keypad" to "Settings > Sound > Dial Pad"
It should be clearer now.

Comment 7

[Dominic Kuo [:dkuo]]

Attachment: quick patch

Just set this review? to owner/peer when we want this fixed.

Comment 8

[Omega Feng [:Omega] [:馮於懋]]

Please see Bug 991026 for the latest UX spec.

Comment 9

[Dominic Kuo [:dkuo]]

Comment on attachment 8419890 [details] [review]
quick patch

EJ,

This is a simple patch that added a new string in the sound panel, would you please review it? thanks.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8419890 [details] [review]
quick patch

r+ based on UX's comment (comment 6)

thanks for your work, Domi !

Comment 11

[Dominic Kuo [:dkuo]]

Thanks EJ!

Landed on master: 6a778cb4c41415e389db5f73441db3dea374a601