229545 - Land ChatZilla 0.9.54 on trunk

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

ChatZilla's gone through a few developements off the trunk (0.9.54[a-f]) and
it's about time we landed them. This covers all the diffs *except* the new pref
window, which is still going through big changes. Patch to follow once I've
split my tree up correctly. :)

Comment 1

[James Ross]

Attachment: Patch of 0.9.54[a-f] changes, minus pref window.

This patch covers all the bugs maked as dependencies, as well as:
  - /names works from any view, and for any channel.
  - Copy Link Location.
  - Remove op checks for op commands (let the server check).
  - Adjusted UI to enable op commands for half-op as well.
  - Add iAmHalfOp function.
  - Localise PrefManager (inc. strings for existing prefs).
  - autoRejoin on kick added (default: off)
  - inline editing of topics copes with colour codes.
  - ...and a few general code fixes (strict warnings and general safety).

Comment 2

[Jungshik Shin]

Does it include any necessary change talked about in bug 225695 (follow-up to
bug 44272)? 

Comment 3

[James Ross]

No, this does not contain any of the changes mentioned in bug 225695.

Comment 4

[Robert Ginda]

Comment on attachment 138045 [details] [diff] [review]
Patch of 0.9.54[a-f] changes, minus pref window.

-    if (this.lastPingSent)
+    if (("lastPingSent" in this) && this.lastPingSent)
	 this.lag = roundTo ((new Date() - this.lastPingSent) / 1000, 2);

I think it'd be better if we init lastPingSent to null in the ctor instead.


     this.active = false;
+    this.joined = false;

A comment explaining the difference between active and joined would be great.

     if (typeof source != "object")
+    {
+	 if (!(source in client.viewsArray))
+	     return;
	 source = client.viewsArray[source].source;
+    }

This looks like a good place for an ASSERT, instead of a silent failure.


+    msg = msg.replace(/^%U/g, "\x1f");
+    msg = msg.replace(/([^%])%U/g, "$1\x1f");

These two statements could be combined into one with:

replace(/(^|[^%])%U/, "$1b")

+	 msgSource = document.createElementNS("http://www.w3.org/1999/xhtml",
						  "html:td");

Indentation is off here, and in two other places where the same change was
made.

r=rginda with these changes.

Comment 5

[James Ross]

Landed on trunk @ 14:21, 03 Jan 2004.