1186552 - (Backendnuken) [meta] Project Backendnuken - Skia backend unless accelerated Windows

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

Delete all backends other than D2D 1.1 and replace them with Skia.

Comment 2

[Gerry Chang [:gchang]]

Hi :mchang,
Will this feature be in 51? There are still a few bugs here.

Comment 3

[Lee Salzman [:lsalzman]]

(In reply to Gerry Chang [:gchang] from comment #2)
> Hi :mchang,
> Will this feature be in 51? There are still a few bugs here.

We backed out Skia content for Windows for now while Mason is on PTO. We will look into the bugs more thoroughly when he gets back.

Comment 4

[Gerry Chang [:gchang]]

Added to Fx51 (Aurora) release notes.

Comment 5

[Mason Chang [Inactive] [:mchang]]

(In reply to Gerry Chang [:gchang] from comment #4)
> Added to Fx51 (Aurora) release notes.

I think this should be for 52 for Windows. Skia on OS X was 48. 51 is for Linux / Android.

Skia is now the default content backend everywhere. Resolving this as WFM.

Comment 6

[Andrei Vaida [:avaida]]

I'm a bit confused by the last three comments. 

Mason, is this feature still shipping with Fx52 for Windows?

Should manual QA be tracking this? 
We had a more in-depth testing session on a similar bug in the past (Bug 1270688) and was wondering if there's anything we can help with here as well.

Comment 7

[Mason Chang [Inactive] [:mchang]]

(In reply to Andrei Vaida, QA [:avaida] – please ni? me from comment #6)
> I'm a bit confused by the last three comments. 
> 
> Mason, is this feature still shipping with Fx52 for Windows?

Yes this is.

> 
> Should manual QA be tracking this? 
> We had a more in-depth testing session on a similar bug in the past (Bug
> 1270688) and was wondering if there's anything we can help with here as well.

Thanks for the offer! You can just use Nightly as usual on Windows and see if you see any big problems. You can compare this with cairo, which was happening before this on Windows. Please try this:

1) Go to about:config
2) Set "layers.acceleration.disabled" to true.
3) Restart nightly. Go to about:support and make sure "AzureContentBackend" says Skia

Then compare this to:
1) Go to about:config
2) Set "layers.acceleration.disabled" to true and "gfx.content.azure.backends" is "cairo"
3) Restart nightly. Go to about:support and make sure "AzureContentBackend" says Cairo.

Just see if there are any regressions? Thanks!

Comment 8

[Andrei Vaida [:avaida]]

Thank you for following up on this so quickly! We'll draft a Test Plan for this as soon as possible and start test case creation based on your instructions.

I'm thinking that we should treat this as a full blown feature, since it might cause regressions for users without hardware acceleration. 

Mason, if you think it would be enough for QA to just treat this as regular bug work while it rides the trains, please let me know.

Comment 9

[Mihai Boldan, Desktop QA [:mboldan]]

Test plan: https://wiki.mozilla.org/QA/Skia_Content_for_Windows