418868 - M3 Tango

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Michael Monreal [:micmon]]

This bug will collect the M3 icons for gnomestripe during the next few days. They can be pushed upstream as they come in...

Comment 1

[Michael Monreal [:micmon]]

Attachment: M2 fixes

Let's start with a few icons that were changed after beta 3: new set of identity icons and minor fixes to the lock icons.

Filenames and directory layout in the .zip is taken from classic.jar, hopefully this will make things easy.

Comment 2

[Michael Monreal [:micmon]]

Attachment: Error console

Replacement for the current error console icon (stop/cancel icon). Needs a small CSS change.

Comment 3

[Michael Monreal [:micmon]]

The Error/Warning/Information/Question listed in the M3 inventory will be taken from the desktop icon theme. I filed bug 418877 for this.

Comment 4

[Michael Monreal [:micmon]]

Also added bug 419005 which is about cleaning up the usage of RSS-related icons.

Comment 5

[Michael Monreal [:micmon]]

As we aim to get all this stuff landed I'll also add bugs for M3 icons that we can cover with GTK stock icons, such as the file:/// icon in bug 419041.

Comment 6

[Michael Monreal [:micmon]]

Attachment: M3 drop-in replacements

Lots of icons... non of which should need any CSS change. Includes sets for both the addons and pageinfo headers and much more.

Comment 7

[Michael Monreal [:micmon]]

Attachment: M3 unused icons

This pack includes those M3 icons which are not yet used in gnomestripe. They are roughly sorted by type but I don't know the real filenames or where they will end up. CSS changed needed.

Comment 8

[Michael Monreal [:micmon]]

Attachment: New folder-item.png

This is a replacement for the old skin/classic/global/icons/folder-item.png. This bitmap includes mostly folders which are no longer needed because we use gtk-directory. I don't really know if this file is still needed for the default favicon. If yes, perhaps renaming the file would be a good idea?

Comment 9

[Michael Monreal [:micmon]]

Attachment: New ratings.png

This would be drop-in for mozapps/extensions/ratings.png but I noticed the current image uses smaller (11x11) rating stars. The stars here are 14x14 (which is the size requested in the icon inventory). So, either we have to fix the CSS or update the inventory and redo the rating icons. Personally I don't know if 14x14 is not too big.

Comment 10

[Michael Ventnor]

Attachment: folder-item patch

That folder-item looks pretty good for a default favicon so lets use that. CSS only needs one change to allow it to drop in Gnomestripe.

Comment 11

[Michael Ventnor]

I'm confused why you want to change Larry, people praise your current Larry the most because it is simple and the most understandable.

Comment 12

[Reed Loden [:reed]]

(In reply to comment #11)
> I'm confused why you want to change Larry, people praise your current Larry the
> most because it is simple and the most understandable.

MoCo requested the change so that all the Larry icons are cross-platform.

Comment 13

[Michael Ventnor]

Attachment: Page info patch

Comment 14

[Michael Ventnor]

Attachment: Addons mgr patch

Comment 15

[Reed Loden [:reed]]

Attachment: Error console patch

Comment 16

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/Secure.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Secure.png,v  <--  Secure.png
new revision: 1.6; previous revision: 1.5
done
Checking in browser/themes/gnomestripe/browser/Security-broken.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Security-broken.png,v  <--  Security-broken.png
new revision: 1.6; previous revision: 1.5
done
Checking in browser/themes/gnomestripe/browser/identity.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/identity.png,v  <--  identity.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/gnomestripe/browser/pageInfo.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/pageInfo.png,v  <--  pageInfo.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/places/toolbarDropMarker.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/toolbarDropMarker.png,v  <--  toolbarDropMarker.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/preferences/Options.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/Options.png,v  <--  Options.png
new revision: 1.9; previous revision: 1.8
done
Checking in browser/themes/gnomestripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png,v  <--  tabDragIndicator.png
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/console/console.png,v
done
Checking in toolkit/themes/gnomestripe/global/console/console.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/console/console.png,v  <--  console.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/dirListing/remote.png,v
done
Checking in toolkit/themes/gnomestripe/global/dirListing/remote.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/dirListing/remote.png,v  <--  remote.png
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/icons/blacklist_large.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_large.png,v  <--  blacklist_large.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/folder-item.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/folder-item.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/folder-item.png,v  <--  folder-item.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensionIcons.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensionIcons.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensionIcons.png,v  <--  extensionIcons.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/ratings.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/ratings.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/ratings.png,v  <--  ratings.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/themeGeneric.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/themeGeneric.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/themeGeneric.png,v  <--  themeGeneric.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png,v  <--  viewButtons.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/places/defaultFavicon.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/places/defaultFavicon.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/places/defaultFavicon.png,v  <--  defaultFavicon.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric.png,v  <--  pluginGeneric.png
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/mozapps/update/update.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/update/update.png,v  <--  update.png
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/mozapps/xpinstall/xpinstallItemGeneric.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/xpinstall/xpinstallItemGeneric.png,v  <--  xpinstallItemGeneric.png
new revision: 1.2; previous revision: 1.1
done

Comment 17

[Reed Loden [:reed]]

Comment on attachment 305077 [details] [diff] [review]
folder-item patch

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.186; previous revision: 1.185
done

Comment 18

[Reed Loden [:reed]]

Comment on attachment 305098 [details] [diff] [review]
Page info patch

Checking in browser/themes/gnomestripe/browser/pageInfo.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/pageInfo.css,v  <--  pageInfo.css
new revision: 1.14; previous revision: 1.13
done

Comment 19

[Reed Loden [:reed]]

Comment on attachment 305105 [details] [diff] [review]
Addons mgr patch

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.8; previous revision: 1.7
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.8; previous revision: 1.7
done

Comment 20

[Reed Loden [:reed]]

Comment on attachment 305145 [details] [diff] [review]
Error console patch

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.187; previous revision: 1.186
done
Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.32; previous revision: 1.31
done

Comment 21

[Reed Loden [:reed]]

Comment on attachment 304998 [details]
M3 unused icons

Not landing these yet until I've spoken to some people and figured out where these should go...

Comment 22

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.33; previous revision: 1.32
done
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.9; previous revision: 1.8
done

Comment 23

[Michael Ventnor]

Attachment: Addons mgr search patch

To be used with upcoming searchIcons.png. background-color: transparent is needed because otherwise we get the grey background from GFX buttons with the use of the stock icon.

Comment 24

[u294409]

Focus drawing of this searchbox will be fixed too? Or there's a bug about it?

Comment 25

[Michael Ventnor]

Attachment: New searchIcons.png

Hacked together in the GIMP from previous Tango icons for visual consistency.

Comment 26

[Michael Ventnor]

(In reply to comment #24)
> Focus drawing of this searchbox will be fixed too? Or there's a bug about it?
> 

Dunno whats wrong with that, I suspect they're using bindings somewhere. May look into it later.

Comment 27

[u294409]

attachment 305172 [details] is sweet iCandy for me [read: I like it very much] :) 

> Dunno whats wrong with that, I suspect they're using bindings somewhere. May
look into it later.

When this search entry is focused, not focus indicator is drawn around it.
This is old issue, but I thought it's temporary issue.

Comment 28

[Michael Ventnor]

Its actually because that searchbox is a completely custom XBL binding in extensions.xml. We have this same problem where custom bindings are used instead of regular textboxes elsewhere in the code (like the findbar). Custom bindings are needed to implement specific things like the flashing find textbox or the couple of icons in the extension search.

Not sure what to do about that, I'm not a master at XBL per se :)

Comment 29

[Michael Monreal [:micmon]]

(In reply to comment #25)
> Created an attachment (id=305172) [details]
> New searchIcons.png
> 
> Hacked together in the GIMP from previous Tango icons for visual consistency.
> 

This is for get-addons, right? I was told the extension icon (left side) will be removed. Perhaps we should move the search icons from browser/ to general/icons/?

Comment 30

[Ian Spence]

Personally, I wish there was some sort of compromise to be made with the Larry images.  I think it was a great idea to have the ? on the yellow image. I don't know what a transparent passport means. I know what a ? means.

I also don't think there is much, if any, distinction between the blue and green icons.  What is the difference?  The only thing I can guess is that green icons mean they have provided info on who runs the site

Comment 31

[Michael Monreal [:micmon]]

(In reply to comment #30)
> [read above]

Ian, Alex Faaborg explained to me that the intention behind those images was not to influence the final judgement of a user regarding a site but to encourage the user to stay alert, as one normally is in presence of a police man, even if you have nothing to hide. 

I can't say that I'm totally behind this (and Alex can probably explain much better) but in the end we should have the same concept for those icons on all platforms. Mozilla is aware of the negative feedback the windows icons already got... so let's wait how the feedback with beta 4 is and perhaps improve the images after that.

Comment 32

[Michael Monreal [:micmon]]

Attachment: Wrong icon #1

I just finished testing the latest nightly, great work!

Here's one thing that needs to be changed though: the extension notification area (when installing from a site that is not whitelisted for software installation) uses a scaled down icon, it should use the 16x16.

Comment 33

[Michael Monreal [:micmon]]

Attachment: Wrong icon #2

I actually don't know if this can be fixed or if the wrong icon ships with the extension, but have a look at the screenshot, the icon used is the ff2/win version during installation. It turns to the proper icon when installed, though.

(If you try installing this language pack, better remove it before quitting FF or things will break on the next start...)

Comment 34

[Alex Faaborg [:faaborg] (Firefox UX)]

Fantastic work everyone on getting all of these icons done well before the beta 4 freeze.

>Ian, Alex Faaborg explained to me that the intention behind those images was
>not to influence the final judgement of a user regarding a site but to
>encourage the user to stay alert

The problem we have had in previous releases is that the user makes a trust decision off of the presence of a padlock, but you can buy an SSL cert for some really low price like $8 now.  The lock was a metaphor for your connection to the site, about eavesdropping, but people were using it to mean if the site itself was "good" or not.  So with the identity icons we are trying to reshape the metaphors and thought process of the user around who they are talking to.  We don't want to just replace a lock with a customs official, and have users say "ok, he is blue so I will trust him."  In fact we wanted SSL to be blue because it doesn't have any connotations on the spectrum of good and evil (like red or green).

However, the feedback we have been getting recently is that the yellow version of the customs official is causing users to be concerned (for instance "why does ebay.com have a yellow warning icon?").  So we decided that what we should convey in this state is "no information" while we are currently  "warning, no information."  After beta 4 we would like to go back and modify the identity unknown icon to appear muted without any use of color, and a ghosted passport.

In terms of the use of a question mark, we need to localize to 40 languages and the customs official is a standardized international symbol which I'm reluctant to modify, so I think we can communicate what we need to only leveraging contrast and color.

Again, awesome job getting the icons landed well before late monday night :)

Comment 35

[Reed Loden [:reed]]

(In reply to comment #32)
> Created an attachment (id=305209) [details]
> Wrong icon #1
> 
> Here's one thing that needs to be changed though: the extension notification
> area (when installing from a site that is not whitelisted for software
> installation) uses a scaled down icon, it should use the 16x16.

Filed bug 419250 and submitted a patch.

Comment 36

[Reed Loden [:reed]]

(In reply to comment #33)
> Created an attachment (id=305210) [details]
> Wrong icon #2
> 
> I actually don't know if this can be fixed or if the wrong icon ships with the
> extension, but have a look at the screenshot, the icon used is the ff2/win
> version during installation. It turns to the proper icon when installed,
> though.

For future reference, you were using https://addons.mozilla.org/en-US/firefox/addon/4444 for testing. It looks like if an add-on doesn't provide a valid icon, AMO provides an icon for use when installing, which just happens to be this old icon. You should file a bug against AMO to use the Tango icon for Linux installs.

Comment 37

[u294409]

Do we need help Toolbar.png and Toolbar-small.png in classic.jar?
They are not used.

Comment 38

[Reed Loden [:reed]]

(In reply to comment #37)
> Do we need help Toolbar.png and Toolbar-small.png in classic.jar?
> They are not used.

I don't know where you're getting that, as I clearly see them being used.

http://mxr.mozilla.org/firefox/search?find=%2Fbrowser%2Fthemes%2Fgnomestripe%2F&string=Toolbar.png

http://mxr.mozilla.org/firefox/search?find=%2Fbrowser%2Fthemes%2Fgnomestripe%2F&string=Toolbar-small.png

Comment 39

[u294409]

Awww. I mean those two for HELP window... Sorry for a big mess.

Comment 40

[Reed Loden [:reed]]

(In reply to comment #39)
> Awww. I mean those two for HELP window... Sorry for a big mess.

Hmm, can you better explain what you mean? If I look at http://mxr.mozilla.org/firefox/source/toolkit/themes/gnomestripe/help/jar.mn, I only see the help.css being included...

Comment 41

[u294409]

So my Minefield doesn't remove unneeded files when updated.

Ignore.

Comment 42

[Michael Monreal [:micmon]]

(In reply to comment #41)
> So my Minefield doesn't remove unneeded files when updated.
> 
> Ignore.
> 

?

There is a bug for removing unneeded images. It will be done eventually, but this is not the scope of this bug.

Comment 43

[Reed Loden [:reed]]

(In reply to comment #6)
> Created an attachment (id=304996) [details]
> M3 drop-in replacements
> 
> Lots of icons... non of which should need any CSS change. Includes sets for
> both the addons and pageinfo headers and much more.

List of icons included in this zip:

addons:
get-addons.png
ghosted-error.png
ghosted-information.png
ghosted-question.png
ghosted-warning.png
locales.png
plugins.png
themes.png

history:
day.png

menu:
mail.png

places:
bookmarks-menu.png
bookmarks-toolbar.png

I'm not really sure where to put some of these in the tree, so insight into where exactly these are going to be used and how would be very helpful.

Comment 44

[Michael Monreal [:micmon]]

(In reply to comment #43)

> ghosted-*
Inline error etc notification for get-addons (as a background image). Do we want those to be combined on a single image?

> locales.png, plugins.png, themes.png
No idea how these small versions will be used

> day.png
Has been cut from the latest design, disregard.

> menu:
> mail.png
For use in the main menu and context menus ("Send link") but I suppose also elsewhere?

> bookmarks-menu.png
> bookmarks-toolbar.png
Special "folder" icons for the bookmarks menu and bookmarks toolbar folders in places.

Comment 45

[Lapo Calamandrei]

Attachment: package with updated plugins icons

As for Michael Monreal request, updated plugins icon using the "generic interlocking brick toy" metaphor.

Comment 46

[Michael Monreal [:micmon]]

Attachment: New plugin icons for checkin

Comment 47

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png,v  <--  viewButtons.png
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric.png,v  <--  pluginGeneric.png
new revision: 1.2; previous revision: 1.1
done

Comment 48

[Michael Monreal [:micmon]]

mail.png,
bookmarks-menu.png,
bookmarks-toolbar.png

Can be integrated here. Should we move the rest over to new bugs (they seem to require some code that is not yet in place)?

Comment 49

[Reed Loden [:reed]]

There's still more work to do here, but I'm going to resolve this for now.

Comment 50

[Michael Monreal [:micmon]]

Reed, what should we do about mail.png, bookmarks-menu.png and bookmarks-toolbar.png now? Are there any bugs open for these yet?

Comment 51

[u294409]

There's no mail button, so this could be removed, I think, but I can be wrong.

Comment 52

[Alex Faaborg [:faaborg] (Firefox UX)]

>Reed, what should we do about mail.png, bookmarks-menu.png and
>bookmarks-toolbar.png now? Are there any bugs open for these yet?

Place mail.png in /gnomestripe/browser/preferences/ (it should be used in the applications prefpane for mailto:)

bookmarks-menu.png and bookmarks-toolbar.png should go in /themes/gnomestripe/browser/places/

Comment 53

[Reed Loden [:reed]]

Comment on attachment 304998 [details]
M3 unused icons

Would like to land some of these...

Comment 54

[Michael Monreal [:micmon]]

Attachment: Updated viewButtons

Alex requested this updated viewButtons image: update icon have been changed to a 32x32 version of the "update available" emblem and installations will use the 32x32 download icon. Just commit this version as a drop in replacement.

Comment 55

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310807 [details]
Updated viewButtons

a=beltzner

Comment 56

[Reed Loden [:reed]]

Attachment: Addons mgr search patch - v2 (for check-in)

Fixed version of attachment 305171 [details] [diff] [review] for check-in.

Comment 57

[Reed Loden [:reed]]

Attachment: New searchIcons.png - v2 (for check-in)

Do we need to worry about RTL here?

Comment 58

[Reed Loden [:reed]]

Comment on attachment 305002 [details]
New ratings.png

monreal, we need a new ratings.png that's less blue. See http://mxr.mozilla.org/firefox/source/toolkit/themes/winstripe/mozapps/extensions/ratings.png and http://mxr.mozilla.org/firefox/source/toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png for ideas.

Comment 59

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png,v  <--  viewButtons.png
new revision: 1.3; previous revision: 1.2
done

Comment 60

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/places/bookmarksMenu.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/bookmarksMenu.png,v  <--  bookmarksMenu.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/places/bookmarksToolbar.png,v
done
Checking in browser/themes/gnomestripe/browser/places/bookmarksToolbar.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/bookmarksToolbar.png,v  <--  bookmarksToolbar.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/mail.png,v
done
Checking in browser/themes/gnomestripe/browser/preferences/mail.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/mail.png,v  <--  mail.png
initial revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.74; previous revision: 1.73
done

Comment 61

[Michael Monreal [:micmon]]

(In reply to comment #58)
> (From update of attachment 305002 [details])
> monreal, we need a new ratings.png that's less blue. See

Are the xp/vista stars really better? When faaborg reviewed our stars he said they were fine.

Comment 62

[Reed Loden [:reed]]

Considering bug 424028 went and really broke the add-ons manager search bar, I went ahead and landed the matching gnomestripe fixes for the bustage fix I checked-in for winstripe. The fix is just the two pending-approval patches.

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.12; previous revision: 1.11
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.20; previous revision: 1.19
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/searchIcons.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/searchIcons.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/searchIcons.png,v  <--  searchIcons.png
initial revision: 1.1
done

Comment 63

[Reed Loden [:reed]]

(In reply to comment #61)
> Are the xp/vista stars really better? When faaborg reviewed our stars he said
> they were fine.

I personally think the blue of the stars doesn't mix well with the blue highlight one gets when selecting an add-on. I'm not saying we need stars just like the ones XP/Vista use, but I do think we should change the color or something so that it isn't as hard to see.

Comment 64

[Ian Spence]

While we are on the topic of the stars, do they appear corrupt for anyone else?  In both my nightly build and the one I threw together to fix bug 419437, the stars are appearing corrupt/scrambled

Comment 65

[Alex Faaborg [:faaborg] (Firefox UX)]

>I personally think the blue of the stars doesn't mix well with the blue
>highlight one gets when selecting an add-on.

We need to make sure the stars look ok on a range of background colors, for instance, here are all of the colors that the XP and Vista stars are likely to appear on: https://bugzilla.mozilla.org/attachment.cgi?id=310592

Comment 66

[Reed Loden [:reed]]

(In reply to comment #44)
> > day.png
> Has been cut from the latest design, disregard.

It's back now as "calendar.png" for bug 425998! :)

Checking in browser/themes/gnomestripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.76; previous revision: 1.75
done
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/places/calendar.png,v
done
Checking in browser/themes/gnomestripe/browser/places/calendar.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/calendar.png,v  <--  calendar.png
initial revision: 1.1
done

Comment 67

[Reed Loden [:reed]]

Comment on attachment 304998 [details]
M3 unused icons

There are some more icons in this that need landing for other bugs recently filed.

Comment 68

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304998 [details]
M3 unused icons

a=beltzner assuming that they're only packaged if we use them

Comment 69

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/errorGhosted-64.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/errorGhosted-64.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/errorGhosted-64.png,v  <--  errorGhosted-64.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/informationGhosted-64.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/informationGhosted-64.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/informationGhosted-64.png,v  <--  informationGhosted-64.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/questionGhosted-64.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/questionGhosted-64.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/questionGhosted-64.png,v  <--  questionGhosted-64.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/warningGhosted-64.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/warningGhosted-64.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/warningGhosted-64.png,v  <--  warningGhosted-64.png
initial revision: 1.1
done

Comment 70

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.43; previous revision: 1.42
done