937251 - [Cost Control] Remove proxy

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

Once, all the dependent functionality is added, there will be no use of former API so the proxy can could be removed.

Comment 1

[Noemí Freire (:noemi)]

Removing 1.3? since it won't be a blocker but nice to have for v1.3

Comment 3

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Please, could you review the code?
Regards

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8345736 [details]
patch v1.0

Working nice. Thank you :mai!

Comment 5

[Marina Rodríguez [:mai]]

Master: eb7d58df7692b57bd471353755679b23441a90fb

Comment 6

[Noemí Freire (:noemi)]

Hi,

Bug 858017 is blocked by this bug since proxy is not supporting alarms (this support is implemented within Bug 858017).

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ to get into Tarako branch

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks

Comment 9

[yang.zhao]

(In reply to Joe Cheng [:jcheng] from comment #8)
> Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you
> completed the uplift, can you please set status-b2g-v1.3T to fixed? please
> let us know if you have problems with it. thanks

Hi,Joe
  Is there any way to verify this bug after merge it to 1.3t branch?

Comment 10

[yang.zhao]

hi,marina
 I met some error when trigger the travis-ci after pulling request .please see:
https://travis-ci.org/mozilla-b2g/gaia/builds/20657822

I'd like to konw whether these errors should be resolved or just ignore them?Thank you!

Comment 11

[Marina Rodríguez [:mai]]

Hi, 
The fails reported by the travis are not related with this patch. I thought travis is not working well.

* The test-agent job sends the following error: 
    No permission to use the keyboard API for http://system.gaiamobile.org:8080
    ✖ 1 of 6799 tests failed:
* The marionette job fails becauose of a contact test:
    70 passing (9m)
    16 pending
    1 failing

       1) Contacts > Details Merging 15 contacts: TypeError: Cannot read property '1' of null at Object.Contacts.l10n (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/marionette/lib/contacts.js:107:33)


IMHO, you must ignore the errors.
Regards.

Comment 12

[yang.zhao]

(In reply to marina rodríguez [:mai] from comment #11)
> Hi, 
> The fails reported by the travis are not related with this patch. I thought
> travis is not working well.
> 
> * The test-agent job sends the following error: 
>     No permission to use the keyboard API for
> http://system.gaiamobile.org:8080
>     ✖ 1 of 6799 tests failed:
> * The marionette job fails becauose of a contact test:
>     70 passing (9m)
>     16 pending
>     1 failing
> 
>        1) Contacts > Details Merging 15 contacts: TypeError: Cannot read
> property '1' of null at Object.Contacts.l10n
> (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/
> marionette/lib/contacts.js:107:33)
> 
> 
> IMHO, you must ignore the errors.
> Regards.

Thank you for your answer!And I'd like to know is there any way to verify this bug after merge this patch?

Comment 13

[Marina Rodríguez [:mai]]

The best way to test if all is correct is launched the costcontrol application, and check that you have traffic data info. This proxy was needed for the transition between version 1.0 to 2.0 of the Networkstats API, to deal with a problem when the app recovers the data samples by interface.

This proxy is not longer needed, besides only has implemented the methods to recover info, not to manage alrmas. For these reasons, we have to eliminate.

Regards

Comment 14

[yang.zhao]

https://github.com/mozilla-b2g/gaia/pull/17144/files

commitid:1248de807da29bc5c3ebc8e25f9042c49ee733ba

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

thanks, once the patch is merged to 1.3T branch, please change status-b2g-v1.3T to fixed