With the new Netowrk Statistics API, mindgap.js module is no longer required. It must be removed in order to fully unlock all the features provided by the new API.
Created attachment 832280 [details] proposal patch v1 Please, could you review my code? There is a pending issue: testing of the application with two different SIM cards
Comment on attachment 832280 [details] proposal patch v1 See some comments on GitHub. It's going well but I want to discuss some aspects. Provide your opinion if you don't share the point of view of any of the comments. When ready, ask for review again. Thank you :mai!
Comment on attachment 832280 [details] proposal patch v1 Updated the code keeping in mind your comments
Comment on attachment 832280 [details] proposal patch v1 Nice work with lots of improvements. I'm happy to see mindgap.js is gone! Please don't merge until bug 937041 is in Mozilla Central. Thank you :mai, a really good work! NOTE: I made a little name fix and change `availableNetworks()` into `getAvailableNetworks()` because this is the ultimate name for the method.
already in master. clear flag
This just broke the utility tray entirely. John - Can you back this out?
Please, John, before remove this, let's see if we can solve this by providing a simple patch. Jason, when the bug 928325 broke the utility tray and this was reported in bug 939110, it was not backed out. I am not asking for a special treatment, but note these kind of things happens. Let's find a solution before taking light decisions.
Hi. Root cause found. Our fault, backing out: d8b28cec6ef01c7b8e0440d5e4da033c486b0515 My apologies if the previous comment sounded rude. I only wanted to see what was more convenient: if a patch or another PR. Given the situation, it is better to make a backout: better to track one commit rather than two. :)
Created attachment 8336727 [details] v1.1
Comment on attachment 8336727 [details] v1.1 Added two harmless modifications in a couple of lines not affecting the behaviour but the code style. Thanks for the fix, :mai!
already in master v1.3. clear flag