937240 - [COST CONTROL] Remove the `mindgap.js` module and filtering operations of historical data.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

With the new Netowrk Statistics API, mindgap.js module is no longer required. It must be removed in order to fully unlock all the features provided by the new API.

Comment 1

[Marina Rodríguez [:mai]]

Attachment: proposal patch v1

Please, could you review my code?
There is a pending issue: testing of the application with two different SIM cards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 832280 [details]
proposal patch v1

See some comments on GitHub. It's going well but I want to discuss some aspects. Provide your opinion if you don't share the point of view of any of the comments.

When ready, ask for review again.

Thank you :mai!

Comment 3

[Marina Rodríguez [:mai]]

Comment on attachment 832280 [details]
proposal patch v1

Updated the code keeping in mind your comments

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 832280 [details]
proposal patch v1

Nice work with lots of improvements. I'm happy to see mindgap.js is gone!

Please don't merge until bug 937041 is in Mozilla Central.

Thank you :mai, a really good work!

NOTE: I made a little name fix and change `availableNetworks()` into `getAvailableNetworks()` because this is the ultimate name for the method.

Comment 5

[Salvador de la Puente González [:salva]]

Master: 445a9fb8deddd15e617f000ef208bddbedd28f0b

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

already in master. clear flag

Comment 8

[Jason Smith [:jsmith]]

This just broke the utility tray entirely.

John - Can you back this out?

Comment 9

[Salvador de la Puente González [:salva]]

Please, John, before remove this, let's see if we can solve this by providing a simple patch. Jason, when the bug 928325 broke the utility tray and this was reported in bug 939110, it was not backed out. I am not asking for a special treatment, but note these kind of things happens. Let's find a solution before taking light decisions.

Comment 10

[Salvador de la Puente González [:salva]]

Hi. Root cause found. Our fault, backing out:
d8b28cec6ef01c7b8e0440d5e4da033c486b0515

My apologies if the previous comment sounded rude. I only wanted to see what was more convenient: if a patch or another PR. Given the situation, it is better to make a backout: better to track one commit rather than two. :)

Comment 11

[Marina Rodríguez [:mai]]

Attachment: v1.1

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 8336727 [details]
v1.1

Added two harmless modifications in a couple of lines not affecting the behaviour but the code style.

Thanks for the fix, :mai!

Comment 13

[Salvador de la Puente González [:salva]]

Master: 84a0570132f6af235000f08ef02b6798cbfa2d0d

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

already in master v1.3. clear flag