1011129 - [Dolphin] Create Dolphin builds for 1.4

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jason Smith [:jsmith]]

We need to start generating builds for Dolphin on 1.4.

Comment 1

[Al Tsai [:atsai]]

There's no special rules to build Dolphin this time.
Here's the steps I used.

BRANCH=v1.4 ./config.sh dolphin
./build.sh kernelheader && ./build.sh

There's no need to assign ANDROIDFS_DIR for Dolphin devices.

Comment 2

[Chris AtLee [:catlee]]

Attachment: sources.xml

initial manifest for dolphin. needs landing on mozilla-b2g30_v1_4 as b2g/config/dolphin/sources.xml

Comment 3

[Chris AtLee [:catlee]]

Attachment: b2g bumper configs for dolphin; make it easier to get missing repos

I added some support in b2g_bumper.py to make it easier to get new devices up and running.

e.g.

 b2g_bumper.py -c b2g_bumper/1.4.py --massage-manifests --checkout-manifests --no-write --device dolphin

gave me the output needed to file bug 1014102 for missing git mirrors.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 8426527 [details] [diff] [review]
b2g bumper configs for dolphin; make it easier to get missing repos

I use self.add_failure() for this type of thing (detecting failure for later, but not fatal()ing yet), but this works too.

> +                self.info("needs sync? %s/%s -> %s/%s" % (orig_fetch_url, name, new_fetch_url, name))

Is self.info() the right level? I'd guess warning/error/critical, but since there's a fatal() afterwards, it's a matter of taste.

Comment 5

[Chris AtLee [:catlee]]

Attachment: sources.xml in patch form

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/123395cf1e6c

Comment 7

[Justin Wood (:Callek)]

Something here went live today

Comment 8

[Simone Bruno [:simone]]

Catlee provided to me some details related to this (and more generally to b2g builds - thanks catlee!), I think I now have all the info I need. I'll upload patches as soon as I have some green runs in my test env.

Comment 9

[Chris AtLee [:catlee]]

We're seeing a few build errors in staging:

12:55:13    ERROR -  hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp:246:27: error: 'FFOS_AUDIO_DEVICE_OUT_FM' was not declared in this scope
12:55:13     INFO -  hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp: In member function 'virtual void android_audio_legacy::AudioPolicyManagerBase::setForceUse(android_audio_legacy::AudioSystem::force_use, android_audio_legacy::AudioSystem::forced_config)':
12:55:13    ERROR -  hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp:546:39: error: 'FFOS_AUDIO_DEVICE_OUT_FM' was not declared in this scope
12:55:13    ERROR -  hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp:549:62: error: 'FFOS_AUDIO_FM_DEVICE_ADDRESS' was not declared in this scope
12:55:13    ERROR -  hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp:552:64: error: 'FFOS_AUDIO_FM_DEVICE_ADDRESS' was not declared in this scope

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

Can you './repo sync system/core' and then check again?
In the latest sourece the following 2 definitions are in "system/core/include/system/audio.h"

#define FFOS_AUDIO_FM_DEVICE_ADDRESS "0"
#define FFOS_AUDIO_DEVICE_OUT_FM     0X80000


Partner fixed FM issue in the following commit/repo.

system/core
commit dfc314f61b701c4a710b989e9b21300d122dbbc9
Author: cihong.liu <[e-mail]>
Date:   Tue May 27 15:47:46 2014 +0800

hardware/libhardware_legacy
commit f19a0f6deb55d1040edbf68ddd6064c14515713d
Author: cihong.liu <[e-mail]>
Date:   Tue May 27 15:40:45 2014 +0800

Comment 11

[Chris AtLee [:catlee]]

Looks like it's not getting picked up in our mirror: 
http://git.mozilla.org/?p=external/sprd-aosp/platform/system/core.git;a=shortlog;h=refs/heads/sprdb2g_gonk4.4

Comment 12

[Chris AtLee [:catlee]]

Attachment: buildbot-configs for dolphin on b2g30-v1.4

Comment 13

[Chris AtLee [:catlee]]

Attachment: in-tree config.json for dolphin

still don't have a successful build yet, but this has been what I've used so far

Comment 14

[Simone Bruno [:simone]]

Thanks catlee - once again you covered for me being toooo slow... :-/

Comment 15

[Chris AtLee [:catlee]]

builds look good now in staging. will deploy tomorrow

Comment 16

[Chris Cooper [:coop] (he/him)]

Merged to production and deployed.

Comment 17

[Kai-Zhen Li [:seinlin][:kli]]

Chris, 

I'd like to to confirm one thing. Dolphin need to be built kernelheader first as tarako.
But I am not sure if dophin build is done as the same as tarako.
$./build.sh kernelheader && ./build.sh

As I saw there is an error in bug 1022078, I think build kernelheader first can prevent this error.

Comment 18

[Chris AtLee [:catlee]]

If that's the case, then can you add "build_targets": ["kernelheader", ""], to https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/file/51fed8981e43/b2g/config/dolphin/config.json#l6, like we have here: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/file/default/b2g/config/tarako/config.json#l7

Comment 19

[Kai-Zhen Li [:seinlin][:kli]]

Chris, Thanks!

Comment 20

[Chris AtLee [:catlee]]

Looks like builds are green now.

Comment 21

[William Hsu [:whsu]]

Two bugs still need your help.
 - [Bug 1027554] dolphin full image size is incorrect in pvt build
 - [Bug 1032066] [FxOS][V1.4][Dolphin] Default user of engineering build isn't "root"

Thanks! Have a nice day!