1023506 - [Flame] flicking through images causes screen to go dark between the images

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect)

Description

[No-Jun Park [:njpark]]

STR:
-Open Gallery (with several pictures already stored) 
- Hold the phone horizontally, and flick through images 
Expected:
image flows normally
Actual:
screen goes dark momentarily when a new image is called.

Video link:
https://www.dropbox.com/s/0iek9b11himf054/VID_20140610_153359.mp4

Version Info (in master branch, after 2.0 branch):
Gaia      f42ebc93554979501d3ac52bcf9e69cb4b310a4f
Gecko     https://hg.mozilla.org/mozilla-central/rev/9dc0ffca10f4
BuildID   20140610040208
Version   33.0a1
ro.build.version.incremental=104
ro.build.date=Fri Jun  6 17:35:09 CST 2014

Comment 1

[No-Jun Park [:njpark]]

This also happens when the video time slider is moved to earlier in time

Also happens in 2.0 Branch:
Gaia      a0f9f1f41a436daad8a249ce85df80a81a5ba2d5
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/0c0effd600c4
BuildID   20140611091242
Version   32.0a2
ro.build.version.incremental=eng.cltbld.20140610.032245
ro.build.date=Tue Jun 10 03:22:54 EDT 2014

Comment 2

[Hema Koka [:hema]]

Also happening on portrait (when you hold phone vertically too) from yesterdays build (6/10).

Comment 3

[Hema Koka [:hema]]

is this is a regression issue? adding qawanted

Comment 4

[Marcia Knous [:marcia]]

Can someone please check this on 1.3 to see if it happens there as well?

Comment 5

[Marcia Knous [:marcia]]

No-Jun: Which base image were you using for Flame?

Comment 6

[Marcia Knous [:marcia]]

Using Flame:

Gaia   a0f9f1f41a436daad8a249ce85df80a81a5ba2d5
SourceStamp 0c0effd600c4
BuildID 20140611091244
Version 32.0a2
Base Image: 121

I don't see the screen going black between pictures using the latest base image.

Comment 7

[No-Jun Park [:njpark]]

(In reply to Marcia Knous [:marcia - use needinfo] from comment #5)
> No-Jun: Which base image were you using for Flame?

I used the latest base image  v121-2, and one before, and it was reproducible on both.

Comment 8

[No-Jun Park [:njpark]]

I just tested again with latest 2.0 (below), and the issue is no longer reproducible with the same STR.

Gaia      6aa07ea10420bd77f93d7415b5e34d89acc47a7e
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c83fdcf0b735
BuildID   20140611160205
Version   32.0a2
ro.build.version.incremental=eng.cltbld.20140610.032245
ro.build.date=Tue Jun 10 03:22:54 EDT 2014

Comment 9

[demerick]

This issue does not reproduce on Flame 1.3

Device: Flame 1.3
Build ID: 20140520094859
Gaia: a73235d23685e9898f40647cebd83b3fcbfd0117
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3) 
Firmware Version: v10G-2

User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0

The screen does not go dark while holding the phone horizontally and swiping through each image in the gallery.

Comment 10

[Joshua Mitchell (Inactive)]

Based on Comment 8 this issue may no longer be reproducing

QA-Wanted to check on the latest Flame build using base image v121-2 (don't forget your new memory throttle process after basing).

Comment 11

[pete siphantong [:Petes]]

Just in case, here are the variables for the base image v121-2 for the following devices that the issue does not occur on: 

Environmental Variables:
Device: Flame 2.0
Build ID: 20140613000203
Gaia: a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko: 8897bc43f59b
Version: 32.0a2 (2.0) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame Master
Build ID: 20140612040203
Gaia: 41db6954a67efc55016744bc8f6591ae9e07a285
Gecko: 9e8e3e903484
Version: 33.0a1 (Master) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.4
Build ID: 20140613000202
Gaia: 1dae62556e642b0b2e08689e35e24e56daa8c79b
Gecko: 30224c7f5e58
Version: 30.0 (1.4) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140612160201
Gaia: a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko: 0293597de41f
Version: 32.0a2 (2.0) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.3
Build ID: 20140610200025
Gaia: e106a3f4a14eb8d4e10348efac7ae6dea2c24657
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

no black screen, screen does not go dark momentarily when a new image is called

Comment 12

[No-Jun Park [:njpark]]

This happens again in 2.1 (Master branch) and 2.0 branch
Gaia      ccd70903544486bea04e85d8a4aacf63f1de2a72
Gecko     https://hg.mozilla.org/mozilla-central/rev/bdac18bd6c74
BuildID   20140620040204
Version   33.0a1
ro.build.version.incremental=eng.cltbld.20140610.032245
ro.build.date=Tue Jun 10 03:22:54 EDT 2014

Gaia      c5dd47e3f9e18872961946735fdbc071a1656ac9
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/71b1b4b0850c
BuildID   20140620000202
Version   32.0a2
ro.build.version.incremental=eng.cltbld.20140610.032245
ro.build.date=Tue Jun 10 03:22:54 EDT 2014

Comment 13

[Jason Smith [:jsmith]]

QA Wanted - Can someone else confirm what No-Jun is seeing?

Comment 14

[Duane Dixon [:ddixon]]

I reconfirmed the findings listed in comment 12 with a Buri and Flame device on the latest 2.1 Master builds. 

Latest base image was installed on both devices, accordingly. 

This bug seems to be a result of a poor transition between Gallery images (in portrait and landscape modes). 

At times, the UI banner at the bottome of the screen will dissappear completely when swipping quickly and slowly between images.   

Environmental Variables:

Device: Flame Master
Build ID: 20140620094247
Gaia: bd5065ced020014df5fd45259fba1ac32d65673b
Gecko: 892d7a8eda45
Version: 33.0a1 (Master)
Firmware Version: v121-2

Device: Buri Master
Build ID: 20140620094247
Gaia: bd5065ced020014df5fd45259fba1ac32d65673b
Gecko: 892d7a8eda45
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg

Comment 15

[Joshua Mitchell (Inactive)]

2.0 branch testing is coming, I asked Dixon to post those first for timeliness.

Comment 16

[Duane Dixon [:ddixon]]

Confirming issue DOES occur in latest 2.0 Flame build and latest 2.0 Buri build.

Device: Flame 2.0
Build ID: 20140620101046
Gaia: 27f07f479e696af304d52e5fdd654317baa8c17d
Gecko: 606653d5d01d
Version: 32.0a2 (2.0)
Firmware Version: v121-2

Device: Buri 2.0
Build ID: 20140620101046
Gaia: 27f07f479e696af304d52e5fdd654317baa8c17d
Gecko: 606653d5d01d
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg

Comment 17

[Jason Smith [:jsmith]]

Josh - If this is now reproducing & wasn't reproducing on 1.4, then the regression keywords should be flagged.

Comment 18

[Hema Koka [:hema]]

Blocking because of regression from 1.4 (based on comment 16). 

Diego, could you please take a look and see whats going on?

Thanks
Hema

Comment 19

[Diego Marcos [:dmarcos]]

I can reproduce the problem but intermittently. See attached video. I reproduce both in landscape and portrait orientations.

Comment 20

[Diego Marcos [:dmarcos]]

Attachment: galleryFlicker.MOV

Comment 21

[Diego Marcos [:dmarcos]]

Tested on:

Gaia      41cc1de26e4edbe12add0009cdc0bd292f2e94fe
Gecko     https://hg.mozilla.org/mozilla-central/rev/31de1a84b27f
BuildID   20140623095855
Version   33.0a1

Comment 22

[Lionel Mauritson]

B2G Inbound Regression Window

Last Working
Device: Flame Master
BuildID: 20140609154428
Gaia: d64172b2df8b406183e4d6de0cab2494c6dcf211
Gecko: 7fb68b04c53c
Version: 33.0a1 (Master) 
Firmware Version: v122

First Broken
Device: Flame Master
BuildID: 20140609155654
Gaia: 901646a3279c66daa7621bebb62641779d8ae22c
Gecko: 58cf55af0ec1
Version: 33.0a1 (Master) 
Firmware Version: v122

First_Broken_Gaia_Last_Working_Gecko: Reproduces
Gaia: 901646a3279c66daa7621bebb62641779d8ae22c
Gecko: 7fb68b04c53c

Last_Working_Gaia_First_Broken_Gecko: Does not reproduce
Gaia: d64172b2df8b406183e4d6de0cab2494c6dcf211
Gecko: 58cf55af0ec1

Gaia Pushlog
https://github.com/mozilla-b2g/gaia/compare/d64172b2df8b406183e4d6de0cab2494c6dcf211...901646a3279c66daa7621bebb62641779d8ae22c

Comment 23

[Jason Smith [:jsmith]]

Broken by bug 1020045.

Comment 24

[Diego Marcos [:dmarcos]]

Good job Lionel! Confirmed that setting apz.overscroll.enabled to false fixes the issue (attached PR).

Comment 25

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 26

[Diego Marcos [:dmarcos]]

We need people to system front end to look into this

Comment 27

[Jason Smith [:jsmith]]

(In reply to Diego Marcos [:dmarcos] from comment #26)
> We need people to system front end to look into this

Are you sure? Overscroll is technically an APZC feature, managed by Milan.

Milan - Where would a bug like this need to be fixed? Gecko or the window manager?

Comment 28

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Diego Marcos [:dmarcos] from comment #24)
> Good job Lionel! Confirmed that setting apz.overscroll.enabled to false
> fixes the issue (attached PR).

Unexpected, but we could be mistaking it for the overscroll, I guess.  Nice find.

Comment 29

[Kartikaya Gupta (email:[e-mail])]

It looks like what's happening here is that while you're viewing a gallery image, the gallery is still underneath and scrollable. By scrolling vertically on the image currently being viewed, you can scroll the gallery underneath (you can see this if you close the image view and go back to the gallery). When the gallery goes into overscroll the screen blacks.

So one problem is that the gallery underneath is scrolling at all. This is along the same vein as bug 1021413 except as far as I can tell there's no opacity issue here. Might just be bad layerization or something.

The second problem is that instead of displaying the overscroll effect the screen blacks out. Not yet sure why that's happening.

Comment 30

[Kartikaya Gupta (email:[e-mail])]

The second problem is because the layer that's scrolling (i.e. the ContainerLayerComposite corresponding to the gallery underneath) is a scroll info layer and has no children. Therefore, after painting the background color at [1] there are no children to paint on top of it, and so we just get black.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/composite/ContainerLayerComposite.cpp?rev=ae6f7d5a01b3#347

Comment 31

[Kartikaya Gupta (email:[e-mail])]

Attachment: Don't fill background for scrollinfo layers

r? to matt since BenWa is (in theory) away at the moment.

Comment 32

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/b2g-inbound/rev/2186f79e926c

Comment 33

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2186f79e926c

Comment 34

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6d261c1cbe25

Comment 37

[Sue]

Attachment: video of Flame 2.1

Hi Mike,
Could you help with it, thanks.

This issue has been verified unsuccessfully on Flame v2.1
STR:
1. Launch Gallery app.
2. Hold the phone horizontally, and flick through images
**There is a black area at left/right when you slide left/right to view images.
Found time:14:29
See attachment: Flame 2.1.MP4 and logcat_1429.txt
Reproducing rate: 5/5
Flame 2.1 versions:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880

This issue has been verified successfully on Flame v2.0
See attachment: Flame 2.0.MP4
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/2d0860bd0225
Build-ID        20141209000202
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141209.032456
FW-Date         Tue Dec  9 03:25:13 EST 2014
Bootloader      L1TC00011880

Comment 38

[Sue]

Attachment: logcat of Flame 2.1

Comment 39

[Sue]

Attachment: video of Flame 2.0

Comment 40

[Mike Lien[:mlien]]

Verified again with v2.1, this black area is due to the rendering algorithm and performance.
The original problem is while flicking there has a all black screen and it cannot be reproduced with today's build

Gaia-Rev        c226db212db4d824c09617cd6dc407b2d4258d9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/cf8bebfa4703
Build-ID        20141209170126
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141209.212104
FW-Date         Tue Dec  9 21:21:15 EST 2014
Bootloader      L1TC10011880