Closed
Bug 1028144
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of MediaDecoderReader
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: bjacob, Assigned: kinetik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
8.44 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist. One of them is: MediaDecoderReader
Flags: needinfo?(cajbir.bugzilla)
|
||
Comment 1•10 years ago
|
||
Yes, MediaDecoderReader's dtor can probably be protected.
|
||
Comment 2•10 years ago
|
||
Concur with Chris. Feel free to clear the needinfo next time you answer something requested of me Chris.
|
|
||
Updated•10 years ago
|
Flags: needinfo?(cajbir.bugzilla)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8444174 -
Flags: review?(cpearce)
|
|
||
Updated•10 years ago
|
Attachment #8444174 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fff907d7b05
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6fff907d7b05
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•