Closed Bug 1028748 Opened 6 years ago Closed 6 years ago

Fix ownership of SubBufferDecoder readers

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1028144

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Readers were made refcounted in bug 979104, but SubBufferDecoder still tries to use an nsAutoPtr to hang on to its reader.

This probably fixes bug 1028742, bug 1028642, and bug 1025770.
Attachment #8444169 - Flags: review?(cajbir.bugzilla)
If MediaDecoderReader wasn't whitelisted (bug 1028144), this would've been caught as a compile error.
Comment on attachment 8444169 [details] [diff] [review]
SubBufferDecoder needs to own its reader with an nsRefPtr.

Er, this doesn't build.  New patch shortly.
Attachment #8444169 - Flags: review?(cajbir.bugzilla)
Easier to fix as part of bug 1028144.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1028144
You need to log in before you can comment on or make changes to this bug.