1062998 - [FTE] SIM signal statusbar icons should appear on SIM Manager screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

According to spec [1], these icons should appear on the SIM Manager screen, but currently they do not.

1.) https://bugzilla.mozilla.org/attachment.cgi?id=8484310

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] update icons when showing SIM manager

Alive for the system parts, Francisco for the FTU.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8486895 [details] [review]
[Gaia PR] update icons when showing SIM manager

Adding Sam as the new owner of FTU.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8486895 [details] [review]
[Gaia PR] update icons when showing SIM manager

If you step through the FTU with data *disabled*, the connectivity icons do not show up. In the debugger I can see the individual .sb-icon elements for each SIM being correctly un-hidden, but the #statusbar-connections container is remains hidden so we dont see them. 

Only when you toggle on "enable data" on the Cellular Data screen do the signal status icons appear. 

Also cancelling francisco's r?

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

I just did a rebase, and it seems to work for me :/ There have been a bunch of changes to signal icons since writing this patch, and even since Sam's review yesterday.

Sam, could you check again? If it doesn't work, do you see an errors in logcat? Are both your SIMs pin-locked, or not?

Comment 5

[Sam Foster [:sfoster] (he/him)]

I've got one functional AT&T SIM and another expired pre-paid T-Mobile sim in my Flame. Initially seeing 1 set of connectivity bars in the status bar with this patch. I also see these errors in logcat: 
E/GeckoConsole( 3594): [JavaScript Error: "TypeError: roaming is undefined" {file: "app://system.gaiamobile.org/js/statusbar.js" line: 1384}]
E/GeckoConsole( 3965): Content JS ERROR at app://ftu.gaiamobile.org/js/sim_manager.js:42 in showRetryCount/request.onerror: Could not fetch CardLockRetryCount RequestNotSupported

Just now I hit 'back' to return to the languages screen and now I see the 2nd set of bars with the x on them. 
I see the roaming is undefined error again.

Comment 6

[Sam Foster [:sfoster] (he/him)]

> Sam, could you check again? If it doesn't work, do you see an errors in
> logcat? Are both your SIMs pin-locked, or not?

The primary SIM is pin-locked, the other is not.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Sam Foster [:sfoster] from comment #5)
> I've got one functional AT&T SIM and another expired pre-paid T-Mobile sim
> in my Flame. Initially seeing 1 set of connectivity bars in the status bar
> with this patch. I also see these errors in logcat: 
> E/GeckoConsole( 3594): [JavaScript Error: "TypeError: roaming is undefined"
> {file: "app://system.gaiamobile.org/js/statusbar.js" line: 1384}]

Ah yes, that's bug 1066557. It's weird because I didn't seem to run into this with only PIN 2 locked. But as soon as I locked only PIN 1, this issue surfaced. The error is preventing the icon update logic from finishing. Good catch!

> E/GeckoConsole( 3965): Content JS ERROR at
> app://ftu.gaiamobile.org/js/sim_manager.js:42 in
> showRetryCount/request.onerror: Could not fetch CardLockRetryCount
> RequestNotSupported

That's bug 974606, and besides degraded UX is a harmless error.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8486895 [details] [review]
[Gaia PR] update icons when showing SIM manager

Ok, I've rebased against master now that bug 1066557 has landed. I've also simplified the IAC logic and add connection change listeners earlier. We actually don't need to make any changes to the FTU anymore, but since you found the problem earlier I think you are still good to do the final review Sam. I believe everything is in working order now :)

Comment 9

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8486895 [details] [review]
[Gaia PR] update icons when showing SIM manager

A couple nits/notes in the PR. This worked great for me straight out of the box: as soon as I was passed the language FTU screen, I got the pin lock prompt for sim1. Meanwhile sim2 (unlocked) already had its connection icon. Once I entered the pin for sim1 it too showed up in the status bar.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/62605314a2d726652ba2936435f53a8233377763

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8486895 [details] [review]
[Gaia PR] update icons when showing SIM manager

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 
bug 1035250


[User impact] if declined:
The user will not see the connectivity icons in the statusbar until after the "Enable Data" step of the FTU. This can be confusing to users (especially with dual sim), since they have alread unlocked their sims and are receiving signal at that point.

[Testing completed]:
Updated unit tests. Tested on device with single and dual sims, with locking of both sims.

[Risk to taking this patch] (and alternatives if risky):
The way the statusbar displays icons during the FTU (which is a Tako requirement) is affected by this patch. The risk is in the FTU flow, but the bad UX without this patch outweighs the risk in my opinion.

[String changes made]: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/98a0e660ae58227049d6495fe4cfa74d9bda33ba

Comment 14

[Coler]

This issue has been verified successfully on Flame2.1&2.2.
Reproducing rate: 0/5
See attachment: Verify_Flame_FTE.png

Flame2.1 build version:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0

Flame2.2 build version:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141203040207
Version         37.0a1

Comment 15

[Coler]

Attachment: Verify_Flame_FTE.png