1045591 - Version 31 does not respond to HTML 5 audio - Please visit www.mapetiteradio.com - audio stream does not work anymore - was working perfectly in version 30

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Alain Gariépy]

Version 31 does not respond to HTML 5 audio - Please visit www.mapetiteradio.com - audio streams does not work anymore - was working perfectly in version 30.

All others navigarors works fine with our website.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: Regressed by Bug 984698 

Regression window
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8510052b2313
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140320152510
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e076f1fb825b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140320154837
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8510052b2313&tochange=e076f1fb825b

Regressed by:
e076f1fb825b	Chris Pearce — Bug 984698 - Reduce the amount of audio prerolled when we are not also decoding video in the same file. r=padenot

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: simplified test case

The simplified test case doesn't auto play

Comment 4

[Jean-Yves Avenard [:jya]]

(In reply to Alice0775 White from comment #1)
> Regressed by:
> e076f1fb825b	Chris Pearce — Bug 984698 - Reduce the amount of audio
> prerolled when we are not also decoding video in the same file. r=padenot

there is no way this commit has any effect on autostart with audio-only stream

Comment 5

[Alice0775 White]

(In reply to Jean-Yves Avenard [:jya] from comment #4)
> (In reply to Alice0775 White from comment #1)
> > Regressed by:
> > e076f1fb825b	Chris Pearce — Bug 984698 - Reduce the amount of audio
> > prerolled when we are not also decoding video in the same file. r=padenot
> 
> there is no way this commit has any effect on autostart with audio-only
> stream


Download win32 build and load the attached simplified test case.

Last Good build
http://inbound-archive.pub.build.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1395354310/
Bad build
http://inbound-archive.pub.build.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1395355717/

You can easily check that rebgrssion range is CORRECT.
(these archived build will be deleted within 25 days)

Comment 6

[Matthew Gregan [:kinetik]]

(In reply to Jean-Yves Avenard [:jya] from comment #4)
> (In reply to Alice0775 White from comment #1)
> > Regressed by:
> > e076f1fb825b	Chris Pearce — Bug 984698 - Reduce the amount of audio
> > prerolled when we are not also decoding video in the same file. r=padenot
> 
> there is no way this commit has any effect on autostart with audio-only
> stream

Look at MediaDecoderStateMachine::HasFutureAudio().

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Fix media element's autoplay for audio-only stream

fix autoplay for audio only stream

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8474406 [details] [diff] [review]
Fix media element's autoplay for audio-only stream

Review of attachment 8474406 [details] [diff] [review]:
-----------------------------------------------------------------

OMG lol sux.

Comment 9

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=abd11ec76442

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cfde660c0e8

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Jean-Yves, can we get an uplift request for aurora & beta? Thanks

Comment 12

[Jean-Yves Avenard [:jya]]

Comment on attachment 8474406 [details] [diff] [review]
Fix media element's autoplay for audio-only stream

Approval Request Comment
[Feature/regressing bug #]:984698 . Bug is only triggered more often following 984698
[User impact if declined]:Audio playback not starting. Site's owner recommendation being to use IE/Chrome
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Can't think of any
[String/UUID change made/needed]: none

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Jean-Yves Avenard [:jya] from comment #12)
> Comment on attachment 8474406 [details] [diff] [review]
> Fix media element's autoplay for audio-only stream
> 
> Approval Request Comment
> [Feature/regressing bug #]:984698 . Bug is only triggered more often
> following 984698
> [User impact if declined]:Audio playback not starting. Site's owner
> recommendation being to use IE/Chrome
> [Describe test coverage new/current, TBPL]: on m-c
> [Risks and why]: Can't think of any
> [String/UUID change made/needed]: none

This looks safe enough. Is there any reason not to take this on beta? If not, let's get this in today for beta8.

Comment 14

[Jean-Yves Avenard [:jya]]

I only requested approval-mozilla-aurora, following instructions there:
https://wiki.mozilla.org/Release_Management/Uplift_rules#Aurora_Uplift_.28approval-mozilla-aurora.29

"Must be landed on mozilla-central as well as mozilla-aurora"

can certainly do beta too

Comment 15

[Jean-Yves Avenard [:jya]]

Comment on attachment 8474406 [details] [diff] [review]
Fix media element's autoplay for audio-only stream

Approval Request Comment
[Feature/regressing bug #]:984698 . Bug is only triggered more often following 984698
[User impact if declined]:Audio playback not starting. Site's owner recommendation being to use IE/Chrome
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Can't think of any
[String/UUID change made/needed]: none

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8474406 [details] [diff] [review]
Fix media element's autoplay for audio-only stream

I'm approving this small patch for beta before landing on m-c in order to make beta8.

For future, it is fine to request aurora and beta uplift at the same time.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/392aca6fddc2
https://hg.mozilla.org/releases/mozilla-beta/rev/f595bdcdbd1e

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cfde660c0e8

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/f595bdcdbd1e

Comment 20

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF32.0b8
Build Id: 20140818191513
OS: Win 7 x64, Mac Os X 10.10, Ubuntu 14.04 x64

Comment 21

[Alain Gariépy]

Hi to all of you,

Thanks, the bugs with HTML 5 audio stream seems to be resolved and fixed in version 33 Beta. It seems very stable.

Version 32, still crash after a while when zapping radio stations.

Please check : http://mapetiteradio.com

Note : all other navigators were and still handle properly our system. So we made no changes to our code.

Comment 22

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Thank you Alain! I'm marking this as Verified on Firefox 33 based on the previous comment.

Comment 23

[Alain Gariépy]

Hi again,

I was too much enthusiast. It did crashed again in version 33 Beta. Autoplay works, but when zapping radio stations, it crash.

Sorry.

Best regards,

Comment 24

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Alain it sounds like this may be another issue, since initially this was about the audio stream not working at all, while now it seems to work but with intermittent crashes. I think you should log a separate bug for this.

If I'm mistaking and this is the same issue as originally reported then you can leave it this way.

Comment 25

[Alain Gariépy]

Hi Florin,

You are not mistaking, but it was one of the issue that start happening with version 31.

Audio did not work - autostart did not work - Firefox crashed 

Now here is the situation with version 33 Beta :

Audio works (resolved) - autostart works (resolved) - Firefox crash (not solved) when navigating between radio stations. If I stay on the same station (same page - same player), it won't crash.

So, your decision, if you want me to open another big.

Best regards,

Comment 26

[Jean-Yves Avenard [:jya]]

(In reply to Florin Mezei, QA (:FlorinMezei) [on vacation - Sep 8-15 ] from comment #24)
> Alain it sounds like this may be another issue, since initially this was
> about the audio stream not working at all, while now it seems to work but
> with intermittent crashes. I think you should log a separate bug for this.

It doesn't appear to me to be the same issue (which was about sound not starting).
A new bug would be better IMHO.

Comment 27

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, I reported this crash in bug 1067551 and will re-close this bug. Alain I asked in the new bug for crash signatures if you can provide them!  Thanks.

Comment 28

[Lukas Blakk [:lsblakk] use ?needinfo]

This does not meet ESR landing criteria.