1056178 - [B2G][Dialer][Call Screen] Notification Bar icons are drawn on screen twice while in a call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-Call_Notifications.txt

Description:
Notification Bar icons (Clock, Battery, WiFi, SIM, etc.) are displayed twice when the user is in the call screen.  Discrepancies in icon priority between the call screen and the homescreen can cause icons to have different placements, leading to icon overlap.

Bug #1052333 greatly exacerbates this issue.

Repro Steps:
1) Update a Flame to 20140820040203
2) Connect the device to a WiFi network
3) Make or receive a call
4) Note the Notification Bar icons displayed at the top of the screen.


Actual:
Notification Bar icons are displayed twice.


Expected:
Notification Bar icons are only displayed once.

Environmental Variables:
Device: Flame Master
Build ID: 20140820040203
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Note: I am unsure if this occurs on 2.0, because there don't appear to be any differences in icon order and priority between the Call Screen and the Homescreen.

Keywords: Notification Bar, Icon, Overlap, Paint, Redraw, Call Screen, Dialer


Repro frequency: 100%
See attached: screenshot, logcat

Comment 1

[Martin Shuman [:Marty]]

Attachment: Notification_Icon_Call_Screenshot.png

Comment 2

[Anthony Ricaud (:rik)]

We don't display those icons in the callscreen app so it's not a Dialer issue.

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Bad visual bug during a common normal user path (receiving a call)

Comment 4

[Gregor Wagner [:gwagner]]

Guillaume, Etienne, any idea where this comes from?

Comment 5

[Guillaume Marty [:gmarty]]

It looks like both minimised and maximised status bars are displayed at the same time. I'll have a look at the CSS.

Comment 6

[Etienne Segonzac (:etienne)]

Clearing since Guillaume in on it and we're talking on IRC.

Comment 7

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Just a CSS change.

Comment 8

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 9

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Jason Smith [:jsmith] from comment #8)
> QA Wanted for branch checks.

This issue is reproducible on Flame 2.1 and Open C 2.1. Icons on notification bar overlap during a call.

Device: Flame
BuildID: 20140822010750
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: 0b9dd32d1e16
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Open_C
BuildID: 20140822010750
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: 0b9dd32d1e16
Version: 34.0a1 (2.1 Master)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

---------

This issue is NOT reproducible on Flame 2.0. Icons on notification bar stay intact during a call.

Device: Flame
BuildID: 20140822100753
Gaia: 06edd086387c2150017b549e6318a61cd7e4fd02
Gecko: d946233724d5
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 10

[Joshua Mitchell (Inactive)]

comment 6.5 and comment 7 indicate the cause is already known and a fix is in the pipeline - not adding regression window at this time.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8477429 [details] [review]
Github PR

Looks good but can you move this rule to app_titlebar.css in order to not spread the special cases too much ?

Comment 12

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/69f1d9e0d77b8adac1cf6193b59f8b6c4848abe5

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: blocking for regression and correct flag.

Comment 17

[Fred Muyumba [:FredM]]

The issue is verified fixed on Flame 2.2 Master  KK (319mb) (Full Flash) and Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: While on a call, Notification Bar icons do NOT appear on screen twice