1075389 - [LockScreen] With passcode, slide to secure camera would not restore the slider

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

STR:

0. With passcode enabled and lock the screen
1. Unlocking to secure camera with the slider
2. Press home button to kill the secure camera app

Expected:

The slider would restore after the app gone.

Actual:

The slider not restores itself.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted to get a regression window for this issue.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1062549 seems to bee the cause of this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20140924025256
Gaia: 8756efc2d509f85d4ae8af6ff57d9a7ac93952a3
Gecko: f2f8eda63327
Version: 35.0a1 (2.2) 
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20140924042257
Gaia: 5b44b5de8a1ba4361c02bd9a307f3a38389b8ad3
Gecko: 8c626ebd4cd7
Version: 35.0a1 (2.2) 
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 8756efc2d509f85d4ae8af6ff57d9a7ac93952a3
Gecko: 8c626ebd4cd7

First Broken gaia / Last Working gekko - Issue DOES occur
Gaia: 5b44b5de8a1ba4361c02bd9a307f3a38389b8ad3
Gecko: f2f8eda63327

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/8756efc2d509f85d4ae8af6ff57d9a7ac93952a3...5b44b5de8a1ba4361c02bd9a307f3a38389b8ad3

Comment 4

[Joshua Mitchell (Inactive)]

Bug 1062549 seems to bee the cause of this issue - can you take a look Tim?

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Greg is already on it. Thanks!

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

1. Add SlideRestore state to transfer to it and then to the SlideShow, to prevent transfer-to-self loop, which may bring more risks before we refactor the states.

2. I also fix 4 unit tests and related conditions that should be failed before this patch. I don't know what's wrong with that, but they passed daily Gij tests without any reasons. And I now encounter the 'ought to be failed' errors in this patch, so I fixed them.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Gaia-Try is green:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=65b14300bd3b

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/2e0393db30ebc1b7fc7feee5841c108940d1234f

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Blocking 2.2+ for all fixed regressions.

Comment 12

[[:RJ]]

issue is veryified fixed on 2.2 flame 

On return to homescreen, slider is restorted 

Flame 2.2
Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141121040204
Gaia: 25388c6bce932657ebf93adedf31881bfaf88c15
Gecko: 3366c0fcf9c2
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0