Closed
Bug 1082457
Opened 10 years ago
Closed 10 years ago
Add integration tests for all the statusbar icons color use cases
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: apastor, Assigned: apastor)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Meta bug for tracking the addition of integration tests for the statusbar color issues
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → apastor
|
|
Assignee | |
Comment 1•10 years ago
|
||
Aus, could you please verify this covers both 1074043 and 1081346 ? (I'm not sure if canceling the activity is enough for 1074043)
Attachment #8504653 -
Flags: feedback?(aus)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8504653 -
Flags: review?(mhenretty)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8504653 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25130
That should be enough in terms of covering activities. Having it dismiss is enough (it will terminate shortly after that, which triggers the correct call to setAppearance).
Attachment #8504653 -
Flags: feedback?(aus) → feedback+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8504653 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25130
Changing, as Micahel is out this morning
Attachment #8504653 -
Flags: review?(mhenretty) → review?(kgrandon)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8504653 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25130
Looks good, would like to see the tests split out a bit more though. Left a comment on github. Thanks!
Attachment #8504653 -
Flags: review?(kgrandon) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 6•10 years ago
|
||
What do you guys think about uplifting this? We still are fixing bugs in 2.1, and probably will be for a little while. It would be nice to have the protection integration tests give us, especially if we start to do one-off fixes for it.
Flags: needinfo?(kgrandon)
Flags: needinfo?(apastor)
|
|
||
Comment 8•10 years ago
|
||
Alberto, you wanna do the honors? Otherwise I will on Monday.
|
||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S7 (24Oct)
|
|
Assignee | |
Comment 9•10 years ago
|
||
Uplifting in https://github.com/mozilla-b2g/gaia/pull/25317. I will merge it as soon as it gets green.
Flags: needinfo?(apastor)
You need to log in
before you can comment on or make changes to this bug.
Description
•