1074352 - Stastusbar icon color still wrong

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Flash latest master or 2.1 with FTU enabled

Actual results:
The icons are white on a white background.

Expected results:
The icons should be dark on a white background

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, can you take a look here?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:
We blocked on this same issue in bug 1055746, so we need to block here again.

Comment 3

[Gregor Wagner [:gwagner]]

Broken feature

Comment 4

[Aus Lacroix [:aus]]

I think I know what's wrong with this and have a fix for it in bug 1074043.

Comment 5

[Aus Lacroix [:aus]]

Actually, turns out my fix actually breaks things! I removed it from my patch for bug 1074043 and removed the dependency.

Comment 6

[Alberto Pastor [:albertopq]]

Sure, I'll take a look

Comment 7

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24574

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8497613 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24574

Looking good, I especially like the test.

Comment 9

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/f1b66b4110160d5fd045bf2503eaf392509952f0

Comment 10

[Alberto Pastor [:albertopq]]

Comment on attachment 8497613 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24574

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: Icons are hardly visible on the FTU
[Testing completed]: Added unit tests. Manuall tested in 2.1 as well.
[Risk to taking this patch] (and alternatives if risky): Low risk. Just starting to listen an event earlier than it was.
[String changes made]: -

* I think we should back out Bug 1062326. It adds unneeded complexity to the FTU app as soon as this patch lands. Fernando?

Comment 11

[Fernando Campo (:fcampo)]

I don't think we need to backout the bug, it solved a different issue, and those changes will be overwritten anyway when merging bug 1069306 (change the wifi scanning layout color to white). It has already a r+'d patch, waiting for merge)

Comment 12

[Michael Henretty [:mikehenrty][:mhenretty]]

Why would we backout bug 1062326? We need to be able to support apps having the ability to dynamically changing statusbar.

Comment 13

[Alberto Pastor [:albertopq]]

Yeah sorry, I spoke with Fernando offline about it. I confused the statusbar itself with the icons. Nevermind comment #10

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1e1f37b33b7fad36c6b6af4384b1389be5c3064c

Comment 15

[Oliver Nelson [:oliverthor]]

VERIFIED FIX in Master 2.2 and 2.1
Results: Status bar icons display dark on a white background during FTU
************************************************************************

Environmental Variables:
------------------------
Device: Flame 2.2 Master (Full Flash)
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1 (Full Flash)
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0