Closed Bug 108543 Opened 23 years ago Closed 23 years ago

urlbar autocomplete isn't showing search

Categories

(SeaMonkey :: Location Bar, defect)

Product:
SeaMonkey
Component:
Location Bar
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: timeless, Assigned: hewitt)

References

Details

(Keywords: smoketest, Whiteboard: Only works in classic theme)

Attachments

(2 files)

patch
778 bytes, patch
Details | Diff | Splinter Review
this patch really fixes it
5.16 KB, patch
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011105

my smart browsing prefs have everything checked and google as mys search engine

steps: type "cvs log site:mozilla.org" into urlbar

expected results: search for "cvs log site:mozilla.org" using google

actual results: nothing.
Keywords: smoketest
This is happening on Linux 2001103113 as well.
Ack, I see this too on WinXP.  I tried to reset the settings in preferences, but
it doesn't work.  Very inconvenient.
I saw this only once on build 2001110121. Also, i saw once a blank line. Also,
sometimes the icons are missing. Also, my links are being forgotten.

I am very tempted to start a tracking bug that handles all stuff in the url bar.
We have had way too many regressions
isn't this a dupe? somebody help me out.
I don't think this is a dupe.  It's a very recent regression.
I really don't see any dupes... can someone get on this? It's catfood for me...
still using Oct 26th build since it's the last one that had it working. (Or
something else serious was broken in the 27/28 builds... but around that time)
OS: Windows 98 → All
Hardware: PC → All
i would use oct26 <last known good>, but i'm using n6.2 instead.
Severity: normal → major
Keywords: mozilla0.9.6
maybe search from the URL bar had been removed/changed.. after all, some of us
dont use the Location bar for searching.
today the search prefs panel engine <select> is completly broken as well, which
isn't helping this problem.
See also 108043
Dennis: Searching from the urlbar is a pref that can be turned off.  I'm sure
this feature isn't going anywhere.
*** Bug 109277 has been marked as a duplicate of this bug. ***
Targeting myself, since this is just sitting around. Hewitt if you're
overloaded, is there anyone else you can pass this to? I am still using a build
from the 26th solely because of this issue (normally update my tree daily).
Keywords: mozilla0.9.6
Target Milestone: --- → mozilla0.9.6
Attached patch patch — — Splinter Review 

    
    

    
  
Hewitt:  I may have jumped the gun, but I applied your patch and it didn't fix
the problem.  Thanks for working on this, in any case :)

    
    

    
  
*** Bug 109619 has been marked as a duplicate of this bug. ***

    
    

    
  
Patch doesn't seem to help me either.

    
    

    
  
*** Bug 109667 has been marked as a duplicate of this bug. ***

    
    

    
  
This wfm with a 1-hour old cvs build on linux (minus bug 87998)

    
    

    
  
Still broken under Windows ME with the newest 2001111303 build

    
    

    
  
*** Bug 109903 has been marked as a duplicate of this bug. ***

    
    

    
  
The above patch doesn't fix the problem, but it was needed to fix the problem,
so I landed it.  There is still something else going on wrong here.
Status: NEW → ASSIGNED

    
    

    
  


  
We had all these unnecessary !importants on all the -moz-binding rules for
autocomplete content.  Removing them fixes this.  I am also removing some
redundant stylesheet loads that make style resolution slower for autocomplete
stuff.

    
    

    
  
Is !important broken in some way?

    
    

    
  
!important isn't broken, but when bz landed his changes to the cascade order,
this regressed because a !important rule xul.css begain overriding a !important
rule in chrome://navigator/content/navigator.css.  The !important just wasn't
necessary at all in xul.css anyway.

    
    

    
  
jag says r=jag, hyatt says sr=hyatt

    
    

    
  
fixed on trunk, time to ask for branch approval

    
    

    
  
can this have caused bug 110203?

    
    

    
  
No. This was checked in 19 minutes *after* I filed bug 110203. And actually more
than 2 hours after I pulled the tree.

    
    

    
  
a=blizzard on behalf of drivers for 0.9.6
Keywords: mozilla0.9.6+

    
    

    
  
This new build (2001111503) is now working on Windows ME, but the little "G"
(for Google) logo on the search engine dropdown has disappeared.

    
    

    
  
WFM 2001111504 MacOS 8.6 and logo of Google is displayed...

    
    

    
  
*** Bug 110222 has been marked as a duplicate of this bug. ***

    
    

    
  
Has this been checked into the 0.9.6 branch yet?

    
    

    
  
I just downloaded the last build 2001111503, and although the search work in the
URL bar, the autocomplete does not!  It is selected in the prefs, but
autocomplete simply does not fuction in the URL bar. Looks like you broke it
with this fix?

    
    

    
  
Confirmed, autocomplete is broken... Build 2001111506 Linux

    
    

    
  
Please read the bug before commenting. In comment #29 I said that the new
problem is bug 110203 which was reported (by me) *before* the fix for this bug
landed.

    
  
Whiteboard: need branch approval

    
    

    
  
am i missing something or doesn't comment #30 mean this checkin is approved for
the branch? Changing status whiteboard text.
Whiteboard: need branch approval → a=blizzard on behalf of drivers for 0.9.6

    
    

    
  
Checked into the 0.9.6 branch.

    
    

    
  
thanks for checking that in for me, chris.  
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Using Build 2001111503 on Windows NT, searching only works with the (ugly)
classic theme.  Using the modern theme, search does not work.  So I don't think
it is fixed...

Further, the icon of the search engine does not show.

    
    

    
  
Reopening due to comments... Updating whiteboard
The icon not showing is another bug already reported.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: a=blizzard on behalf of drivers for 0.9.6 → Only works in classic theme

    
    

    
  
I'm using 2001111521 linux with modern and search is showed in autocomplete.
The non-showing icon is bug 87998.

    
    

    
  
I had the same problem with modern so I changed to classic and back to modern
which seemed to cure it.

    
    

    
  
We need more users to test this workaround (changing themes)
We may need to include a release note for 0.9.6
I have already notified the people in the 0.9.6 release notes tracking bug

    
    

    
  
I'm now using Build 2001111603 on Windows 2000.

After I started this Mozilla build for the first time using my old profile, it
started with the Modern theme.  Searching works.

I changed to Classic theme and restarted.  Searching works.

I changed back to Modern and retarted. Searching works.

I'd say, the bug is fixed.

    
    

    
  
Using Build 2001111608 on Linux; search works.

    
    

    
  
All right, marking fixed again since latest windows and linux builds work
Someone verify
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
Please reopen!

Using current builds (2001120608 on Linux ATM), internet search doesn't always
work.  Right now, if I type in some text in the adress bar, no icon is shown for
Google (the selected search engine).  Sometimes, Internet Search doesn't work at
all.

This is with Modern theme.  But sometimes it also works with Modern theme.

    
    

    
  
I now switched to Classic theme, and it also doesn't show an icon.

    
    

    
  
Icon has been broken for about a year now. Bug 87998.

    
    

    
  
mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: