1093691 - enable e10s by default on Nightly (only)

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Dave Townsend [:mossop]]

Add a new opt in pref along the lines of bug 1058358 comment 1 to enable e10s by default on nightly only.

Comment 1

[Dave Townsend [:mossop]]

Can you give this a points estimate felipe?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

In bug 1058358, besides discussions of going with something simpler, we ended up implementing the proposal from comment 1. So there might not be much needed here besides defining the pref. But I'll ask around on IRC to see if people had other stuff in mind.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

We need to make sure that the test suites are not affected by this change, because the tests that are e10s-ready are already running through special configurations that set e10s = true.

MozMill was already handled in bug 1081996 but mostly everything else will need it. I'll put up the patches for them

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch for talos

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: talose10s

new patch for talos, after talking about it with jmaher

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8516918 [details] [diff] [review]
talose10s

Review of attachment 8516918 [details] [diff] [review]:
-----------------------------------------------------------------

yay, please land this!

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Attachment: Marionette

Don't let the autostart.N prefs affect Marionette runs

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Landed patch for Talos: https://hg.mozilla.org/build/talos/rev/42da1a784ba7

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8516928 [details] [diff] [review]
Marionette

Review of attachment 8516928 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/geckoinstance.py
@@ +27,5 @@
>                        "browser.displayedE10SPrompt.2": 5,
>                        "browser.displayedE10SPrompt.3": 5,
> +                      "browser.displayedE10SPrompt.4": 5,
> +                      "browser.tabs.remote.autostart.1": False,
> +                      "browser.tabs.remote.autostart.2", False}

Sorry, just noticed the typo: s/,/:/

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Attachment: Marionette

Bah!

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Attachment: Talos revision

I'll send all of this through try before landing

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8516940 [details] [diff] [review]
Talos revision

Review of attachment 8516940 [details] [diff] [review]:
-----------------------------------------------------------------

just wait until you see something show up green on try first :)

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Some clarity for anyone who might stumble upon this bug without other context: we're not expecting this to ride the trains.

Comment 14

[:Felipe Gomes (needinfo for replies!)]

Attachment: Enable e10s on Nightly only, and display e10s notice

Comment 15

[:Felipe Gomes (needinfo for replies!)]

Attachment: Turn pref off on mochitest and reftest

This doesn't block the M-e10s tests to properly run, which will continue to use browser.tabs.remote.autostart

Comment 16

[:Felipe Gomes (needinfo for replies!)]

Let's see if there are any tests configurations missing. This try build includes all patches from here:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bc5452c26d82
https://tbpl.mozilla.org/?tree=Try&rev=bc5452c26d82

Comment 17

[:Felipe Gomes (needinfo for replies!)]

From the try run in comment 16, the only remaining harness affected is the Linux-Mulet Reftest. I pushed a new patch to try that should fix that:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cf2a4e06c146
https://tbpl.mozilla.org/?tree=Try&rev=cf2a4e06c146

Comment 18

[:Felipe Gomes (needinfo for replies!)]

Attachment: Safeguard Mulet-Reftest from e10s-on-nightly pref

Comment 19

[Armen [:armenzg]]

Comment on attachment 8517201 [details] [diff] [review]
Safeguard Mulet-Reftest from e10s-on-nightly pref

I don't think I can review this patch as I don't know what it can affect (I think only affects b2g desktop and mulet jobs, however, I'm not sure).

If you want to only affect Linux mulet tests you can use:
"if options.mulet"

Right now we can't get results for mulet reftests since they're checking for updates and that causes to hit the network which we block:
https://bugzilla.mozilla.org/show_bug.cgi?id=1043699#c100

You can try the patch with this workaround which removes the block on the network:
https://hg.mozilla.org/try/rev/be3fb02d83bd

Comment 20

[Armen [:armenzg]]

FYI Mulet reftests are not tier-1, the jobs were shown visibly on the Try tree for 1 day or two by mistake.

I hope that helps!

Comment 21

[:Felipe Gomes (needinfo for replies!)]

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #20)
> FYI Mulet reftests are not tier-1, the jobs were shown visibly on the Try
> tree for 1 day or two by mistake.
> 
> I hope that helps!

Ah ok! It definitely helps. I see other pushes to try and they are equally red, so maybe it's not even due to this change. In any case, we don't need to make Linux-mulet green here to land these

Comment 22

[:Felipe Gomes (needinfo for replies!)]

Landed all the preparatory patches, just need to land the one to actually flip the pref, whenever we get a go!

https://hg.mozilla.org/integration/mozilla-inbound/rev/75c3a88013e6
https://hg.mozilla.org/integration/mozilla-inbound/rev/800cc6225336
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c04ff1ef5a9

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/75c3a88013e6
https://hg.mozilla.org/mozilla-central/rev/800cc6225336
https://hg.mozilla.org/mozilla-central/rev/0c04ff1ef5a9

Comment 24

[Tomislav Jovanovic :zombie]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #13)
> Some clarity for anyone who might stumble upon this bug without other
> context: we're not expecting this to ride the trains.

Comment 25

[:Felipe Gomes (needinfo for replies!)]

Done! https://hg.mozilla.org/integration/mozilla-inbound/rev/a75897e664dd

Comment 26

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a75897e664dd

Comment 27

[Vasilica Tamas, QA [:vtamas]]

I confirm that e10s is enabled by default on Nightly 36.0a1 (2014-11-13) using Windows 8.1 x64, Ubuntu 14.04 x32 and Max OSx 10.8.5.