1114525 - [Contacts] Matching does not work properly when a contact with a number without international prefix has been added with a SIM from another country, or in a roaming condition, or no SIM at all

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Contacts, defect, P2)

Description

[Marcela Oniga]

OS Version: 2.2.0.0 prerelease
Buil no 39
Platform version: 37.0a1
Build identifier: 20141221040207

STR:

1.Set 2 contacts as ICE contacts(make sure you have 2 contacts in address book from 2 different carriers, for testing I used 1 Orange contact and 1 Vodafone)
2.Receive a sms (for receiving sms I used an Orange sim)


Expected results:
SMS should be successfully received and contact's name should be displayed.

Actual results:
SMS is being received but contact's name not displayed, only phone no.

Please note that contact's name was displayed in messaging app for Orange contact but not in notification screen, and for Vodafone contact, the name is not displayed at all just the phone no.

Comment 1

[Johan Lorenzo [:jlorenzo]]

QA wanted for a branch check.

Comment 2

[Cody Roesch [:croesch]]

Hi Marcela,
   Can I ask which device you tested on? 

On the Flame device, I've tested this bug receiving messages from ice contacts which involved AT&T, Verizon and Sprint Cellular services. Each time a message is received the contact always correctly shows the contact name. I made sure I was NOT in the messaging app when the message arrives.

Tested on:
Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141222042411
Gaia: c5b03a9b40a37947d44a71eccd9017e76632f796
Gecko: c357fb08cc10
Version: 37.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Marcela Oniga]

(In reply to Cody Roesch [:croesch] from comment #2)
> Hi Marcela,
>    Can I ask which device you tested on? 
> 
> On the Flame device, I've tested this bug receiving messages from ice
> contacts which involved AT&T, Verizon and Sprint Cellular services. Each
> time a message is received the contact always correctly shows the contact
> name. I made sure I was NOT in the messaging app when the message arrives.
> 
> Tested on:
> Environmental Variables:
> Device: Flame 2.2 KK
> BuildID: 20141222042411
> Gaia: c5b03a9b40a37947d44a71eccd9017e76632f796
> Gecko: c357fb08cc10
> Version: 37.0a1 (2.2) 
> Firmware Version: v188-1
> User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Hi,
I used Flame device as described in summary. I will try to attach some logs asap.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Being an ICE contacts doesn't change anything for the SMS app, in fact, SMS app doesn't know about ICE contacts, which is a feature between contacts and dialer apps.

If we have a problem displaying a contact name in the sms app, let's ask someone from SMS if this problem is familiar to them.

Comment 5

[Julien Wajsberg [:julienw]]

Are the contacts from Facebook?

Comment 6

[Marcela Oniga]

(In reply to Julien Wajsberg [:julienw] (PTO until 1/5) from comment #5)
> Are the contacts from Facebook?

No, the contacts are not from Facebook.

Comment 7

[Julien Wajsberg [:julienw]]

Does it work as expected for other contacts ?

Are they contacts you entered manually ? If yes, were you in roaming condition ?

When removing them from ICE, does it work ?

Can you search for the contacts from inside the SMS app ?

Thanks in advance for the answers !

Comment 8

[Marcela Oniga]

(In reply to Julien Wajsberg [:julienw] (PTO until 1/5) from comment #7)
> Does it work as expected for other contacts ?

Yes, it does.
> 
> Are they contacts you entered manually ? If yes, were you in roaming
> condition ?

Contacts saved manually on sim card. No roaming.
> 
> When removing them from ICE, does it work ?

Not sure, need to re-try tomorrow.I will get back with an answer asap.

> 
> Can you search for the contacts from inside the SMS app ?

Yes I can.
> 
> Thanks in advance for the answers !

Comment 9

[Julien Wajsberg [:julienw]]

It could help if you can give me your contacts and sms databases. Feel free to send me privately if there are any private information in it.

Comment 10

[Marcela Oniga]

(In reply to Julien Wajsberg [:julienw] (PTO until 1/5) from comment #9)
> It could help if you can give me your contacts and sms databases. Feel free
> to send me privately if there are any private information in it.

I think I found the issue, and yes it might have nothing to do with ICE contacts.
I removed them from ICE and is still the same, but I noticed that, for example I have a phone no. saved in my address book without country code (for Romania Dialing Code is +40) so if I receive the sms from that contact but with country code, then the name is not recognized.


To be more clear: I have the phone no saved as 0722xxxxxx, and I receive a sms from the same phone no but with country code +40722xxxxxx. This is the case when the name is not displayed, just the phone no.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Per comment 10.

Comment 12

[Julien Wajsberg [:julienw]]

This is something that should work in SMS, unless the phone number was entered if you had another SIM, no SIM, or in roaming condition.

Anyway contact matching is in DOM::Contacts, we don't use a special lib in SMS like we do in Dialer.

You could try to resave the phone number in the same form (remove one digit, save, add the digit again, save again), then it should work. I still think we have something buggy somewhere.

Comment 13

[Julien Wajsberg [:julienw]]

BTW I wonder what happens if one user enters a contact in "national" format when there is a SIM that is not connected (for some reason).

Comment 14

[Johan Lorenzo [:jlorenzo]]

Wrong blocking bug.

Comment 16

[Julien Wajsberg [:julienw]]

Johan, qawanted is waiting since October 2014.

Comment 17

[Johan Lorenzo [:jlorenzo]]

Is it possible for somebody at QAnalysts to take a look at this bug? Based on comment 10 and comment 12, the STR should be:

Pre-requisite: Have no SIM card. Have a contact in on outlook/gmail, with a phone number that has no country code (like 650-123-4567). 

1. Import your contacts.
2. Put a SIM card back in your phone. The carrier must show the country code (in the US, T-Mobile does it)
3. Receive a call from your contact.

Comment 18

[Duane Dixon [:ddixon]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #17)
> Is it possible for somebody at QAnalysts to take a look at this bug? Based
> on comment 10 and comment 12, the STR should be:
> 
> Pre-requisite: Have no SIM card. Have a contact in on outlook/gmail, with a
> phone number that has no country code (like 650-123-4567). 
> 
> 1. Import your contacts.
> 2. Put a SIM card back in your phone. The carrier must show the country code
> (in the US, T-Mobile does it)
> 3. Receive a call from your contact.

I performed this STR with a T-Mobile SIM.  Upon receiving a call from the imported contact that was without a country code (360-xxx-xxxx), the number was recognized at the call screen and displayed the proper name and the phone number as it was saved (360-xxx-xxxx).  

If I included the country code (1-360-xxx-xxxx), the number and name would be displayed as it was saved upon receiving the call= 1-360-xxx-xxxx.   

Environmental Variables:
Device: Flame 2.5 (engineering build)
BuildID: 20150823193052
Gaia: cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gecko: 8a6045d14d6bd348a3b5bfeb55a9321e680cc93e
Version: 43.0a1 (Master) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 19

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Please see comment 18 Johan

Comment 20

[Johan Lorenzo [:jlorenzo]]

Okay, in that case, we need to check the case where contacts are imported while being in a foreign country. I don't add qawanted, because this can't be reproduced in any of our labs.

Comment 21

[Julien Wajsberg [:julienw]]

Can we please try the same STR but receiving a SMS instead of receiving a call ?

Comment 22

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Setting qawanted for comment 21.

Comment 23

[Duane Dixon [:ddixon]]

(In reply to Julien Wajsberg [:julienw] from comment #21)
> Can we please try the same STR but receiving a SMS instead of receiving a
> call ?

I repeated the STR on the latest Flame engineering build and saw the same results as Comment 18.  The contact's name and number will appear as it was saved upon reception of a SMS.  I used the same T Mobile SIM card as last time, as well.  

Environmental Variables:
Device: Flame 2.5 (engineering build)
BuildID: 20150825064330
Gaia: b441bde54293bea5254dc340845effe951fa3906
Gecko: f3df9cd1701f617418ebf1a7a5947150d5d24939
Version: 43.0a1 (Master) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 26

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

[Blocking Requested - why for this release]:

Bug 1198796 was a dupe of this issue and marked as a 2.5 blocker.

Comment 27

[Johan Lorenzo [:jlorenzo]]

Carrying flags from bug 1198796.

Comment 28

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:

Changing status to evaluate again, I don't think we should block on this. Waiting for tomorrows triage to discuss this.

Comment 29

[Julien Wajsberg [:julienw]]

Agreed with Francisco. Although this is painful.

Comment 30

[Julien Wajsberg [:julienw]]

I just found a comment in the PhoneNumber lib mentioning bug 926740; we have the same requirement here: PhoneNumber.Parse will need to return several results instead of just one.

Comment 32

[Mahendra Potharaju [:mahe]]

Francisco, 

Can you please discuss this again in your triage meeting?

Thanks

Comment 33

[Johan Lorenzo [:jlorenzo]]

Comms triage: Not a blocker, but high priority to fix.

Comment 34

[Ben Kelly [:bkelly, not reviewing]]

Contacts API is no more.