1122328 - Add Finnish (fi), Armenian (hy-AM), Burmese (my) to master / Add Ewe (ee), Lingala (ln), Wolof (wo), Igbo (ig), Yoruba (yo), Hausa (ha) and locales to 2.0, add Wolof keyboard + generic keyboard for Africa to 2.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Théo Chevalier]

This bug should land what we need for the following bugs:

bug 1067557
bug 1113426
bug 1114860

Looks like the best to do for next week is to land a generic keyboard for all African locales that don't have their own keyboard.
Ibrahima created a specific keyboard for Wolof in bug 1113426, so I just tested it add added it to the PR.

Also, it looks easier to land all requested 2.0 locales on the same PR.
af keyboard has not been mapped here, because it should land anytime from now on bug 1113365.

I've done the PR for master only for now, to get it r+ and be sure it's okay before creating 3 other PR. (I can do that over the weekend).

What's specific to master: adding fi, hy-AM (locale + keyboard mapping), my (locale).
This has already landed on master only. (and 2.2 since we branched out this week).

Stas, any chance you could give it a look? :)

Comment 2

[Théo Chevalier]

>This bug should land what we need for the following bugs:
>bug 1113426
I meant bug 1118036, and not bug 1113426.

Comment 4

[Théo Chevalier]

Attachment: Master PR

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 8549996 [details] [review]
Master PR

This looks good to me, thanks!  In particular, I appreciate that you also added missing layouts for languages already defined in languages_all.json.

Flagging Rudy for the technical review of the new keyboards.  Can you take a look, please?

Comment 7

[Théo Chevalier]

Attachment: 2.1 PR

Comment 8

[Théo Chevalier]

Attachment: 2.2 PR

Comment 9

[Théo Chevalier]

Attachment: 2.0 PR

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8549996 [details] [review]
Master PR

I don't understand this patch, so please help me clarify the following questions before getting to the review,

 1. For en-African, do we need a en-US layout that using en-GB as the dictionary?
 2. For new layout files, please help make it conform to the new format, like in 
apps/keyboard/js/layouts/en-GB.js
    Sorry if this caused confusion, I should probably update en.js first so that people would take that as an example.
 

--
Note: in general, I would prefer we submit only one layout in a bug, which is easier for tracking.

Thanks!

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Théo,

Please be informed for master and v2.2, we need the new format, which will define "pages".
However, for the branches of 2.1 or earlier, we should keep it as the old format.

Please help let me know if you need any other info or help from my side.
Thanks.

Comment 12

[Théo Chevalier]

Hey Rudy, sorry this bug is not clear. Let me add some details.

(In reply to Rudy Lu [:rudyl] from comment #10)
> Comment on attachment 8549996 [details] [review]
> Master PR
> 
> I don't understand this patch, so please help me clarify the following
> questions before getting to the review,
> 
>  1. For en-African, do we need a en-US layout that using en-GB as the
> dictionary?

Yes, that's precisely what we've been asked for by localizers.

>  2. For new layout files, please help make it conform to the new format,
> like in 
> apps/keyboard/js/layouts/en-GB.js
>     Sorry if this caused confusion, I should probably update en.js first so
> that people would take that as an example.

No problem, will fix the "pages" thing for master/2.2.

> --
> Note: in general, I would prefer we submit only one layout in a bug, which
> is easier for tracking.

Under normal circumstances, I wouldn't have done this, but the thing is that partner is asking us to get this stuff landed on 2.0 by Friday, and currently the amount of paperwork required to land on 2.0 is insane. Trying to get the best compromise here.

Comment 13

[Théo Chevalier]

Okay, I fixed:
- the keycode in wo.js for master/2.2/2.1/2.0 
- the "pages" thing for en-Africa.js and wo.js on master/2.2

I'd say I'm ready. Could you take a look please?

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8549996 [details] [review]
Master PR

Looks good to me.
Thanks!

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8550653 [details] [review]
2.2 PR

I don't think you need a separate pull request for 2.2.
The patch for master should be able to be uplifted to v2.2.

But anyway, I'll give a r+ here.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8550652 [details] [review]
2.1 PR

r=me.
Thanks.

Comment 17

[Wesly Huang (EPM)]

[Triage] tag for 2.0.

Comment 18

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8550654 [details] [review]
2.0 PR

Sorry that forgot to check v2.0 layout definition.
As you can see from the en.js layout file, that the format is slightly different, that have "visible" property defined for some keys.

Please help to derive the format files by referencing en.js.
Thanks.

Comment 19

[Théo Chevalier]

Comment on attachment 8550654 [details] [review]
2.0 PR

Actually I didn't notice that my en-African.js was very different from en.js on 2.0. So what I did to be extra safe is copy-pasting en.js content from 2.0.

Checked on 2.0 device, en-GB auto-correct seems to work fine (color vs. colour).

Do you mind giving it another (hopefully last) look?

Comment 20

[Théo Chevalier]

Oh, also setting checkin-needed since master PR got r+ from both of you.

Comment 21

[Staś Małolepszy :stas]

Comment on attachment 8550652 [details] [review]
2.1 PR

r=me for l10n changes.

Comment 22

[Staś Małolepszy :stas]

Comment on attachment 8550653 [details] [review]
2.2 PR

r=me for l10n changes.

Comment 23

[Staś Małolepszy :stas]

Comment on attachment 8550654 [details] [review]
2.0 PR

r=me for l10n changes.

Comment 24

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8550654 [details] [review]
2.0 PR

Looks good.

Théo, thanks for working on this!

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/f1a6a82702153b77ba54168a135d3490f9198c91

Please request the appropriate Gaia approvals on the branch patches when you get a chance :)

Comment 26

[Théo Chevalier]

Comment on attachment 8550652 [details] [review]
2.1 PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: no l10n, no keyboard layout
[Testing completed]: tested on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 27

[Théo Chevalier]

Comment on attachment 8550653 [details] [review]
2.2 PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: no l10n, no keyboard layout
[Testing completed]: tested on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 28

[Théo Chevalier]

Comment on attachment 8550654 [details] [review]
2.0 PR

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: no l10n, no keyboard layout
[Testing completed]: tested on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 29

[Delphine Lebédel]

BD meeting this morning confirmed this was super urgent. Can we get this on 2.0 by the end of the week? thanks

Comment 30

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ababd4dec4c9034f68480e7aa2684dadcb67b2b6
v2.1: https://github.com/mozilla-b2g/gaia/commit/2119de79b6edfbcd4f112b2f797dbd7dba17ea69
v2.0: https://github.com/mozilla-b2g/gaia/commit/2989f2b2bd12fcc0e9c017d2db766e76a55873b8

Comment 31

[Alissa（leave from Mozilla）]

Hi Ryan,Could you help me to verify this issue,Is there are some detail steps we can do to verify this issue on my devie?

Comment 32

[Ryan VanderMeulen [:RyanVM]]

That's a question for the bug assignee, not the person who landed the patch on their behalf.

Comment 33

[Francesco Lodolo [:flod]]

(In reply to Alissa from comment #31)
> Hi Ryan,Could you help me to verify this issue,Is there are some detail
> steps we can do to verify this issue on my devie?

You can't easily verify this bug because we're not including all available keyboards in our builds. 

1) You need a build of Gaia with GAIA_KEYBOARD_LAYOUTS=en,en-Africa to load en-Africa layout
2) Pick one of these locales, check that the layout selected in settings is correct
3) Check that the autocorrect is en-GB and not en-US (e.g. color vs colour)

Comment 34

[Friedel Wolff]

I just saw this commit. Well done on the work so far.

I'm not really involved in Wolof specifically, but I was wondering if it isn't worth while to also add the French input method for Wolof. It is the major international language used and the official language of Senegal.

With regards to the en-Africa. Am I correct that it just duplicated the current en.js? Shouldn't we maybe add the characters used in the targetted languages? From a quick look the character repetoir looks quite European.

For Ewe we need things like èíòáʋɔŋɖƒɔẽɛɣ and the combination ɔ̃ (based on a quick look on Wikipedia). Currently you can't even type the name of the language itself (Èʋe/Èʋegbe)
 
For Lingala:
https://en.wikipedia.org/wiki/Lingala#Alphabet
á â ǎ
é ê ě
ɛ́ ɛ̂ ɛ̌
í î ǐ
ó ô ǒ
ɔ́ ɔ̂ ɔ̌
ú

For Hausa:
ɓɗƙƴ
https://en.wikipedia.org/wiki/Hausa_language#Boko_.28Latin.29

For Yoruba and Igbo I think we need something more complex (they use double diacritics as far as I know). I guess we can just add the full repertoir to each vowel, but we probably need something more similar to Vietnamese, although I don't think it is quite as complicated as Vietnamese. Some more possibly useful inspiration here:
https://en.wikipedia.org/wiki/Pan-Nigerian_alphabet
We can probably get away with just adding these for now:
ɓɗǝẹịƙọṣụ

For the South African languages, these should be enough: šḓḽṅṋṱ

Then there are some commonly used characters over several languages, some covered by this old standard:
https://en.wikipedia.org/wiki/ISO_6438


I realise we are close to wanting to finish this. What is the quickest way to review/discuss?

Comment 35

[Staś Małolepszy :stas]

(In reply to Friedel Wolff from comment #34)

> With regards to the en-Africa. Am I correct that it just duplicated the
> current en.js? Shouldn't we maybe add the characters used in the targetted
> languages? From a quick look the character repetoir looks quite European.

I think the goal here was to add an English layout with a version of text prediction that is more fitting in Africa (en-GB).  For other characters, I think a better solution would be to create language-specific layouts, and offer en-Africa as a second available option.  We already do this for many non-Latin script languages, like Greek:

https://github.com/mozilla-b2g/gaia/blob/d08f17bf8e9908b5c08eeb21368e995ddf163aee/build/config/keyboard-layouts.json#L42-L44

I suggest we use your research from comment 34 (thanks!) and file new bugs to create new layouts.

Comment 36

[Friedel Wolff]

I guess people will want this in a different bug, so I added bug 1125078, with an initial patch.

Staś, I realise this is for English, but it is the complete (only) typing experience we offer them. The idea of a region-based layout is also quite interesting, since we might cover many languages, as these characters are often shared between languages in the same areas -- even if we didn't intend to target every one of those languages specifically. In reality we (or rather business development) are targeting countries (not languages) and choosing some major languages in them, while having things on sale for the whole population speaking many languages.

Of course this is no substitute for proper language-specific input (as is being attempted for some languages), but makes even more sense than adding the Polish characters to the English layout while we have a Polish layout. (Currently it has ćęłńśź etc). I'm merely trying to add some of these characters so that people can write their names, towns, and maybe some messages in languages as they prefer. Currently we offer them less relevant characters (like the Danish and Polish ones).