Closed Bug 1142285 Opened 5 years ago Closed 4 years ago

in article with collapsed sections <h1> headings are not shown properly when used with {for}

Categories

(support.mozilla.org :: Knowledge Base Software, task, P2)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: philipp, Assigned: rehan)

References

()

Details

(Whiteboard: p=2 s=)

for example see https://support.mozilla.org/en-US/kb/how-stop-firefox-automatically-making-connections#firefox:win7:fx38 - the last two headings ("loopback connection" & "infected with malware") which are within a {for} section are not properly displayed and get added as a subsection to the "media" section instead
Sorry for mentioning here, but are missing ShareArticle links in articles with collapsed sections intentional?
(In reply to Ton from comment #1)
> Sorry for mentioning here, but are missing ShareArticle links in articles
> with collapsed sections intentional?

???
I see Share this article: http://mzl.la/1BAQzbn at the end of the en-US article,
https://support.mozilla.org/en-US/kb/how-stop-firefox-automatically-making-connections
(In reply to philipp from comment #0)
> for example see
> https://support.mozilla.org/en-US/kb/how-stop-firefox-automatically-making-connections#firefox:win7:fx38 
> - the last two headings ("loopback connection"
> & "infected with malware") which are within a {for} section are not properly
> displayed and get added as a subsection to the "media" section instead

Those headings have since been revised to remove {for} as a workaround this bug, as discussed here: https://support.mozilla.org/en-US/kb/how-stop-firefox-automatically-making-connections/discuss/5985#post-11484
(In reply to Alice Wyman from comment #2)
> (In reply to Ton from comment #1)
> > Sorry for mentioning here, but are missing ShareArticle links in articles
> > with collapsed sections intentional?
> 
> ???
> I see Share this article: http://mzl.la/1BAQzbn at the end of the en-US
> article,
> https://support.mozilla.org/en-US/kb/how-stop-firefox-automatically-making-
> connections

I'm sure they weren't there before (at least on my end) and neither in their localized versions (de/it/pt-BR), but those do have them now so something must have changed. The en-US version is a bad example now as its collapsed headers are gone after renaming it (I guess they only work for the 'original' slugs defined in config.py), but the others all appear to be contributor articles so it may be intentional. Example: https://support.mozilla.org/en-US/kb/firefox-android-support-forum-contributors - Do you see them there?

(In reply to Alice Wyman from comment #3)
> 
> Those headings have since been revised to remove {for} as a workaround this
> bug, as discussed here:
> https://support.mozilla.org/en-US/kb/how-stop-firefox-automatically-making-
> connections/discuss/5985#post-11484

That link probably is now https://support.mozilla.org/en-US/kb/how-stop-firefox-making-automatic-connections/discuss/5985#post-11484 (yes, t would be nice if such links were also able to 'redirect'.;) )
(In reply to Ton from comment #4) 

Kbforum links not redirecting after the article title is changed is bug 673944.  

Missing collapsed headers after the article is renamed is discussed in https://support.mozilla.org/en-US/kb/how-stop-firefox-making-automatic-connections/discuss/6019 

What articles get "Share" links is discussed in https://support.mozilla.org/en-US/forums/knowledge-base-articles/710484
Here's another example of this bug:
https://support.mozilla.org/en-US/kb/adobe-flash-plugin-has-crashed 

The "Disable Flash protected mode" section {for win7,win8} is missing from the collapsed list, even though you view the article for Windows 8 or Windows 7/Vista.
Blocks: 1141677
> Here's another example of this bug:
> https://support.mozilla.org/en-US/kb/adobe-flash-plugin-has-crashed 
> 
> The "Disable Flash protected mode" section {for win7,win8} is missing from
> the collapsed list, even though you view the article for Windows 8 or
> Windows 7/Vista.

Joni just posted in https://support.mozilla.org/en-US/kb/adobe-flash-plugin-has-crashed/discuss/6070 that collapsed sections were added to all articles with a Table of Contents.  As a short-term workaround until this bug is fixed, Joni removed the TOC from the example article.
These bugs aren't blocked by this bug. They are related, but it is just a "see also" relation.

I'm putting this into the next sprint (Which starts tomorrow, may 12th). I'm estimating this as 2 points, since it probably involves interacting with the showfor parser, which is not simple.
No longer blocks: 1079413, 1141669, 1141677
See Also: → 1079413, 1141669, 1141677
Whiteboard: p=2 s=2015.9
Priority: -- → P2
Assignee: nobody → rdalal
Status: NEW → ASSIGNED
We have decided to stop the implementation of the collapsible sections user story, until we are sure we want to go forward with the idea. In the mean time Joni will try different approaches and we'll move forward with one of those in one of the next sprints.

I'm leaving it in the sprint in case you have started working on it already, Rehan. If not, we'll remove it from the sprint.
Status: ASSIGNED → NEW
@Kadir: feel free to drop it.
Dropped.
Whiteboard: p=2 s=2015.9 → p=2 s=
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
See Also: → 1158595
You need to log in before you can comment on or make changes to this bug.