114962 - [FIX] Bookmarks menu in menubar should open when link is dragged over it.

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[C. Hodsdon]

Also see Bug 100479 and Bug 30861
If the Personal Toolbar is closed the user must now have either Bookmark Manager
opened or the Sidebar bookmarks opened to drag/drop bookmarks.  

The "Bookmark" menu item should open and allow the filing of a bookmark when a
link is dragged on top of it.  This action is allowed in IE with its "Favorites"
menu item.

Comment 1

[:deanis74]

This is a dupe, but my headache is preventing me from searching for the other bug.

Comment 2

[djk]

I think the dup is bug 19437

Comment 3

[C. Hodsdon]

Guess I didn't search hard enough.
Duplicate of BUG 19437

*** This bug has been marked as a duplicate of 19437 ***

Comment 4

[Chris Lyon]

*** Bug 130360 has been marked as a duplicate of this bug. ***

Comment 5

[Chris Lyon]

*** Bug 135917 has been marked as a duplicate of this bug. ***

Comment 6

[Jesse Ruderman]

*** Bug 141292 has been marked as a duplicate of this bug. ***

Comment 7

[Jesse Ruderman]

This bug could be fixed without fixing bug 19437, and parts of 19437 could be
fixed without fixing this bug.

Comment 8

[Cees T.]

I tried this in my navigatorOverlay.xul, it gives me a drop target but the menu
won't open on drag :/

    <menu id="BookmarksMenu" label="&bookmarksMenu.label;"
accesskey="&bookmarksMenu.accesskey;" 
          datasources="rdf:bookmarks rdf:files rdf:localsearch rdf:internetsearch" 
          ref="NC:BookmarksRoot" container="true" flags="dont-test-empty" 
          template="bookmarksMenuTemplate"
          oncommand="OpenBookmarkURL(event.target, this.database)" 
          ondragdrop="nsDragAndDrop.drop(event, personalToolbarDNDObserver);
event.preventBubble()"
          ondragenter="nsDragAndDrop.dragEnter(event,
personalToolbarDNDObserver); event.preventBubble()"
          ondragexit="nsDragAndDrop.dragExit(event, personalToolbarDNDObserver);
event.preventBubble()"
          ondragover="nsDragAndDrop.dragOver(event, personalToolbarDNDObserver);
event.preventBubble()">

not even when I replaced the last line with

          ondragover="nsDragAndDrop.dragOver(event, personalToolbarDNDObserver);
OpenBookmarkURL(event.target, this.database); var toolbar =
document.getElementById('main-menubar');
toolbar.setAttribute('dd-triggerrepaint', 0)">

Using trunk build 2002072718 on Windows ME.

Comment 9

[Pierre Chanial]

taking

Comment 10

[Pierre Chanial]

Attachment: Patch v1.0

I refactored and generalized a little navigatorDD.js in order that if other
persons want to use that code in another place, it will be straightforward
(doing CT's modifs and adding an observer in
personalToolbarDNDObserver.mObservers) for them. 
I also have in mind to xblify it, but not in a near future.
Current patch drops the handling of the bookmark button in the personal
toolbar. If it's too early, let me know.
r/sr?

Comment 11

[Pierre Chanial]

I have left a dump and I also modify isPlatFormSupported because I am under linux.
Ignore that.

Comment 12

[Cees T.]

Aside from the occasional (seperate) onDragExit bug bites. The patch works
great, I can even drag between the menubar and toolbar menus. =)

Comment 13

[Cees T.]

Shortcuts dragged from my desktop open the menubar's Bookmarks menu but not the
bookmarks toolbar's items. Dunno if that happened before though, and the only
places they get accepted are the content area and the sidebar Bookmarks tab
(though the shortcut to http://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/
doesn't get a title).

Comment 14

[Pierre Chanial]

Attachment: Patch v1.1

Removed the parts that should not be checked in.
I also fixed a glitch introduced by my last patch: the feedback line on the
personal toolbar was not removed when dropping in the empty space.

Comment 15

[Cees T.]

Maybe I hand-patched something wrong, but I just noticed that when I drag a link
over the PT bookmarks menu, multiple subfolders can be open at once while the
menubar bookmarks menu works fine. Also, after rearranging some bookmarks in the
root level of each, I can't drag anything into the bookmark menu's subfolders
anymore apparantly due to the feedback line not going away when hovering over a
folder.

Trunk 2002080718 on WinME with Pinball and Classic themes at 1024x768.

Comment 16

[Pierre Chanial]

*** Bug 164662 has been marked as a duplicate of this bug. ***

Comment 17

[Cees T.]

I'm seeing the same bugs as described in comment #15 using a fresh install of
the 1.3 release and a new profile (save for bookmarks & cookie files). Same with
the February 16(not quite sure) 2003 trunk build I had before...

Comment 18

[Pierre Chanial]

fix is in the bookmark branch

Comment 19

[Cees T.]

Sorry, after some more testing I found it's only the rearranging bug that's
still there. Some occasional unclosed subfolders (dragexit?) confused me.

Comment 20

[Jan Varga [:janv]]

The bookmarks branch has landed.
Fixed.

Comment 21

[Chris Petersen]

This issue has been resolved on both Windows(2003-03-26-08) and Linux
(2003-03-26-12) trunk builds. However, this isn't working on the latest Macho OS
X trunk build (2003-03-25-03). Dragging a url proxy to the Bookmarks menu
doesn't cause the menu list to drop down. 

Comment 22

[Pierre Chanial]

Chris, having it working on MacOS would require a lot of new work since the Mac
toolbar is not handled the same way as the xp one and would need another bug.
Furtermore, I am not sure if such behavior would fit with the Mac UI guide lines.