1150376 - Right click menu does not paint on screen

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Mayank Bansal]

Attachment: about support.txt

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150401180920

Steps to reproduce:

1. Create a new profile
2. Right click on the screen 
OR 
right click on the title bar


Actual results:

the right click menu doesnt paint on screen. Only a transparent border is painted


Expected results:

not so

Comment 1

[Mayank Bansal]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=92aeec7102fe&tochange=96c8ca415e45

is the mozregression range

Comment 2

[Mayank Bansal]

Attachment: bug.png

If i disable HWA, the bug goes away

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Please post your Graphic section from about:support

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

ahhh, nvm, it's in attachments

Comment 5

[GMA]

https://downloadcenter.intel.com/download/22167/

Try updating to the last driver released for Intel 4 Series chipset, 8.15.10.2869. 8.15.10.2302 is very old.

Comment 6

[Mayank Bansal]

Attachment: about support.txt

updated about:support, with updated drivers.
As per intel, for my IGP, the latest drivers were released in 2012. So maybe block this class of IGP's altogether?

Comment 7

[Mayank Bansal]

(In reply to GMA from comment #5)
> https://downloadcenter.intel.com/download/22167/
> 
> Try updating to the last driver released for Intel 4 Series chipset,
> 8.15.10.2869. 8.15.10.2302 is very old.

Did it.
Bug is still reproducible.

Comment 8

[Mason Chang [Inactive] [:mchang]]

Seems to be fallout from bug 1147728 according to comment 1

Comment 9

[Mason Chang [Inactive] [:mchang]]

Bas, does this make sense to you? Thanks!

Comment 10

[Bas Schouten (:bas.schouten)]

(In reply to mayankleoboy1 from comment #6)
> Created attachment 8587382 [details]
> about support.txt
> 
> updated about:support, with updated drivers.
> As per intel, for my IGP, the latest drivers were released in 2012. So maybe
> block this class of IGP's altogether?

Could you post your about support with no custom prefs or settings or anything of the likes set. i.e. with a clean profile?

Comment 11

[Mayank Bansal]

Attachment: new profile about support.txt

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 38+ since this is a recent regression.

Comment 16

[Bas Schouten (:bas.schouten)]

Could someone that can reproduce this bug try this build:

https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-9620d2164545

Comment 17

[Mayank Bansal]

(In reply to Bas Schouten (:bas.schouten) from comment #16)
> Could someone that can reproduce this bug try this build:
> 
> https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> [e-mail]-9620d2164545


I tried it. This build fixed the "right click" issue. 
But it has started giving a new issue : 

1. In the address bar, type "bug"
2. The drop down is blank.

Comment 18

[Mayank Bansal]

Attachment: bug.jpg

Comment 19

[Mayank Bansal]

If this helps:

In the blank drop-down-box, if you put your mouse inside the drop-down-box, and scroll with the wheel, the box paints correctly.

Comment 20

[Mayank Bansal]

(In reply to mayankleoboy1 from comment #19)
> If this helps:
> 
> In the blank drop-down-box, if you put your mouse inside the drop-down-box,
> and scroll with the wheel, the box paints correctly.


Additionally, when the drop-down-box becomes visible, it doesnt scroll correctly, neither with the scroll bar, nor with the mouse scroll button. When i try to scroll. the entries wont move up or down. But suddenly they would just move randomly. When i try to scroll with the scroll bar, the scroll bar will get stuck and wont move.

Plus the CPU use is higher while i try to scroll: 
In the HWA disabled case -> ~5%
In HWA enabled case-> ~17%

Comment 21

[Bas Schouten (:bas.schouten)]

(In reply to mayankleoboy1 from comment #17)
> (In reply to Bas Schouten (:bas.schouten) from comment #16)
> > Could someone that can reproduce this bug try this build:
> > 
> > https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> > [e-mail]-9620d2164545
> 
> 
> I tried it. This build fixed the "right click" issue. 
> But it has started giving a new issue : 
> 
> 1. In the address bar, type "bug"
> 2. The drop down is blank.

Did this drop down box work correctly in a regular nightly for you?

Comment 22

[Mayank Bansal]

(In reply to Bas Schouten (:bas.schouten) from comment #21)
> (In reply to mayankleoboy1 from comment #17)
> > (In reply to Bas Schouten (:bas.schouten) from comment #16)
> > > Could someone that can reproduce this bug try this build:
> > > 
> > > https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> > > [e-mail]-9620d2164545
> > 
> > 
> > I tried it. This build fixed the "right click" issue. 
> > But it has started giving a new issue : 
> > 
> > 1. In the address bar, type "bug"
> > 2. The drop down is blank.
> 
> Did this drop down box work correctly in a regular nightly for you?

No.  
Tried with the latest nightly, and with HWA enabled,  i get this blank drop down.
So a different bug?

Comment 23

[Bas Schouten (:bas.schouten)]

(In reply to mayankleoboy1 from comment #22)
> (In reply to Bas Schouten (:bas.schouten) from comment #21)
> > (In reply to mayankleoboy1 from comment #17)
> > > (In reply to Bas Schouten (:bas.schouten) from comment #16)
> > > > Could someone that can reproduce this bug try this build:
> > > > 
> > > > https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> > > > [e-mail]-9620d2164545
> > > 
> > > 
> > > I tried it. This build fixed the "right click" issue. 
> > > But it has started giving a new issue : 
> > > 
> > > 1. In the address bar, type "bug"
> > > 2. The drop down is blank.
> > 
> > Did this drop down box work correctly in a regular nightly for you?
> 
> No.  
> Tried with the latest nightly, and with HWA enabled,  i get this blank drop
> down.
> So a different bug?

It's the same bug just for a different type of window :s. This is tricky, can you make a screencast of what happens when you scroll?

Comment 24

[Mayank Bansal]

I give up on trying to do a screencast with screenr. :(

Can i directly share my screen with you or something using webrtc ?

Comment 25

[Mayank Bansal]

Attachment: Screen 04-08-2015 22-14-18.avi

OK. Here is a screen capture.

Red circles = left click
Green circle = right click

When the cursor is inside the box, i am trying to scroll with the mouse wheel.

Comment 26

[Sylvestre Ledru [:Sylvestre]]

Bas, does the video help? Thanks

Comment 27

[Bas Schouten (:bas.schouten)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #26)
> Bas, does the video help? Thanks

Not sufficiently, we -really- need a machine that reproduces this problem in the hands of someone who can work with a firefox build and a debugger.

Comment 28

[Jeff Muizelaar [:jrmuizel]]

(In reply to Bas Schouten (:bas.schouten) from comment #27)
> (In reply to Sylvestre Ledru [:sylvestre] from comment #26)
> > Bas, does the video help? Thanks
> 
> Not sufficiently, we -really- need a machine that reproduces this problem in
> the hands of someone who can work with a firefox build and a debugger.

I can reproduce this.

Comment 29

[Bas Schouten (:bas.schouten)]

Attachment: Do not try to use WARP for popup windows

This ought to effectively work around the problem.

Comment 30

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8592994 [details] [diff] [review]
Do not try to use WARP for popup windows

Review of attachment 8592994 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsWindow.cpp
@@ +6582,5 @@
>    // transparent windows so don't even try. I'm also not sure if we even
>    // want to support this case. See bug 593471
>    if (!(prefs.mDisableAcceleration ||
> +        mTransparencyMode == eTransparencyTransparent ||
> +        IsPopup())) {

Please add a comment about why we do this.

Comment 31

[Bas Schouten (:bas.schouten)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc3f816f39ce

Comment 32

[Bas Schouten (:bas.schouten)]

Comment on attachment 8592994 [details] [diff] [review]
Do not try to use WARP for popup windows

Approval Request Comment
[Feature/regressing bug #]: 1147728
[User impact if declined]: On some intel devices popup windows not showing
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Very very low, use non-D3D11 for popups
[String/UUID change made/needed]: None

Comment 33

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc3f816f39ce

Comment 34

[Sylvestre Ledru [:Sylvestre]]

This should be in 38 beta 5 (released tomorrow)
mayankleoboy1, are you going to be available to test it?
Thanks

Comment 35

[Mayank Bansal]

using this: https://hg.mozilla.org/mozilla-central/rev/a35163f83d22

I CANNOT reproduce the bug of right click not painting. :)

However, this still occurs: 
The "nightly button", if clicked *repeatedly*, will still paint as blank.  However, since this is a non-standard configuration, with an addon ( https://addons.mozilla.org/en-US/firefox/addon/classicthemerestorer/  )  so maybe not that important to fix ?

Comment 36

[Mayank Bansal]

Attachment: bug.jpg

notice that this is a non standard config. There is no nightly button in nightlies.

Comment 37

[Liz Henry (:lizzard) (relman/hg->git project)]

It sounds like we may need to back this out, if the regression in bug 115228 has affected 38 and 39 as well as nightly.  

Sylvestre I'm not changing the approval flag (yet) but will leave that to you (for when we have confirmation that it's a problem in 38)

Comment 38

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592994 [details] [diff] [review]
Do not try to use WARP for popup windows

ok, thanks

Comment 39

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592994 [details] [diff] [review]
Do not try to use WARP for popup windows

Too many regressions, not uplifting to aurora

Comment 40

[Sylvestre Ledru [:Sylvestre]]

and reopening.

Comment 41

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I think we can repush it and land it to Aurora and Beta with also patch from bug #1155228, as for now bug #1155228 is no longer an issue because it was fixed.
What do you think about it?

Comment 42

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592994 [details] [diff] [review]
Do not try to use WARP for popup windows

Right, thanks.
I asked for an uplift of bug 1155228.
We need to uplift both at the same time. Hopefully, they will be in 38 beta 6.

Comment 43

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592994 [details] [diff] [review]
Do not try to use WARP for popup windows

The other patch has been approved. Should be in 38 beta 6.

Comment 44

[Ryan VanderMeulen [:RyanVM]]

We generally don't reopen bugs until they're backed out from m-c.

Comment 45

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5eb9e61c6911

Comment 46

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/746934eab883

Comment 47

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

mayankleoboy1, can you confirm this works fine now using the Firefox 38 Beta 6 build (ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/38.0b6-candidates/build1/win32/en-US/Firefox%20Setup%2038.0b6.exe)?

Comment 48

[Mayank Bansal]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #47)
> mayankleoboy1, can you confirm this works fine now using the Firefox 38 Beta
> 6 build
> (ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/38.0b6-candidates/
> build1/win32/en-US/Firefox%20Setup%2038.0b6.exe)?


yup. This is fixed.

Comment 49

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Thank you for confirming! Setting the verified flag.

Comment 51

[Ken Lui]

This is happening on my Nightly x64 installation under Windows 7. My graphics card is an nVIDIA Quadro 2000 with 371.11 WHQL drivers. It appears 2017-05-06 enabled HW acceleration (I had it disabled) and I'm experiencing the exact same symptoms reporter documented here, including the URL bug. Nothing interesting in Graphics Decision Log in about:support.

Could this bug be re-opened and investigated?